From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2FB47A0C50;
	Fri, 23 Jul 2021 22:26:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DE200406A3;
	Fri, 23 Jul 2021 22:26:48 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 472E140683
 for <dev@dpdk.org>; Fri, 23 Jul 2021 22:26:48 +0200 (CEST)
Received: from [192.168.100.116] (unknown [37.139.99.76])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9B67A7F514;
 Fri, 23 Jul 2021 23:26:47 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9B67A7F514
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1627072007;
 bh=gAjvKmgsVCw/FmOw2Eh84xlwVLrUbiGqd2+OWyl/M/c=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=SHwx+pHoxxIbHO70vswOlU1KWxooSqO4dPBxAu6DDiHTMuL2evhC8M0eQ76DIEWJE
 pwyX7Ns0DzUacq0XS1iZta7VWwlcUIc3kJETv/eu4ueY3SR2EAsq4uzpVlkmIwPEGU
 du0XkFZB06t1iGCYMhy9SKYwS3hiRsPyLQwjQpug=
To: David Marchand <david.marchand@redhat.com>,
 Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>
References: <20210412215339.2439530-1-thomas@monjalon.net>
 <CAJFAV8zs0YtUwbg=gpDw_fao2hUU7FZmxPQkdGDLeY_n47mmzA@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <61d96f4e-7a98-50dd-5ab9-8f75460907a7@oktetlabs.ru>
Date: Fri, 23 Jul 2021 23:26:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <CAJFAV8zs0YtUwbg=gpDw_fao2hUU7FZmxPQkdGDLeY_n47mmzA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] devtools: test different build types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/21/21 6:03 PM, David Marchand wrote:
> On Mon, Apr 12, 2021 at 11:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>> @@ -213,9 +218,10 @@ for c in gcc clang ; do
>>                          abicheck=ABI
> 
> init of buildtype var is missing here.

+1

> Rest lgtm.
> 
>>                  else
>>                          abicheck=skipABI # save time and disk space
>> +                       buildtype='--buildtype=minsize'
>>                  fi
>>                  export CC="$CCACHE $c"
>> -               build build-$c-$s $c $abicheck --default-library=$s
>> +               build build-$c-$s $c $abicheck $buildtype --default-library=$s
>>                  unset CC
>>          done
>>   done
> 
> 

with review notes applied:

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>