From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F60D41CB3; Thu, 16 Feb 2023 16:43:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12CAB40EE3; Thu, 16 Feb 2023 16:43:36 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2085.outbound.protection.outlook.com [40.107.100.85]) by mails.dpdk.org (Postfix) with ESMTP id E60D640E03 for ; Thu, 16 Feb 2023 16:43:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PLpBAwFvGZ1sfzDQ2wsjvvbE7PD94W4l7Mp7j9cPwXKwr4Aj/ikeK7GKntmEzahonaOwqYJHUDGV21SEqDKzhGd/nNa/tERnwWlIV0hpaoa8GZC0yrt0lMC63YxuXHZ9Te8j8Zr+ZTfvCtcC5u3NZD43X9LffwoLAHh9iIGFHhFenIquQyFuJXN5mAk0EuK+6w4fWoFnELFubYcntPU4DQ50qvJzfgYbLcHlkFbWru1Tq5Xxq3FsvOw/HpHbOhWGZ9B+1jLndqNsakrncc8EUGntLKzNiUN6nvErFIO3pRxnjiOcEYbLl13Io+IObYrzlKBMendrCBQxBsEiNfR5UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sSDjhoszW/IJ9j/WTufOgy6lldoeT5C8hUQb+GrU1C0=; b=LLgATYTMiMhk5J+03tfLo8uEeAnZhCS0EOF/zcgOuZeHMDVBn8Ag/5KTpB+Oeo1qAmcZ2T06ilLfb1+6Psj+OhUWYOYnmXRyxj2ealnkoPTgtsoWYpiEKV877+c/AOdAhlxGSj4SqbCvcm8jALmdFzp/866ObghE56a9bplKVmCQNR9Jl/AdCdSfMvRYNIak9Fh7RbAHmacprgncOCcGWwBlgSyfCa3/bWxSjan8jvVOgnGvrxvG9Mnw+GGOvfDoQLdyYqcSAQh4VD+Bpwd0sWAey9tQ4lLsoqVvPze5Dx0mTyoZBo6wQo0AB56R8JrX3IqE3N1JloF55QLe4+lqDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sSDjhoszW/IJ9j/WTufOgy6lldoeT5C8hUQb+GrU1C0=; b=xr/b4JvFZnjHM8tZCtwvLL4OceH5UbBF+jzq8L63CC4WGZTY/seWaQVMua7D8JshiaFy5p5FK9xKv7DecdQasOYsXzrxzMZhkLgbl0a8mq1Yjt6Sw2dln8pF38LrT6mqZa2TP6a0xEkr9BKVTCxRQCMIXsfZSzlVu8OiEMPVYHE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7412.namprd12.prod.outlook.com (2603:10b6:806:2b2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 15:43:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 15:43:33 +0000 Message-ID: <61f2a560-f885-ea3b-6b76-b744c4fd048e@amd.com> Date: Thu, 16 Feb 2023 15:43:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v10 1/2] ethdev: add query and update sync and async function calls Content-Language: en-US To: Gregory Etelson , dev@dpdk.org Cc: matan@nvidia.com, rasland@nvidia.com, Ori Kam , Thomas Monjalon , Andrew Rybchenko References: <20221221073547.988-1-getelson@nvidia.com> <20230202134750.10418-1-getelson@nvidia.com> From: Ferruh Yigit In-Reply-To: <20230202134750.10418-1-getelson@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0220.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7412:EE_ X-MS-Office365-Filtering-Correlation-Id: fe4a4310-711a-4e71-5ebc-08db10348f23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2bsz0IN7naSGy6DzOSy//Pl/iXw/WWJBM8aMPOjn6qN9rGoHANs0zK6LGECsqKNXAh8VPbsnsLbw+lBnQ8OUxlz7KsHWmqEUznjlMfxOwGlY0/WW5krthxC6JftuxKcHKI1kBWOY1t3sSXUh86oyk2u2HfBYfGtUXE53QvJmdGUdo2xSj5a22CVjqvYKWhgP8dKfUFA1bSM02+QfWPzhEeIgOTd4tmlGSLMPw3/7i4vDycR4mR4NH5IoNn+uuCSJ2ULJ2cF3c4cEpVoVg9RzwUSrWM0NLEku2Xi6cG+kTLM79SURoK3catNt6SZoOe3xM8FVawwZWl3r6d7iWqIeTupFZKT8c/fBuhJ287sfFWSgTeuP2XlC8kZY+Hi1nSftFcaltjhHx+eKABWhGli5fvzWRINfJfNoRFniveJQ5m6uCledDoyEuXaoerAuukfOhjkeW+0m3V/lVr95WOlX7pj/A7ZN9c++FikpRN5YUhEwPlyfvQxIvjbLfHEsvT7pS7lMcmDK0p91pH/pvEGrf+UZYTXa1tq+v1tTudKBEZay+wy7j2ZUTBxc/sBsP/DUZOKmYvsjgH59KjKC12WPZyf9sJjejNcbqql8QLEkG1uMDHGYHAMajunYfWV0GqxKmbp4wiYpXpxTti6bL3+Jkx9jvceDrmdOlGlNzzhVEZwsu6JV7eHz/Y0d4SL/WTqyH/nbt8mTtjljLkNJiycywm4udipBT9adUh4myHjMxR4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(346002)(396003)(366004)(376002)(39860400002)(451199018)(8936002)(41300700001)(83380400001)(6486002)(31696002)(186003)(478600001)(86362001)(26005)(6512007)(6666004)(53546011)(6506007)(2616005)(36756003)(4326008)(54906003)(66946007)(66476007)(38100700002)(8676002)(66556008)(316002)(44832011)(31686004)(2906002)(15650500001)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFRmbGY4UjFwc0RNdFpHcW50VjU0bzdBa1pxWDZBbDFFWXh1aGdVeXFQMVIw?= =?utf-8?B?ajRIeUVzeWRnTGgwWHhSYmtPQ3k2aU93UlZvK01rdGhXMnptQmpqeDdPVXEz?= =?utf-8?B?Sjl1TUFnUTU5b1ZLV1JmQ1RiSTNQZWQweUxyM24wYTFSQzY0eDZEa3JPUkg3?= =?utf-8?B?cWZlcUlXS0ttMWFpUU0zYVJBOXl0dzBneHR5NEtiTlpTbjc2c0ZaMEE2SCth?= =?utf-8?B?UWxHRFQrT2l2U2pkMWpEMEtTeFZjWTlHZ2RUUW9vT2dCSHllTlJIQVdJanYz?= =?utf-8?B?UUJFdnZQZkFJYTVycXV2Y0xwZFZSU0lqS3NpUHdIY25VeG1MbjZmaUxocWpw?= =?utf-8?B?TjBFazN5elpPM1FiNUJUR3Z2V0hKNXY0RlNYUmtBai9abnBvb0JTZ0Fkb1pP?= =?utf-8?B?MVlidkVRd1lZdUxIck9yUUFWMUZBazRVdGYrakxzeDdPdXFPYnp4MmJzR09W?= =?utf-8?B?S2dyWXJLSHpQaStDbFJVSTBKZHF1ZExqempYdnJtL2JnOEtxQ3JFVlNMKy9S?= =?utf-8?B?aWNzWUw4eHpMaHJ6S2xFSzcrdmNlc2RibTVhSStHUnM3TXpycVMwU05RUVc3?= =?utf-8?B?VzdkVTJ3UDFXZXJYMThjbXFJYkQ1UU8yY20xN09XNHVQTHp1dDRqd1RlQUdh?= =?utf-8?B?bXk0cVRMMVJyT0E2SjRZYzVmOWlCMGxydUJZTXZBTDdmUS9LYUdRZHEwMVp4?= =?utf-8?B?TDVyWlFHQmlFR0dBYnNTeEpYQXdQUlZYT0g2TFFnRXo3SGt0ZXhhc3FPRU9Z?= =?utf-8?B?YVBRUXU1VlhMV0UxNVE0RmdPbmJDemR6cU9EWVBKdzhWbUV6ZVplNlFIODdU?= =?utf-8?B?bGsyVk4wU05UcjF3Y2Y5MWYyVnFhcjRsa1VhYWdVVGE4TnAxRmloYnJRZER0?= =?utf-8?B?Q2w0dUs2V1pwV1BVaDl0dlEvUmdtNGlvc1ZoWFdrL1BhcHkzSkZaL0Vkb0Zj?= =?utf-8?B?VkNXZlB0Rm9RR0JqNDl5VGdSQVRNS1M4QzFQTGRFZEVyUFRwRGlrR09zVVZK?= =?utf-8?B?NFo4V1hITmd4aStGSllKMjRuMWp2QVFTS2NFWDVnV0hVbDJsSUM0b2REekFp?= =?utf-8?B?R1FHZW5mYUZEakk1MEFuOXpqTmhXZ1dxQjF2SytTb3U2OU1Qcmk3V2xESnF4?= =?utf-8?B?M3NSQXc4d3Vra2lQK3doc2tXcmR0Y05lRGJGNUlkaUR2bXc5RTZtMVUyU1JC?= =?utf-8?B?QThES1BtNHdETFBIQTU0cHZ2OUVaR2JyMFpITFJhVkZid2FOakRzUkNKU2FM?= =?utf-8?B?S0JXek5DRy81WHJNSVArTzR3TzFxUUcrSlhSR095Ujd2TlFjSEIrSnREVVJX?= =?utf-8?B?RlRYazZrNnZQOUptalpYM3JGZUJMc0kxcjZIR1NlOUE0NUZicFJlMkdwRytM?= =?utf-8?B?QlNJdG1lM1JzVy9KdThjNG52MDd5UFE1anNVOXBmZUp5MXFEd0JRaXFoZjF6?= =?utf-8?B?K0hwdW0yTW00Z00wZmMzekpaRHRhUjNmazJsa1dEZTg2cDI2NHJEK1k1aDZU?= =?utf-8?B?QTJBVjJIWWhXc1ZhbWg2Y0tIbFpqNkNZdWRTVk1aMEhHK0lsdDJEUllIK2l3?= =?utf-8?B?WmZnaDR0RmQvVlR1ZHlUQ0VlUHl3V2xiWTFqSVh4c05GcXZJMTdrR0tVaWFE?= =?utf-8?B?TjlpdU1INXdIUXVuZkw2SlpIbC81WkZ4SFVrRk1MU0c1Slg5ZGw0OTJvSmU5?= =?utf-8?B?WWpTNFJwVisxeHJicHpTT0NHYUdsdHVNSnN4NEZxR3VaSzVnYXJHWVlOU0dO?= =?utf-8?B?V3grOUtSQkFtRjFra2M5dWNmb1IwV0VtV2E4Y2tLZEMxamJva3EzYnQvRS9p?= =?utf-8?B?bEdWUityamViejBXWmY2dVV4SUhzc0R6aXMzdkxyMDdGMk1hYkRnRjVlc1Vs?= =?utf-8?B?QXp2bDNNWjc1U3o2OXVWNFBuUklxa1M3dWlRTXgzbEc1bzZvWndkU0dzbkVt?= =?utf-8?B?N3k0a0hzZUVjdVVYRGxTbUkrTm53T2huTjd0MkhjdlkxU0NuMFdlbEFlTWkw?= =?utf-8?B?cWgyWGszdVg3aTNLbEZtUzhhTzYxVFBZVXcyN0l4S1ZLU04yN1BCblVJVWUw?= =?utf-8?B?MEsvR0wzbVI1dGliM1JrQkxUTVFHVy9NVmZhUGhtUnU3RnRiTC9YVXhQS0l0?= =?utf-8?Q?pqUQds2WEWcXj4XHGMuLoE32T?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe4a4310-711a-4e71-5ebc-08db10348f23 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 15:43:33.1047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MRoJSJMx7IVspd5qfN61FmfSfQ0Sx9S+cvD73ry10PF2KbsQ9yCn+EE+/OKKCI53 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7412 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/2/2023 1:47 PM, Gregory Etelson wrote: > Current API allows either query or update indirect flow action. > If indirect action must be conditionally updated according to it's > present state application must first issue action query then > analyze returned data and if needed issue update request. > When the update will be processed, action state can change and > the update can invalidate the action. > > Add `rte_flow_action_handle_query_update` function call, > and it's async version `rte_flow_async_action_handle_query_update` > to atomically query and update flow action. > > Application can control query and update order, if that is supported > by port hardware, by setting `qu_mode` parameter to > RTE_FLOW_QU_QUERY_FIRST or RTE_FLOW_QU_UPDATE_FIRST. > > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam Series applied to dpdk-next-net/main, thanks. <...> > --- a/doc/guides/rel_notes/release_23_03.rst > +++ b/doc/guides/rel_notes/release_23_03.rst > @@ -78,6 +78,14 @@ New Features > ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter > required for eth_rx, eth_tx, crypto and timer eventdev adapters. > > +* **Added functions to atomically query and update indirect flow action.** > + > + Added synchronous and asynchronous functions to atomically query and update > + indirect flow action: > + > + - ``rte_flow_action_handle_query_update`` > + - ``rte_flow_async_action_handle_query_update`` > + > I updated the location of release notes update while merging, but can you please pay attention to the order documented in the section comment next time? Same for both patches.