From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80CE8A04BC; Tue, 29 Sep 2020 18:08:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54C6E1D54A; Tue, 29 Sep 2020 18:08:29 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 60BF11D53D for ; Tue, 29 Sep 2020 18:08:27 +0200 (CEST) IronPort-SDR: 5NB/g/8qFse3PIA8M6c+qCRqXYi/5hKi7p+wCpeRfcMu7bSy1YOP5y/xedAtIi7LTqKz+ubJug w4Ao9N6w2Bqw== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="223821445" X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="223821445" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 09:08:25 -0700 IronPort-SDR: 4k4ovO6nMSF3jgTlr9pqFM7gjW/oD63XDQdbUvpYQudfAL6Cs7nQKmKYK5gZ7MlSj0WmpH0Igj SNbfQ9hJi+Jw== X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="491898401" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.220.198]) ([10.213.220.198]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 09:08:23 -0700 To: Andrew Rybchenko , David Marchand , dev@dpdk.org Cc: Thomas Monjalon , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Ivan Dyukov References: <20200929121222.12954-1-david.marchand@redhat.com> <802bfe55-2738-41b7-3af8-65d7d4636963@solarflare.com> From: Ferruh Yigit Message-ID: <620270aa-0897-616f-8366-5028a3b145b0@intel.com> Date: Tue, 29 Sep 2020 17:08:20 +0100 MIME-Version: 1.0 In-Reply-To: <802bfe55-2738-41b7-3af8-65d7d4636963@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix link speed helper documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2020 1:17 PM, Andrew Rybchenko wrote: > On 9/29/20 3:12 PM, David Marchand wrote: >> When generating the documentation, a new warning can be seen: >> >> .../dpdk/lib/librte_ethdev/rte_ethdev.h:2441: >> warning: argument 'link_speed' of command @param is not found in the >> argument list of rte_eth_link_speed_to_str(uint32_t speed_link) >> .../dpdk/lib/librte_ethdev/rte_ethdev.h:2455: warning: The following >> parameters of rte_eth_link_speed_to_str(uint32_t speed_link) are not >> documented: parameter 'speed_link' >> >> Align the function prototype to its doxygen description. >> >> Fixes: fbf931c9c392 ("ethdev: format link status text") >> >> Signed-off-by: David Marchand > > Acked-by: Andrew Rybchenko > Thanks for catching this. Applied to dpdk-next-net/main, thanks.