* [PATCH] Revert "bus/vdev: fix devargs in secondary process"
@ 2024-05-31 17:41 Stephen Hemminger
2024-06-17 14:48 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-05-31 17:41 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Anatoly Burakov
This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
That commit broke use of dumpcap with vdev's and probably
other uses of secondary processes with vdev as well.
Bugzilla ID: 1450
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/bus/vdev/vdev.c | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 14cf856237..05582f1727 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)
return devargs;
}
-static struct rte_devargs *
-vdev_devargs_lookup(const char *name)
-{
- struct rte_devargs *devargs;
- char dev_name[32];
-
- RTE_EAL_DEVARGS_FOREACH("vdev", devargs) {
- devargs->bus->parse(devargs->name, &dev_name);
- if (strcmp(dev_name, name) == 0) {
- VDEV_LOG(INFO, "devargs matched %s", dev_name);
- return devargs;
- }
- }
- return NULL;
-}
-
static int
insert_vdev(const char *name, const char *args,
struct rte_vdev_device **p_dev,
@@ -291,11 +275,7 @@ insert_vdev(const char *name, const char *args,
if (name == NULL)
return -EINVAL;
- if (rte_eal_process_type() == RTE_PROC_PRIMARY)
- devargs = alloc_devargs(name, args);
- else
- devargs = vdev_devargs_lookup(name);
-
+ devargs = alloc_devargs(name, args);
if (!devargs)
return -ENOMEM;
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
2024-05-31 17:41 [PATCH] Revert "bus/vdev: fix devargs in secondary process" Stephen Hemminger
@ 2024-06-17 14:48 ` Stephen Hemminger
2024-06-18 13:05 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-06-17 14:48 UTC (permalink / raw)
To: dev; +Cc: Anatoly Burakov
On Fri, 31 May 2024 10:41:18 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
>
> That commit broke use of dumpcap with vdev's and probably
> other uses of secondary processes with vdev as well.
>
> Bugzilla ID: 1450
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Please review this. Current code is broken when using vdev's
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
2024-06-17 14:48 ` Stephen Hemminger
@ 2024-06-18 13:05 ` David Marchand
2024-06-19 1:38 ` Jiang, YuX
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2024-06-18 13:05 UTC (permalink / raw)
To: Anatoly Burakov, Mingjin Ye
Cc: dev, Stephen Hemminger, Bruce Richardson, Mcnamara, John
On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 31 May 2024 10:41:18 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> >
> > That commit broke use of dumpcap with vdev's and probably
> > other uses of secondary processes with vdev as well.
> >
> > Bugzilla ID: 1450
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Please review.
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
2024-06-18 13:05 ` David Marchand
@ 2024-06-19 1:38 ` Jiang, YuX
2024-06-19 15:04 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Jiang, YuX @ 2024-06-19 1:38 UTC (permalink / raw)
To: Marchand, David, Burakov, Anatoly, Ye, MingjinX
Cc: dev, Stephen Hemminger, Richardson, Bruce, Mcnamara, John
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, June 18, 2024 9:06 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>
> Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>;
> Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
>
> On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Fri, 31 May 2024 10:41:18 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> > >
> > > That commit broke use of dumpcap with vdev's and probably other uses
> > > of secondary processes with vdev as well.
> > >
> > > Bugzilla ID: 1450
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Please review.
> Thanks.
>
>
> --
> David Marchand
Hi Stephen,
Can below patch series fix Bugzilla ID:1450? Can you have a try?
https://patchwork.dpdk.org/project/dpdk/list/?series=31507
Best regards,
Yu Jiang
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
2024-06-19 1:38 ` Jiang, YuX
@ 2024-06-19 15:04 ` Stephen Hemminger
2024-06-19 20:07 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-06-19 15:04 UTC (permalink / raw)
To: Jiang, YuX
Cc: Marchand, David, Burakov, Anatoly, Ye, MingjinX, dev, Richardson,
Bruce, Mcnamara, John
On Wed, 19 Jun 2024 01:38:15 +0000
"Jiang, YuX" <yux.jiang@intel.com> wrote:
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Tuesday, June 18, 2024 9:06 PM
> > To: Burakov, Anatoly <anatoly.burakov@intel.com>; Ye, MingjinX
> > <mingjinx.ye@intel.com>
> > Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>;
> > Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> > <john.mcnamara@intel.com>
> > Subject: Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
> >
> > On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > >
> > > On Fri, 31 May 2024 10:41:18 -0700
> > > Stephen Hemminger <stephen@networkplumber.org> wrote:
> > >
> > > > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> > > >
> > > > That commit broke use of dumpcap with vdev's and probably other uses
> > > > of secondary processes with vdev as well.
> > > >
> > > > Bugzilla ID: 1450
> > > >
> > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Please review.
> > Thanks.
> >
> >
> > --
> > David Marchand
>
> Hi Stephen,
> Can below patch series fix Bugzilla ID:1450? Can you have a try?
> https://patchwork.dpdk.org/project/dpdk/list/?series=31507
>
> Best regards,
> Yu Jiang
Yes, that fixes what I was seeing where dumpcap or pdump (secondary process)
would not start when using vdev.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
2024-06-19 15:04 ` Stephen Hemminger
@ 2024-06-19 20:07 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2024-06-19 20:07 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Jiang, YuX, dev, Marchand, David, Burakov, Anatoly, Ye, MingjinX,
dev, Richardson, Bruce, Mcnamara, John
19/06/2024 17:04, Stephen Hemminger:
> On Wed, 19 Jun 2024 01:38:15 +0000
> "Jiang, YuX" <yux.jiang@intel.com> wrote:
> > From: David Marchand <david.marchand@redhat.com>
> > > On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
> > > <stephen@networkplumber.org> wrote:
> > > >
> > > > On Fri, 31 May 2024 10:41:18 -0700
> > > > Stephen Hemminger <stephen@networkplumber.org> wrote:
> > > >
> > > > > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> > > > >
> > > > > That commit broke use of dumpcap with vdev's and probably other uses
> > > > > of secondary processes with vdev as well.
> > > > >
> > > > > Bugzilla ID: 1450
> > > > >
> > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > >
> > > Please review.
> > > Thanks.
> > >
> > >
> > > --
> > > David Marchand
> >
> > Hi Stephen,
> > Can below patch series fix Bugzilla ID:1450? Can you have a try?
> > https://patchwork.dpdk.org/project/dpdk/list/?series=31507
> >
> > Best regards,
> > Yu Jiang
>
> Yes, that fixes what I was seeing where dumpcap or pdump (secondary process)
> would not start when using vdev.
Then I will prefer the revert from the original author of the regression,
with more details.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-19 20:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-31 17:41 [PATCH] Revert "bus/vdev: fix devargs in secondary process" Stephen Hemminger
2024-06-17 14:48 ` Stephen Hemminger
2024-06-18 13:05 ` David Marchand
2024-06-19 1:38 ` Jiang, YuX
2024-06-19 15:04 ` Stephen Hemminger
2024-06-19 20:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).