From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 17C92160
 for <dev@dpdk.org>; Fri, 29 Dec 2017 12:45:26 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 59F4720E46;
 Fri, 29 Dec 2017 06:45:26 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Fri, 29 Dec 2017 06:45:26 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=3QHAKbxpO73tRfuKBOvthVkSor
 ntAaNnvBjzkInr0h4=; b=f3Dd3KqJWkgN31eRwa/n2Zfm+GPWDWdEbeXZIFL9A6
 VWS0T3lJ4AnqIvkAcP6iyS4XVqK55JkEqDwde+XAFXANYHj7qJcQczz0n8oDc65V
 dRSYX4IULoLZgWWuNUi03jwpciCY1r696yjaWANRAfReCStfyZvBIUBsLc5u90qC
 c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3QHAKb
 xpO73tRfuKBOvthVkSorntAaNnvBjzkInr0h4=; b=iT1ZRKXIcwe6y3/bjwSoAY
 7cuKY67cXivzxXfT2HND5hYHNhCd3ZBYcJknXtf58Wv4pI18zEXo2XmiErAE3Fq3
 Bbuj6x+uCw2cawA9uVuBIgAAuZ/oceqZn3ahAMK2n/UgG128fkvDWNdV0ATEau6O
 2Ka+O/R4FurWODu73D1yyBnxhiFaL5PZ2a8rqkRW0yxreQCHmQKkQ7EMii7oFmO6
 m3GtT/d3xfV+NG2qPz0Xe//KZCYwv7r1Tt8XU3/BxcTbd0RZ5QQ6paF2rQ2016dG
 kjnmPLW3El/oNPZ0uo9RQ7zsSQj3iCmaIQ/wDknP4daKpyuGS7aMu0BS2HcRA7Mw
 ==
X-ME-Sender: <xms:1ipGWswKbI1cTSZcoHIEOFBeddWV1SoybZeZfiCGEVEyKnowG43pTw>
Received: from xps.localnet (51.42.136.77.rev.sfr.net [77.136.42.51])
 by mail.messagingengine.com (Postfix) with ESMTPA id E2687244FB;
 Fri, 29 Dec 2017 06:45:25 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Date: Fri, 29 Dec 2017 12:45:12 +0100
Message-ID: <6214136.ixGVTiWP3P@xps>
In-Reply-To: <1512402221-17630-1-git-send-email-matan@mellanox.com>
References: <1512028170-18637-1-git-send-email-matan@mellanox.com>
 <1512402221-17630-1-git-send-email-matan@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: allow all ports event registration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 11:45:27 -0000

Hi Matan,

Please find some review details below.

As this patch is needed for the notification of new ports,
I will re-send them in a patchset, with the minor modifications
described below.

04/12/2017 16:43, Matan Azrad:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> +RTE_INIT(eth_dev_init_cb_lists);
[...]
> +static void
> +eth_dev_init_cb_lists(void)

RTE_INIT macro can be used in function definition
without prior declaration.

This function should be moved just before the callback
register/unregister functions.

> @@ -2827,37 +2837,59 @@
> +	uint32_t next_port;
> +	uint32_t last_port;

A port id should be uint16_t.

> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
>  /**
> - * Register a callback function for specific port id.
> + * Register a callback function for port id event.
[...]
> - * Unregister a callback function for specific port id.
> + * Unregister a callback function for port id event.

"port event" would be more appropriate than "port id event".