From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8BC202B99 for ; Tue, 2 Apr 2019 16:48:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1B8D521EDD; Tue, 2 Apr 2019 10:48:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 10:48:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=i5vQL5xLy+63Mi8ktYN9Z5fnQUvD7N2AIoDGWC5QGrY=; b=maX7EUOS/hAx ah/USnjl/qK7+Sp1TNO0XgCREJAteG/mGlN1J7Rhc+wTKeCq1RUhNGqx3Q08Uto9 Ks2vjLcc5Ghzb+yTPjLHwo5uirvimXkEetJXKwHPs37r8MhDS8AuDDaP2s07YQSI Vt7FIFE29amqkDzMWW83E3C7VEs6XqE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=i5vQL5xLy+63Mi8ktYN9Z5fnQUvD7N2AIoDGWC5QG rY=; b=xm6qBv6oF1ey5pVLDOor083MnYeJeSl7BE1GQw2Ddl4XKM7hxz11PEwNk IAAqbsBl2LyWJ2P+eR7nDrTtvg9pcxrqFLynxr0dpanD/qNb4VWJDuYrYrtlwbNu AM+APAbUUHlxpeT33SIyrtAqA+PGWcfDXTzae8+92kinOqGeytU1M0sniGCJ5sDQ I4rrsFWPwHcVAQX5sZcV2Vnie+Ev9WkKJ8rwo2sRfF7yzp6qdqZGiqp3Czof0UCE 7yxIY0wsz2hYp3u/JXGPLQplmid1lHw5y2TsFCfDh7dpBABSnydvvhsE4YqQTSwS 2RF9EnulOx8NApm8iuNCXzjUpvyfA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdeiudculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 556631031A; Tue, 2 Apr 2019 10:48:37 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Olivier Matz , Tomasz Kulasek , Konstantin Ananyev Date: Tue, 02 Apr 2019 16:48:36 +0200 Message-ID: <6219052.IxoQv6UQpG@xps> In-Reply-To: <20190329141852.h2kr3axi4cqdix6n@platinum> References: <1548751746-16030-1-git-send-email-arybchenko@solarflare.com> <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> <20190329141852.h2kr3axi4cqdix6n@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 14:48:39 -0000 29/03/2019 15:18, Olivier Matz: > On Fri, Mar 29, 2019 at 01:42:14PM +0000, Andrew Rybchenko wrote: > > rte_validate_tx_offload() is used in Tx prepare callbacks > > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > > Requirement that packet headers should not be fragmented is not > > documented and unclear where it comes from except > > rte_net_intel_cksum_prepare() functions which relies on it. > > > > It could be NIC vendor specific driver or hardware limitation, but, > > if so, it should be documented and checked in corresponding Tx > > prepare callbacks. > > > > Signed-off-by: Andrew Rybchenko > > Acked-by: Olivier Matz > > Thanks! Applied with a more explicit title: mbuf: remove Intel offload checks from generic API From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7B16EA0679 for ; Tue, 2 Apr 2019 16:48:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 760CA316B; Tue, 2 Apr 2019 16:48:41 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8BC202B99 for ; Tue, 2 Apr 2019 16:48:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1B8D521EDD; Tue, 2 Apr 2019 10:48:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 10:48:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=i5vQL5xLy+63Mi8ktYN9Z5fnQUvD7N2AIoDGWC5QGrY=; b=maX7EUOS/hAx ah/USnjl/qK7+Sp1TNO0XgCREJAteG/mGlN1J7Rhc+wTKeCq1RUhNGqx3Q08Uto9 Ks2vjLcc5Ghzb+yTPjLHwo5uirvimXkEetJXKwHPs37r8MhDS8AuDDaP2s07YQSI Vt7FIFE29amqkDzMWW83E3C7VEs6XqE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=i5vQL5xLy+63Mi8ktYN9Z5fnQUvD7N2AIoDGWC5QG rY=; b=xm6qBv6oF1ey5pVLDOor083MnYeJeSl7BE1GQw2Ddl4XKM7hxz11PEwNk IAAqbsBl2LyWJ2P+eR7nDrTtvg9pcxrqFLynxr0dpanD/qNb4VWJDuYrYrtlwbNu AM+APAbUUHlxpeT33SIyrtAqA+PGWcfDXTzae8+92kinOqGeytU1M0sniGCJ5sDQ I4rrsFWPwHcVAQX5sZcV2Vnie+Ev9WkKJ8rwo2sRfF7yzp6qdqZGiqp3Czof0UCE 7yxIY0wsz2hYp3u/JXGPLQplmid1lHw5y2TsFCfDh7dpBABSnydvvhsE4YqQTSwS 2RF9EnulOx8NApm8iuNCXzjUpvyfA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdeiudculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 556631031A; Tue, 2 Apr 2019 10:48:37 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Olivier Matz , Tomasz Kulasek , Konstantin Ananyev Date: Tue, 02 Apr 2019 16:48:36 +0200 Message-ID: <6219052.IxoQv6UQpG@xps> In-Reply-To: <20190329141852.h2kr3axi4cqdix6n@platinum> References: <1548751746-16030-1-git-send-email-arybchenko@solarflare.com> <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> <20190329141852.h2kr3axi4cqdix6n@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402144836.u1U9TKEO1Mu68o88o11nzpsuhGnAZgr__U1I0gp45D8@z> 29/03/2019 15:18, Olivier Matz: > On Fri, Mar 29, 2019 at 01:42:14PM +0000, Andrew Rybchenko wrote: > > rte_validate_tx_offload() is used in Tx prepare callbacks > > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > > Requirement that packet headers should not be fragmented is not > > documented and unclear where it comes from except > > rte_net_intel_cksum_prepare() functions which relies on it. > > > > It could be NIC vendor specific driver or hardware limitation, but, > > if so, it should be documented and checked in corresponding Tx > > prepare callbacks. > > > > Signed-off-by: Andrew Rybchenko > > Acked-by: Olivier Matz > > Thanks! Applied with a more explicit title: mbuf: remove Intel offload checks from generic API