From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16B0345D4D; Wed, 20 Nov 2024 07:05:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09A8542E1C; Wed, 20 Nov 2024 07:05:52 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 103F740265 for ; Wed, 20 Nov 2024 07:05:50 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4XtW4v0spQz1T5Q1; Wed, 20 Nov 2024 14:03:27 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id 6CA17180042; Wed, 20 Nov 2024 14:05:26 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 20 Nov 2024 14:05:25 +0800 Message-ID: <622223ef-5d43-4cc2-812d-7b978c0cc0ce@huawei.com> Date: Wed, 20 Nov 2024 14:05:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] doc: documentation update for idxd driver To: Thomas Monjalon , Shaiq Wani CC: , , Gowrishankar Muthukrishnan , Cheng Jiang References: <20240627053404.3049609-1-shaiq.wani@intel.com> <20241008065216.1135728-1-shaiq.wani@intel.com> <5538683.29KlJPOoH8@thomas> Content-Language: en-US From: fengchengwen In-Reply-To: <5538683.29KlJPOoH8@thomas> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/11/20 1:42, Thomas Monjalon wrote: > 08/10/2024 08:52, Shaiq Wani: >> Added a note to avoid usage errors by end user. >> >> Signed-off-by: Shaiq Wani >> >> v2 - addressed review comments. >> --- >> --- a/app/test-dma-perf/config.ini >> +++ b/app/test-dma-perf/config.ini >> @@ -61,6 +61,9 @@ >> ; If you do not specify a result file, one will be generated with the same name as the configuration >> ; file, with the addition of "_result.csv" at the end. >> >> +; Note: When using idxd device (Device 0b25) with vfio-pci driver, add queue_id (lcore_dma=lcore10@0000:00:04.2-q0) >> +; When using idxd device (Device 0b25) with kernel driver, add work_queue (lcore_dma=lcore4@wq0.0) >> + >> [case1] >> type=DMA_MEM_COPY >> mem_size=10 >> diff --git a/doc/guides/tools/dmaperf.rst b/doc/guides/tools/dmaperf.rst >> index f68353b920..a689fa0baa 100644 >> --- a/doc/guides/tools/dmaperf.rst >> +++ b/doc/guides/tools/dmaperf.rst >> @@ -104,6 +104,8 @@ Configuration Parameters >> .. note:: >> >> The mapping of lcore to DMA must be one-to-one and cannot be duplicated. >> + When using idxd device (Device 0b25) with vfio-pci driver, add queue_id (lcore_dma=lcore10@0000:00:04.2-q0) >> + When using idxd device (Device 0b25) with kernel driver, add work_queue (lcore_dma=lcore4@wq0.0) > > I suppose the double space is not needed. > > Waiting for review from dma-perf maintainers. NAK The dmadev name varies according to the manufacturer. This information should located in specific dma driver's document. And actually the 'doc/guides/dmadevs/idxd.rst' already included above information. > >