From: Thomas Monjalon <thomas@monjalon.net>
To: Sachin Saxena <sachin.saxena@nxp.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Sachin Saxena <sachin.saxena@oss.nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH v3] bus/fslmc/dpaa2: replace system("echo ...") with file i/o
Date: Thu, 17 Oct 2024 18:15:39 +0200 [thread overview]
Message-ID: <6222746.GJh79HuArf@thomas> (raw)
In-Reply-To: <20240826161216.10135-1-stephen@networkplumber.org>
26/08/2024 18:11, Stephen Hemminger:
> Using system() is a bad idea in driver code because it introduces
> a number of potential security issues. The codeql analysis tool
> flags this a potential security issue.
>
> Instead just use normal stdio to do the same thing.
>
> Compile test only, do not have this hardware and therefore can
> not test this.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
Applied, thanks.
prev parent reply other threads:[~2024-10-17 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 21:49 [RFC] dpaa2: " Stephen Hemminger
2023-05-02 9:54 ` [v2] " Sachin Saxena (OSS)
2023-05-04 7:36 ` Mattias Rönnblom
2024-08-26 16:11 ` [PATCH v3] bus/fslmc/dpaa2: " Stephen Hemminger
2024-10-17 16:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6222746.GJh79HuArf@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).