From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14C5745B60; Thu, 17 Oct 2024 18:15:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA3FF4025F; Thu, 17 Oct 2024 18:15:43 +0200 (CEST) Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by mails.dpdk.org (Postfix) with ESMTP id 769304021E for ; Thu, 17 Oct 2024 18:15:42 +0200 (CEST) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id E8E031140236; Thu, 17 Oct 2024 12:15:41 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 17 Oct 2024 12:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729181741; x=1729268141; bh=eKtXONjWpYZamsAE1J7TfP7wZ0CIDLgweA64uOBiK3c=; b= klTu1fDr8eHpVVtpnwbntucrZbcIVkaN2OFNeCRre7HBVY5JzNZR4cmOMst8QLEU CXL9rB12YesvsCOSaajlSlz7BXCyVgOaY8ImLTq+RLJlT6LT01qi+X+p5+OuUwU7 DZe0SHThjZ1h5I76tbIT6sAla+N60PLdjzvNuh4Y7GvEoIBLEmWDDsxDjtNWi05z /k69rkiCDT8ecxbthsEFJjN277msV2gHphpnjhUeZFxZmfzHkkUiRG/U1qLxQ/Dw zzsfWKusC96n+Lpo1Uf8sicIgb5wEHwi/yWCl/Cjbs88fMOjYvTavJxwRv0EFlQM hMAM8oc1OiOaVkvGPDzHhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729181741; x= 1729268141; bh=eKtXONjWpYZamsAE1J7TfP7wZ0CIDLgweA64uOBiK3c=; b=A yMNti1xCY5NccPXnZdmRiOxo0YX4KT6PT2Oynp2/h1g4QWTgqbinBKU97onNlV/j BlNOcrQ4OeUgybkVmi4tcYVw+PCoCZIXm51lIICXbNUivZ0WDW83BF3T0VGEChwk kQelV9T+kuhTi3oHKFZbaHFHmZ4vY5g22AJjfQp/9lJSxKzKYEzDGrpeyIra7ZsA HXVKVo9k2OB04nqEvAzbNAI5wV1paQzSyYxrGwHYKpJbcJUhhu5IMvpG6me+mgBz vaBi8oJk3kVJpzDbC9XVlaqr7kGxLvVn6pOYAZbnaMK5DrLsUPipdnJu95gNxXaT qTr2LRQshmkDT1Tg50ohA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehuddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdeg keeuveejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshgrtg hhihhnrdhsrgigvghnrgesnhigphdrtghomhdprhgtphhtthhopehsthgvphhhvghnsehn vghtfihorhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhopeguvghvseguphgukhdroh hrghdprhgtphhtthhopehsrggthhhinhdrshgrgigvnhgrsehoshhsrdhngihprdgtohhm pdhrtghpthhtohephhgvmhgrnhhtrdgrghhrrgifrghlsehngihprdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Oct 2024 12:15:40 -0400 (EDT) From: Thomas Monjalon To: Sachin Saxena , Stephen Hemminger Cc: dev@dpdk.org, Sachin Saxena , Hemant Agrawal Subject: Re: [PATCH v3] bus/fslmc/dpaa2: replace system("echo ...") with file i/o Date: Thu, 17 Oct 2024 18:15:39 +0200 Message-ID: <6222746.GJh79HuArf@thomas> In-Reply-To: <20240826161216.10135-1-stephen@networkplumber.org> References: <20220602214957.150071-1-stephen@networkplumber.org> <20240826161216.10135-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/08/2024 18:11, Stephen Hemminger: > Using system() is a bad idea in driver code because it introduces > a number of potential security issues. The codeql analysis tool > flags this a potential security issue. > > Instead just use normal stdio to do the same thing. > > Compile test only, do not have this hardware and therefore can > not test this. > > Signed-off-by: Stephen Hemminger > Reviewed-by: Sachin Saxena Applied, thanks.