From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 943CB1094
 for <dev@dpdk.org>; Tue, 17 Jan 2017 21:32:18 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id c206so241888664wme.0
 for <dev@dpdk.org>; Tue, 17 Jan 2017 12:32:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=MxqvmwYukVwiJ18vk4dfe6mPyEhe3DRkdvDHwfQkuiM=;
 b=ljrWlAAxArzrYIle6qmSGo1BgZk8i6eXByR8C3hx9IxjCuoWtUOlDiLR8wuFnqIGTU
 9pDz4HtBwprPyjobPBrWYqRALyeEuZvM/2cbYrvjQo37NuuTin2ImPGK0qWWeIIDHZTJ
 nzcNlsY6G5DE0eStHlAgpRCLbiQYkPxzxZqimAZHOinF/x6AGEV9uYWEIL+Bz+ZwxVSa
 PJ+6bSRMVUapgl6DTtRk2pIlFvIIwl1YhSi9I6P4QQaJa1EtMVLWV72a0y5zUlbk0gHy
 HvZuWyWHyIILMiYQIIDRj40VwGk0X3veamIzhxOIwsPJQ+PN+Q1+plXwgduuo1PSmUfQ
 x9dQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=MxqvmwYukVwiJ18vk4dfe6mPyEhe3DRkdvDHwfQkuiM=;
 b=gcarMLMT1mdOKeeUZA7kLY6znUhHX8v76YHirx6g7bxg8/GgvBCnd6WznA1H8eLGP7
 1zbiXFdnIrEo+W9SiOtxEoyhCVZMuhNXzk2slBCrtNOp+3ZWSuIYVBJJI1VjjBjlpkUr
 VcttMixdvK9OuEvTXQss4ynk9d/G1ivzfxqFs/BWLGve0BS6kd2T3QNYKhOKWHxB3Vop
 VaqUXOdW+5Cg1tO+T2aE2/PaYLBrk7FMKY5N+bMhPCOdtlXij8z/treLLG5ZrnFtaaS2
 Ltln/112wCxpCPKt2R30EDGXejyTuZBQw53kIjVgF3REMNJUc5zYuJrLyE9B303ZAyuy
 KZ2Q==
X-Gm-Message-State: AIkVDXJg3TWUjApd/O7d4KHZC25hsh0+SWflPjJmo+csW0iFhvhqI0y/ZX6oHKQlUFpQpsNS
X-Received: by 10.223.152.2 with SMTP id v2mr21966930wrb.109.1484685138254;
 Tue, 17 Jan 2017 12:32:18 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id u81sm39350838wmu.10.2017.01.17.12.32.17
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 17 Jan 2017 12:32:17 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, Byron Marohn <byron.marohn@intel.com>,
 Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Date: Tue, 17 Jan 2017 21:32:16 +0100
Message-ID: <6225531.lXhTr8K9SA@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1484594519-227376-2-git-send-email-pablo.de.lara.guarch@intel.com>
References: <1484559804-133610-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1484594519-227376-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1484594519-227376-2-git-send-email-pablo.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6 1/5] efd: new Elastic Flow Distributor
	library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2017 20:32:18 -0000

2017-01-16 19:21, Pablo de Lara:
> +#if defined(RTE_ARCH_X86)
> +       if (RTE_EFD_VALUE_NUM_BITS > 3 && rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2))

magic number spotted!
A comment would be probably helpful in this case.

> +               table->lookup_fn = EFD_LOOKUP_AVX2;
> +       else
> +#endif
> +               table->lookup_fn = EFD_LOOKUP_SCALAR;
>