From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 4A2D6959
 for <dev@dpdk.org>; Mon, 16 Mar 2015 17:05:54 +0100 (CET)
Received: by wggv3 with SMTP id v3so43895823wgg.1
 for <dev@dpdk.org>; Mon, 16 Mar 2015 09:05:54 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=INBxP59SgASRtzFJJDmPJYXxu42YocteQd+WfskW8wM=;
 b=fhq7guVxLYdKkWBZLJaDfSfIO1HJQIcOgA+NkKh3E1ISK2Jdv5k6ufXoT27IvFeAzj
 8HUrJ2ZP6O3fvldwlWPIooDpytFvBNFQnLhAPw19LB6vuk+iqOjYxQ3fNi5i1HEUaF0M
 33BlSgvK/YMa3Z/a8A8Kb2LnRJUKNi6T9lR9WMqXjF+GCELDyPsLA7p8m6xD/bAU7mqT
 aUfHGJnGKoFde4aLDsFw0cl7umhnjvC9eXUSUhnZ4QOk/ZhklsXzk4dqc4KTYfvBbAIJ
 CLRcyaw/UDYrcjrEubVRMIBT3mAZLoU4wPmDo+lCCmCCkJrUvx4KTOIm7koXbiVyk9Hn
 RSiQ==
X-Gm-Message-State: ALoCoQnuJVSEKKobEBoORP0Onvmn6jPftfQTWiHIwRwQRcdNbEqVpa63XGtN+pvAMEyfNdmxWkKs
X-Received: by 10.180.149.206 with SMTP id uc14mr165806813wib.57.1426521954114; 
 Mon, 16 Mar 2015 09:05:54 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lx10sm16004327wjb.17.2015.03.16.09.05.52
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 16 Mar 2015 09:05:53 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Date: Mon, 16 Mar 2015 17:05:19 +0100
Message-ID: <6230385.qXqGPvIMiq@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <2601191342CEEE43887BDE71AB977258213F5E13@irsmsx105.ger.corp.intel.com>
References: <1426230179-1891-1-git-send-email-michael.qiu@intel.com>
 <2601191342CEEE43887BDE71AB977258213F5E13@irsmsx105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Mar 2015 16:05:54 -0000

2015-03-13 09:44, Ananyev, Konstantin:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> > 
> > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h"
> > 
> > For icc and old gcc, this header is not included.
> > 
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > ---
> >  lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> > index ac72069..bd10d36 100644
> > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> > @@ -43,7 +43,27 @@
> >  #include <stdio.h>
> >  #include <stdint.h>
> >  #include <string.h>
> > +#if (defined(__ICC) || (__GNUC__ == 4 &&  __GNUC_MINOR__ < 4))
> > +
> > +#ifdef __SSE__
> > +#include <xmmintrin.h>
> > +#endif
> > +
> > +#ifdef __SSE2__
> > +#include <emmintrin.h>
> > +#endif
> > +
> > +#if defined(__SSE4_2__) || defined(__SSE4_1__)
> > +#include <smmintrin.h>
> > +#endif
> > +
> > +#if defined(__AVX__)
> > +#include <immintrin.h>
> > +#endif
> > +
> > +#else
> >  #include <x86intrin.h>
> > +#endif
> > 
> >  #ifdef __cplusplus
> >  extern "C" {
> > --
> > 1.9.3
> 
> Wonder why to spread this thing over?
> Why not just #include <rte_common_vec.h>?

I agree to use rte_common_vec.h.
I pushed this approach to check every tested compilers:
	http://dpdk.org/browse/dpdk/commit/?id=9a01c31b94e54384

I think that rte_common_vec.h should be moved into
lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific.