From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBB0AA04FD; Fri, 8 Apr 2022 18:24:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D9774067E; Fri, 8 Apr 2022 18:24:55 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id A8CFB4003F for ; Fri, 8 Apr 2022 18:24:53 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 79AF3E37 for ; Fri, 8 Apr 2022 18:24:53 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 55E9DC42; Fri, 8 Apr 2022 18:24:53 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED, AWL, NICE_REPLY_A, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.6 X-Spam-Score: -3.3 Received: from [192.168.1.59] (unknown [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 64E9B1190; Fri, 8 Apr 2022 18:24:49 +0200 (CEST) Message-ID: <6232b540-52f0-937a-af73-f11e8f2aa492@ericsson.com> Date: Fri, 8 Apr 2022 18:24:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4] eal: add seqlock Content-Language: en-US To: Stephen Hemminger Cc: dev@dpdk.org, Thomas Monjalon , David Marchand , onar.olsen@ericsson.com, Honnappa.Nagarahalli@arm.com, nd@arm.com, konstantin.ananyev@intel.com, mb@smartsharesystems.com, hofors@lysator.liu.se, Ola Liljedahl References: <20220408142442.157192-1-mattias.ronnblom@ericsson.com> <20220408081748.119b3455@hermes.local> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= In-Reply-To: <20220408081748.119b3455@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2022-04-08 17:17, Stephen Hemminger wrote: > On Fri, 8 Apr 2022 16:24:42 +0200 > Mattias Rönnblom wrote: > >> +++ b/lib/eal/common/rte_seqlock.c >> @@ -0,0 +1,12 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) 2022 Ericsson AB >> + */ >> + >> +#include >> + >> +void >> +rte_seqlock_init(rte_seqlock_t *seqlock) >> +{ >> + seqlock->sn = 0; >> + rte_spinlock_init(&seqlock->lock); >> +} > > Why not put init in rte_seqlock.h (like other locks) > and not need a .c at all? > Non-performance critical functions shouldn't be in header files.