From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B0ADFA0597;
	Thu,  9 Apr 2020 15:36:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DA7801C240;
	Thu,  9 Apr 2020 15:36:17 +0200 (CEST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9DEAF1C23D
 for <dev@dpdk.org>; Thu,  9 Apr 2020 15:36:15 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 12B3F5C2EF7;
 Thu,  9 Apr 2020 09:36:15 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Thu, 09 Apr 2020 09:36:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=4ksQmsG2/etQTNf3MWZTx+lPdyDruiTp/IF6rvlLMDM=; b=qG8Re3sDLF8T
 Pw6ElBaU8L8numvI9l1S1/9O+6IzcwzZbw+fNMiytQ20CqiaAS58wS2ZZrnliN6B
 62LFFRubrplxRb41JxusqoOQBBloSgBxASw6O75cST8goE7Emz9saTaREGJvRN6f
 BYPo4D1KbHLfEhIXVV5y+Eigf0q+wL4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=4ksQmsG2/etQTNf3MWZTx+lPdyDruiTp/IF6rvlLM
 DM=; b=orDCj2bhwq+Au5owtRU8R3kSDInQLiXCmdOiQn1IO4PbCHqj0pf8MnOyr
 MWbQ1tQu8HxuCpe0vkxF9I8pSHfyQrMsNKqqCUCRPtrSk+7Q7tdLSmkpMV2Dcr8G
 UE0kN6wz4PbqMFEooNx2TVG49C/dQpNNoeseuNsze/mi4o0wY3IG+phlIqYIknGq
 Fi3BOXZb038NzClE0IFJFzzG9YxBMWWPhb9BG1zbv/WJmytSmN+jOhISoIaCQ05k
 8S19WnX7FLYyJWkIn4mYTIdCJUQSqJqvzCG1XsL9/uU94uNAsOrsBzHkZcghf/oT
 s2vOk5QJzfus4FZkEXJkAYR67Gk/w==
X-ME-Sender: <xms:ziSPXoWFuqLIyCLYiYNBOFUETs15g8g6E74CTZwFl_TMrL7Rf5TkzQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelgdeiudcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
 epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
 rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:ziSPXh6NbxQ_5eUWl17KDhgdeyBWhcgfTEf5BrCUT5W3z6JZVB_v7w>
 <xmx:ziSPXocBvmQBZ6PG1xc1VFUksr9lhkYDkQ28qktUp4NLvIKe74nx9A>
 <xmx:ziSPXj7TRvJX3v6JMLmofG4ncujxz3akrqUJR3NNDl_j3xwcSnw0Gg>
 <xmx:zySPXiPmD5bq7_CQct9CGdFSWrzB0s_LIamyhZ10E7Di0VEPaZks7Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id B888E306005B;
 Thu,  9 Apr 2020 09:36:13 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dpdk-dev <dev@dpdk.org>,
 David Marchand <david.marchand@redhat.com>,
 Olivier Matz <olivier.matz@6wind.com>
Date: Thu, 09 Apr 2020 15:36:12 +0200
Message-ID: <6233579.4vTCxPXJkl@thomas>
In-Reply-To: <CALBAE1OB7jACoeghbXf=Maa=gs5i0FStJcoiOVxjha+bpsBkmQ@mail.gmail.com>
References: <0e082fc8-c60c-f62b-ef22-4b453e193567@intel.com>
 <CALBAE1OB7jACoeghbXf=Maa=gs5i0FStJcoiOVxjha+bpsBkmQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] DPDK Release Status Meeting 9/04/2020
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/04/2020 15:10, Jerin Jacob:
> >     * tracing library
> >       * Some concerns on the API, it is copy/paste of log API
> 
> The following API  signatures are taken from log API.
> 
> 1) void rte_trace_global_level_set(uint32_t level);
> 2) uint32_t rte_trace_global_level_get(void);
> 3) uint32_t rte_trace_level_get(rte_trace_t trace);
> 4) int rte_trace_level_set(rte_trace_t trace, uint32_t level);
> 5) int rte_trace_pattern(const char *pattern, bool enable);
> 6) int rte_trace_regexp(const char *regex, bool enable);
> 
> I have intentionally kept public API similar to rte_log wherever it is
> possible. Reason being,
> 
> 1) In the future, it is easy to replace rte_log with trace _if needed_.
> 2) Avoid the new API learning curve.
> 3) I did not find anything wrong with the existing log API to improve
> on at least on API that selected to copy the prototype.
> 
> If there are specific comments on why we need to take the deviation
> from log API on the above schematics. I am happy to change it.

Please remove global level.
We'll try to remove it from rte_log as well.
Let's continue discussion in the patch thread.