DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] scripts: add script for generating customised build config
Date: Tue, 07 Jun 2016 09:36:37 +0200	[thread overview]
Message-ID: <6235932.qgKH91Itup@xps13> (raw)
In-Reply-To: <1461944891-7280-1-git-send-email-bruce.richardson@intel.com>

Hi Bruce

2016-04-29 16:48, Bruce Richardson:
> This patch adds in the configure.py script file. It can be used to
> generate custom build-time configurations for DPDK either manually on
> the commandline or by calling it from other scripts. It takes as parameters
> the base config template to use, and output directory to which the modified
> configuration will be written. Other optional parameters are then taken
> as y/n values which should be adjusted in the config file, and a special
> -m flag is provided to override the default RTE_MACHINE setting in the
> config template too.

You were planning to use this script but not make it the official way of
building DPDK. I think it should be the official way.
I would suggest to integrate it quietly and improve it to make it more
official later.
What do you think is missing in the current design to take it as a base
for later work?
I really would like to see the dependencies (internal and external)
managed in this script.

[...]
> +-m, --machine-type=TYPE
> +    Override the machine-type value given in the default configuration by
> +    setting it to TYPE. Using regular options, regular y/n values can be
> +    changed, but not string options, so this explicit override for machine
> +    type exists to allow changing it.

I think we should make possible to change string values as boolean ones in
a generic way.

Detail: the MAINTAINERS file must be updated for this new file.

  reply	other threads:[~2016-06-07  7:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 10:27 [dpdk-dev] [PATCH] " Bruce Richardson
2016-04-19 12:30 ` Thomas Monjalon
2016-04-19 16:25   ` Bruce Richardson
2016-04-29 15:48 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2016-06-07  7:36   ` Thomas Monjalon [this message]
2016-06-07  9:25     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6235932.qgKH91Itup@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).