From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 838846CBA for ; Tue, 7 Jun 2016 09:36:39 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id m124so101309095wme.1 for ; Tue, 07 Jun 2016 00:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=lCT0Qpicmzm+SYgydQz8qBdIYSorx00LAHGy7tj42aM=; b=offdfqGviZR2ZGnDCCvG7Nu9bB4livJjLgYtYatMS3bsmblpH7Meb5zcaE2Kg5TiEg qiLhCfOCYV8qGrXqehloTr1wpGxqncTm8zX11+I5bPC1rvhHLQMmOtbn+QMWWpU8C/Ow eakbzUr6gVGvtQcvCJU6BYP+xXj/UzPoyx4Qj7wH4pHyeTu8jFZo6v/yDKn+qEfl1t3h UXh1QSGdt3TXkWE3AnlMScgds8VFTBTrVxF2fS1UkYHW4gEdpjbwgR2hzWCpkf2GXsII BYencWuURknZW/7ZFpBwAdixlGOLn4yB+nhHYRc7YH05kcsOrRfQ/VBSQSkYiMS87K3/ jC2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=lCT0Qpicmzm+SYgydQz8qBdIYSorx00LAHGy7tj42aM=; b=e8nGTfolybGD6B29w4pshKEjuaOWBACVMtZJSY6uS+BlBom7P4t8OJ5SBTRMdZpd7O IVOTEcp5ee8z43QlbX9OV05Rah7N0E71abim2get+O5O31DB2wvCh67ANIH1Uz3sJg2v t9Z+8Eofrap7trU6Fmj7J6znJsnCCWHeQaigOpUsebb1cO0cjsh9wKjQvE8zJgLYpc8C fAcbEWmNBVJGjZ6tvDeG353Tck6rsxuIvxeGXeTOzDWotKcULfAsMKuoimzFDckiFpY7 JntPXZTypnVv5KNTuMwz9Wk92vCwzdI7NzYwuGwSkWcbhGDjybNHAsXlLevPdzMUKYL+ RTng== X-Gm-Message-State: ALyK8tJSgn49InEcSbU4fYJqqZw4Llg4vhEt8A1wHDzWo5+XNaX8UBzb/QHGe7A2s0Gatq1j X-Received: by 10.194.165.226 with SMTP id zb2mr21245507wjb.172.1465284999271; Tue, 07 Jun 2016 00:36:39 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id f12sm17898964wme.13.2016.06.07.00.36.37 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Jun 2016 00:36:38 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 07 Jun 2016 09:36:37 +0200 Message-ID: <6235932.qgKH91Itup@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1461944891-7280-1-git-send-email-bruce.richardson@intel.com> References: <1461061640-7611-1-git-send-email-bruce.richardson@intel.com> <1461944891-7280-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] scripts: add script for generating customised build config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 07:36:39 -0000 Hi Bruce 2016-04-29 16:48, Bruce Richardson: > This patch adds in the configure.py script file. It can be used to > generate custom build-time configurations for DPDK either manually on > the commandline or by calling it from other scripts. It takes as parameters > the base config template to use, and output directory to which the modified > configuration will be written. Other optional parameters are then taken > as y/n values which should be adjusted in the config file, and a special > -m flag is provided to override the default RTE_MACHINE setting in the > config template too. You were planning to use this script but not make it the official way of building DPDK. I think it should be the official way. I would suggest to integrate it quietly and improve it to make it more official later. What do you think is missing in the current design to take it as a base for later work? I really would like to see the dependencies (internal and external) managed in this script. [...] > +-m, --machine-type=TYPE > + Override the machine-type value given in the default configuration by > + setting it to TYPE. Using regular options, regular y/n values can be > + changed, but not string options, so this explicit override for machine > + type exists to allow changing it. I think we should make possible to change string values as boolean ones in a generic way. Detail: the MAINTAINERS file must be updated for this new file.