[dpdk-dev] [PATCH] bsdapp: replace d_thread_t with struct thread in nic_uio

[dpdk-dev] [PATCH] bsdapp: replace d_thread_t with struct thread in nic_uio

[Bruce Richardson]

Reported by: John Baldwin <jhb@FreeBSD.org>
Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196691

Quote:
"The d_thread_t typedef is a compat shim to support FreeBSD 4.x.  I'm planning to remove this shim from 11 and dpdk is very unlikely to ever be ported to 4.x.
 If it does it will need far more changes than just d_thread_t"

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
index ed11d84..5ae8560 100644
--- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
+++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
@@ -175,13 +175,13 @@ nic_uio_mmap_single(struct cdev *cdev, vm_ooffset_t *offset, vm_size_t size,
 
 
 int
-nic_uio_open(struct cdev *dev, int oflags, int devtype, d_thread_t *td)
+nic_uio_open(struct cdev *dev, int oflags, int devtype, struct thread *td)
 {
 	return 0;
 }
 
 int
-nic_uio_close(struct cdev *dev, int fflag, int devtype, d_thread_t *td)
+nic_uio_close(struct cdev *dev, int fflag, int devtype, struct thread *td)
 {
 	return 0;
 }
-- 
2.1.0

Re: [dpdk-dev] [PATCH] bsdapp: replace d_thread_t with struct thread in nic_uio

[Thomas Monjalon]

2015-01-16 12:24, Bruce Richardson:
> Reported by: John Baldwin <jhb@FreeBSD.org>
> Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196691
> 
> Quote:
> "The d_thread_t typedef is a compat shim to support FreeBSD 4.x.  I'm planning to remove this shim from 11 and dpdk is very unlikely to ever be ported to 4.x.
>  If it does it will need far more changes than just d_thread_t"
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied
http://dpdk.org/browse/dpdk/commit/?id=01e66999

Note that the definitive title starts with nic_uio and describe the goal
of the patch. I use this kind of command to remember which keyword must be used:
	git log --oneline lib/librte_eal/bsdapp/nic_uio
I also try to keep a consistent formatting for keywords like Reported-by.

Thanks
-- 
Thomas