From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBD65A0C55; Wed, 13 Oct 2021 12:14:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C26CE410EB; Wed, 13 Oct 2021 12:14:51 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 8F88C40150 for ; Wed, 13 Oct 2021 12:14:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="288266783" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="288266783" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 03:14:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="547779291" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 13 Oct 2021 03:14:48 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 03:14:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 03:14:47 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 03:14:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YGc1pZfIH40EVqEC2hiINvCkyDNSEdzKLsmU2/A+T2taJAPX1xD2BTnDDEBkCeB5NBnhVOo4nsWgQYFcI3HzIXGoK0DTyEcJWliAKfSBATiTY1eaqBUU1g4UB52zMKOVYMDQgRXEbSJTh6kZ/nfu2Q2AxWcmc0Z3R8CtaU6oYoL4KsL7xtdvBPi0j2ce/8zF/+R1k2pB7b1HoYNeSSidbBPyUizT5jwidyT6aq4XZiA2/8xKbBEL9ccLbXBdMb18EmwZaJP863Fa7GE92r72HyDBAfSM7jpFFUpitlcOR1CkZkoCWS0PoRRNlbPryDfMTxzl/mFvsoUEKtDNHahl/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uQLMirfNc6kI870b9MbqZAoXWUDzcOSUfL/hRCUaizM=; b=SsAsxjjBy81xU+m+sUifpUZaMK+17R1piK9d0hzVTnC0aqmlx4sF8fWgsKkzwU585ULjT8oLN0PSCHatXk/BxkQQNSo+ef+w1171gXJdthJ7q4onARtxEONtWwF8AztvqeZCIXIyTb746+rQVKmt1+52+8yJgXLriN9XhEvUt04qAGzgjiq9SkzilSDxv7jdFFCRenoLZfE/CZEu2Wb22g8IjOXUvyUmsz2k9TfhPKdPI08zocD9bxMakHlHiJyv2vzHt36vgEndVg4LSNJYGgTU/14WMUzOPW9re5ptpsp4DLSWZPFGFEBpnZvpjbLPRbDTOSh5hAGyByOScsgOBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uQLMirfNc6kI870b9MbqZAoXWUDzcOSUfL/hRCUaizM=; b=CRGBlGEKTk/U6U007j4hz7r2u8iY2Ju6YCXRnm2/Ztqtqz7mKbgaO/kjMD7TRk613ApgUmNv6vOW9XEuYOmmb539+Pof/Bqx83JHt1k63bQy6hJRm4DaMJNvjAUc2vquXv36EYZTxHsRu18LMWVnP5kQZLgavXyNwhKLM9bLRfc= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by SJ0PR11MB5167.namprd11.prod.outlook.com (2603:10b6:a03:2d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct 2021 10:14:41 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::cd8e:780f:5a1c:298a]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::cd8e:780f:5a1c:298a%8]) with mapi id 15.20.4608.015; Wed, 13 Oct 2021 10:14:41 +0000 Message-ID: <623d300d-6205-e863-90c5-372651e252f5@intel.com> Date: Wed, 13 Oct 2021 11:14:34 +0100 Content-Language: en-US From: Ferruh Yigit To: "Wang, Jie1X" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "Li, Xiaoyun" , "Yang, SteveX" References: <20211011180111.99281-1-jie1x.wang@intel.com> <20211012025417.134866-1-jie1x.wang@intel.com> <20211012025417.134866-3-jie1x.wang@intel.com> <21c7813a-fd86-df06-84e4-d3a79425a16a@intel.com> <3f29634d-5e90-8a47-cfbc-b674e0d6a953@intel.com> X-User: ferruhy In-Reply-To: <3f29634d-5e90-8a47-cfbc-b674e0d6a953@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0201CA0032.eurprd02.prod.outlook.com (2603:10a6:4:3f::42) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0201CA0032.eurprd02.prod.outlook.com (2603:10a6:4:3f::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Wed, 13 Oct 2021 10:14:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c8098dc-ce02-43b5-d41d-08d98e324590 X-MS-TrafficTypeDiagnostic: SJ0PR11MB5167: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +T/003AatYRAWBPXLd2C9MXNXpMHscMskwTuX43BA6hLvhCuVOpUbgHHgZqQDdpdeOJY/OR40GXFBemstafPtWqKa5xsJqbRnk2NapVgkYZz+uYT0D8msKgkT29rr8dk1JHdjzsMsjh8yhuWw/xlg0dn8AvSKz+syDQs+JY2CitTG0X667jNe1/M9qXHhGqNEY4GceU4KZA0jAGjtgxkSZePEs+bdjl0NB7phNjnNr4vNLHIUuLCO7iZ1oHunAA55FlktmSgOnD6lPO/OZAu35pHuqGy1ne2aztKeSINMB2qdm/8HrQV8ECaaByG5Ezv2FIOeF3h/fbUYYL7yMeYqeJdiHtYYqTwfdUoZnh6HMe6QcloY1+eqRzO+jCkVwvNGH8plMtvZEzYnVQRKOp7Um2cMQIJGeSI97iV+Xs0hAsEE1qSQjQuiE/f8wNP1jhCDPrULdoEN8oi1Fz0e8S8BkhOeDt1wqHfv8kGGYDP8+kjXZpIBpBOF4OeQyfjzD/1ev1m1OLQq1XcD+pAhrpVyqR3+HpHw1zALT3JNxbHgc7Eug5hVlU6eTH4D5OwVxyB1ou3lkgJ75KL4n7ZE4AIjvQqe2VwknNsIlxpKHX5eaSANEIFWFiivK60xtxgijQS49L7wZLViWIaYv1vnzE8qC4ZJ00kNH2NaA3Xc22pJLUWcOri+V1iolVQTA86ElWrybq5JIytQ0JFlXa1ikntNSwyWK3SOLCSOs8AEUEi1Iq8DQGx2N6hmx9dqrV0gdZ8U8BQj/kScBoMNGS9AoT+9tyE69VbmdQelbLqev4diTU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(110136005)(44832011)(966005)(86362001)(508600001)(5660300002)(2616005)(316002)(16576012)(31696002)(54906003)(31686004)(66476007)(66556008)(956004)(38100700002)(53546011)(4326008)(66946007)(107886003)(6486002)(8936002)(82960400001)(6666004)(83380400001)(186003)(26005)(36756003)(8676002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bExZNmhSVHZZcHkzYy9FUi8rUUs4NldjbzdJYTduMXoxS0M2TVk1bVNrSVhy?= =?utf-8?B?VUZLdEhKRlo4c1oxZjZYbnNpWmFpVWdVcDExNDY3T2dWdzRRL2l2RnVkZS9v?= =?utf-8?B?Q3drNURMNEVBWENiNDFGOHJRREwzQlgzaCtkcEdvSEhYRGdDMmttK1JFQlRh?= =?utf-8?B?SzRrTGtOOEtkMThRV3cvN1pLMmRMK0g2aTl6R2YzTXlYUjcvNmZMYW56c1FO?= =?utf-8?B?b0NaNm1TbHhzYmFXTk1NL1JZY1c0Y0RvSlo0dzJybmh5NS9MWWFuaVI5QXE4?= =?utf-8?B?Z2tMWE5IZ2k1MnMrNHZFbWkzMUhvSmZSZFpZVElBc0w2YjE5SkppY05URC8x?= =?utf-8?B?NGxNbnNWcFN3c08rN3hvenU2eXVYK1lpNVRiUVF3ZkY5UzFGNmhub3E3Z1RK?= =?utf-8?B?NE9qVDE1UC9ZNFc5M2YwV0NyWXBxbG5PdTZkam5tQlhSM2QyM3Z1Q1AvczVu?= =?utf-8?B?ZzFWTjhPeW1Ya0RkbHUzMzZKN0NKZ0ZjalRzVUpRdllxSThyYUdhbFhjZENP?= =?utf-8?B?NkVGSGs0TW1ySjB3akFubW5aS3RJK3hoWU81VitiUzljWU1hQ1lRd2lsdnZK?= =?utf-8?B?d2dBd0IydGExdW5icFpjYnJrWUpEZjAzMG81ZnVBK01BRmlRMWZtbyt2V2lm?= =?utf-8?B?WkY3Q3NueTJRQWFpdHFFNHRtVmFCNS9oYjZaUFFZSGlaaDVlRmVVd1ArSFMy?= =?utf-8?B?SWJPY3FDS2piYjdLU1ZXQjJYQXBlbmVhZHlVZWs4Z1VybVdFNjJWSTBuMHdX?= =?utf-8?B?QkFLcUFGZWt4MGQ3ZisrMDRvZVZIQ3h5eXFVTGRvNnhxR1hZTVVnUS9uMHR4?= =?utf-8?B?Q1FCQUQ5WjlMZUpkYkN4VlF3ekhWTFR2R2x0dlpzMm5kNXNOTnZEWWVtTWJa?= =?utf-8?B?MjRoYjdxK3o2d0VhdmFURlM2cmJqNDBobWUvNlJ6OEt2cFhNNXBrNFVKVW9D?= =?utf-8?B?cTZwcjdsRWM5RlZCK0xUOWNUelFIb25EaFlBT0JHMEVIOUZQSDlxYnkvZXNK?= =?utf-8?B?YTNhNjVWeCtmQnRpbXRJeHJENEpnSnVSNDBXejM3ZUY5RE5uT3dBb0FVRTVq?= =?utf-8?B?amNjcTBsTDE5dHlOOU4wTWNxeXlVdFJjeFJDdXUzYk1NN2ZvSEdLWFRaMXpu?= =?utf-8?B?QmdHVExxQXV3Q1Buc1lVLzJXZXB5RkgzcXFJbGZFbm91NVBxSkdBTU5hQUJk?= =?utf-8?B?bnJpNThzNzZXYWIveThVdlp0NFRYSjhmRGE0QTkwSVRmclpFU3lhNHFTaHZz?= =?utf-8?B?MmJiQWZUZjJ6MEpPNkMwRGhjZnBQMCtWT29xd0k4RjBVYXBvZ1NoN2NHVzRp?= =?utf-8?B?N2VTOE8zNHEzV2NDOGdtaG9hL0x3NHFPU1g3MnRZYlp6bHp5NkpmZ0NpSkcr?= =?utf-8?B?MTJaaDB6aURQZ05tRTdRZEVxa0pVNXVHK2xYaU9CVWR6SEdzUWpQOStGZTcw?= =?utf-8?B?YjJrTVRrTHlaNkJHbWNEb0Q5Wll6dzluVEs2ZDY4QzNTc3MxR28zQ2g4Zk1U?= =?utf-8?B?amNmZU5raE1lY3BKbUhlTk1pTDNVTTB2enFhMGMyMUJvSVphMEliY1VBMGFG?= =?utf-8?B?eXhmWG5XVUVmazh3WG5VZDNyWWNUamRjZnhzTi95V0FsNFpOYVVDMWtTcUtp?= =?utf-8?B?RUE1R0M1YU0wVlZEckZFbHp3NDFFbkRBQ1l0UU1TSVJvOXNwdDVQcStkSlZ2?= =?utf-8?B?dk9JcVh2M3RMMkZua015b29PL0NwMTNWVUdIS1ZmbUFOQk9oNldLRU9DNCtX?= =?utf-8?Q?C5M84oaAGdLAar4NqoTnVS//XVmy6cFZ1sWafUd?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1c8098dc-ce02-43b5-d41d-08d98e324590 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 10:14:41.8673 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lL2/A2iAlsDXs1vltvFW2ah9n64elVjAqHo6BFCVVTlgp9G2TrfkcFxiDj8u2oYVEVfcvwPwqs3vPBd5jVrUUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5167 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 9:50 AM, Ferruh Yigit wrote: > On 10/13/2021 3:42 AM, Wang, Jie1X wrote: >> >> >>> -----Original Message----- >>> From: Yigit, Ferruh >>> Sent: Tuesday, October 12, 2021 10:38 PM >>> To: Wang, Jie1X ; dev@dpdk.org >>> Cc: thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Li, Xiaoyun >>> ; Yang, SteveX >>> Subject: Re: [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash >>> offload >>> >>> On 10/12/2021 3:54 AM, Jie Wang wrote: >>>> The driver may change offloads info into dev->data->dev_conf in >>>> dev_configure which may cause port->dev_conf and port->rx_conf contain >>>> outdated values. >>>> >>>> This patch updates the offloads info if it changes to fix this issue. >>>> >>>> Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") >>>> >>>> Signed-off-by: Jie Wang >>> >>> Hi Jie, >>> >>> ci/intel-Testing is still reporting some errors [1] with this patch, did you able to >>> investigate the reason of it? >>> >>> This error seems not seen in other patches, so that shouldn't be an infrastructure >>> problem. >>> >>> >>> [1] >>> http://mails.dpdk.org/archives/test-report/2021-October/226766.html >> >> Hi Ferruh, >> >> When the dpdk runs the test_pf_tx_rx_queue test case, the port will be configured with rxq/txq to 1. This will cause the test to fail. >> >> In rte_eth_dev_configure, if rxq/txq is 1, dev_conf->rxmode.mq_mode is ETH_MQ_RX_NONE, and  dev_conf->rxmode.offloads contains the DEV_RX_OFFLOAD_RSS_HASH value by default, which causes the program to report an error " Ethdev port_id=0 config invalid Rx mq_mode without RSS but RSS_HASH offload is requested". >> >> When the port needs to configure txq/txq to 1, first clear the RSS_HASH configuration of dev_conf->rxmode.offloads. >> >> And I have talked about this error with the tester a few days ago, and they will modify the test case. They will add a command (port config port_id rx_offload rss_hash off) before configuring txq/rxq to 1. >> > > I see, but shouldn't this fail for all patches, why it is only failing > for this set? Got it now, in first config some PMDs force enables RSS_HASH, when testpmd disables the RSS later, the existing RSS_HASH request cause failure in ethdev layer. What about disable the RSS_HASH in application level, when RSS is disables, something like following: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index a7841c557f99..5f6daac8a616 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3601,12 +3601,15 @@ init_port_config(void) } if (port->dcb_flag == 0) { - if( port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) + if( port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) { port->dev_conf.rxmode.mq_mode = (enum rte_eth_rx_mq_mode) (rx_mq_mode & ETH_MQ_RX_RSS); - else + } else { port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; + port->dev_conf.rxmode.offloads &= + ~DEV_RX_OFFLOAD_RSS_HASH; + } } rxtx_port_config(port);