From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97D39A0A0A; Tue, 23 Mar 2021 22:14:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18D574014D; Tue, 23 Mar 2021 22:14:20 +0100 (CET) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by mails.dpdk.org (Postfix) with ESMTP id BDD0340143 for ; Tue, 23 Mar 2021 22:14:18 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id D1F23D45; Tue, 23 Mar 2021 17:14:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 23 Mar 2021 17:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= rVPUrmqdLXkVPFr6ettlYLaNjrqGz/Z95NPphOyhmdc=; b=X6HF+REpfzA6kI4D BXh8T8ht3EUFC/rMnIyv5mHjU0I2Z4NUeOZXL/iHyLhkcopae9vr/u5J/VEgTtjU 1tM6Il1qvhBKgwn5gCtfhZ2bgsM0R8CMj9SbhTc3Pjr+LyV1koP6NhVr9Qtrtg72 6YmVe5X8lA9mdsd85HqzArIZD9u3bkHloL0I2MBhAmdX7l6czfElXn6OgtSU/4ql +mmYIIBbw8j2x1QU6rGwI4W4/jklJw9FVb1YYpMRY9ppG04dyp2Q1JyfJqYgmXcb 9TulGQNFUMr1RqwjhhQknW3EAVuf/AtQv0O8u21tFAM7seLu58mkbN5dSPD92k5c OApQug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rVPUrmqdLXkVPFr6ettlYLaNjrqGz/Z95NPphOyhm dc=; b=RnfK1oi2MCWVreaPA1Himh6Z42/hKr4Gc0Cf5n4/FzU3qy5VPY+mYdWyB NLXgXYKGxRTmypHMMP8Zrcuq6udKo9eJ0Qd4Y9RC9KM8k2Iy8zhePn+00mvUNEzj PAdEYFwchRPbz3ddl5nP5qQI1reZ07xVc77zpfI3blp8yv+0G4zsHVT7p0xSC7W1 6olsFfrrVCD5ncK+A2TNYXwaKBe13kqG3+nsbAkFROIcFAuENLE6C8NjhG7zfvOF +U9IbSvGF8STc6tou6YM6jz+IVzf5X/yvqY3n6ArkV8wYQipPcqL7Tm8NCAHaqgP 94cclEl8z0zNYMg/+4M87SAFpTDzA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegiedgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9AD49240356; Tue, 23 Mar 2021 17:14:14 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang Cc: ferruh.yigit@intel.com, dev@dpdk.org, bruce.richardson@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, andrew.rybchenko@oktetlabs.ru Date: Tue, 23 Mar 2021 22:14:12 +0100 Message-ID: <6246020.AddI7DyskZ@thomas> In-Reply-To: <20210323110749.2306452-2-qi.z.zhang@intel.com> References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210323110749.2306452-1-qi.z.zhang@intel.com> <20210323110749.2306452-2-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/8] ether: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/03/2021 12:07, Qi Zhang: > PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap > data path debug code. As .config has been removed since the meson build, > It is not friendly for new DPDK users to notice those debug options. > > The patch introduces below build options for data path debug, so PMD > can choose to reuse them to avoid maintain their own. > > - RTE_ETHDEV_DEBUG_RX > - RTE_ETHDEV_DEBUG_TX > > All the build options are documented at programming guide > "3.1 Driver Option", so users can easily find them. > > The original undocumented RTE_LIBRTE_ETHDEV_DEBUG will alias to > both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward > compatibility. > > Signed-off-by: Qi Zhang [...] > +The ethdev layer supports below compile options for debug purpose: As suggested by Bruce, "build options" is a better term. > + > +- ``RTE_ETHDEV_DEBUG_RX`` (default **disabled**) > + > + Build with debug code on Rx path. > + > +- ``RTE_ETHDEV_DEBUG_TX`` (default **disabled**) > + > + Build with debug code on Tx path. > + > +.. Note:: > + > + The ethdev library use above options to wrap debug code to trace invalid parameters > + on data path APIs, so performance downgrade is expected when enabling those options. > + Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path. Acked-by: Thomas Monjalon