From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 1F5A35A0A
 for <dev@dpdk.org>; Fri, 12 Jun 2015 18:46:27 +0200 (CEST)
Received: by wifx6 with SMTP id x6so22394972wif.0
 for <dev@dpdk.org>; Fri, 12 Jun 2015 09:46:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=cmNJCc7/HVpx16Xov7uOadAOOMn5iXWbpALJpISmbZg=;
 b=TbKcO+BtYTKxb1PWwTSDETomaVAMFamib7+fw3J4iU01Jet2ge/4ygwYZGMbryKjeT
 da2JkxpJjI5ffwkSOyhgrRfqJCFtLlaKFF4SCuFeqAk+oXFgOKpQwgc/qxclJTsW4fDl
 5KkH6eHFclgn+Jr1AnUXgbH7nlcb8yNj6G6lJwwx0i3OF7qoEekU1Lmh74fZtWmQeV5i
 17Qawp8DnAMNUfjiXLmH19t4WAqMDpEO5ZmTobCvg1fw3JkyekfhC5hbE3GjvTWrwQo3
 0wfxtVxXLYzljP+062RFiINCLjQVj8w297LlLRgG45KLZSJHFefMNCBSplv/ZOVojpTW
 VZEw==
X-Gm-Message-State: ALoCoQn6u+uhCZzqGt3qviKYj/UHkdWKs0eF9OnIYR5h7AdEKSx5Y4ZwdnWli2dP6BLGu3YQGm3s
X-Received: by 10.194.120.198 with SMTP id le6mr28233900wjb.133.1434127586987; 
 Fri, 12 Jun 2015 09:46:26 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id u7sm3546096wif.3.2015.06.12.09.46.25
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 12 Jun 2015 09:46:26 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Date: Fri, 12 Jun 2015 18:45:29 +0200
Message-ID: <6248554.R1XBHJxJp6@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1431315990-3067-4-git-send-email-jingjing.wu@intel.com>
References: <1431315990-3067-1-git-send-email-jingjing.wu@intel.com>
 <1431315990-3067-4-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, neil.horman@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH 3/6] ethdev: extend struct to support flow
	director in VFs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2015 16:46:27 -0000

2015-05-11 11:46, Jingjing Wu:
> This patch extends struct rte_eth_fdir_flow_ext to support flow
> director in VFs.
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -394,6 +394,8 @@ struct rte_eth_fdir_flow_ext {
>  	uint16_t vlan_tci;
>  	uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN];
>  	/**< It is filled by the flexible payload to match. */
> +	uint8_t is_vf;   /**< 1 for VF, 0 for port dev */
> +	uint16_t dst_id; /**< VF ID, available when is_vf is 1*/
>  };

Isn't it breaking the ABI?