From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0DE3A0547; Tue, 31 May 2022 15:27:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9348340143; Tue, 31 May 2022 15:27:51 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2066.outbound.protection.outlook.com [40.107.92.66]) by mails.dpdk.org (Postfix) with ESMTP id 9A9A9400EF; Tue, 31 May 2022 15:27:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IT3pggkNfU9k/Vif10M/o+qlHbJTptZe9gihSYx3c8VCfu+DUwbI5K8pXSZgIXKIm2SrnoxWsThjL+Qq6ZC1Eckgy+n0ygaV2u4/zLFp3CgnddbbTkeBQ+S1rkx9Wd6Hn3gP9/LYPNXEtuMZlePXTXKDBbC1oGqLoQydOTPPGz0FjbUKwJ0AShRq1NnZ63wl1R+X1RJKrJxxhFlNuIOUoCdbedXzgrsF1MhoacioUiu+ZSBQSrEMCvQmB26IoVxHcqJLBwzlIXBcy0illqoaqmBSPjKS59ITCy6STietIKDR77UbF3gwcIUjkAAhyJ5ypWV1/r2sVPQu3VRHfBsjVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w3NgX/OCuE2HrQ/+45fg0IahoipJPpQuNeNpBZokR/I=; b=fAGilggeSKojcEguPmD6vX21dfBK+CM1dedL5E71Dx4p/eZuXSyb1nSUtprWZ3aDEkg4Xo1kbn9wNCRoo937ydwPQaa3MRwpM7cFmQVPtKMdTMwNPvn1pqsLhN5PICtjS3yS3I4JRSm6eA/heC4UFzg4c/REZCDSdD3T2LbquR2DwvWIVjhtWRpk6xPE52MnUYKx8LlBK6efOw0a+jHXpg9DptyVQwyxvoAAmblpE4wOLHbGCs4QOLnv3IwYNNvNWcSaVwSPt/V4zVSgL/tzzG4EAyRnT1V1DRdOicvvtKyDC1RPHcTU2rXwUGkmcOI9q89mUIg5S11sbcxDLxQ0zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3NgX/OCuE2HrQ/+45fg0IahoipJPpQuNeNpBZokR/I=; b=Ew7TYJYKhtmQ5jdrIcI2oYhhJk1KrcR2Qk2DsS9fzbI3SnR8idJLLcABt7C8rtsEsrt14AL2SCEZI61dqmiRS7lAUkbqqMxdjHhBoRV20WjGUxPYyYA7Vd4J1RSntDtWkVdjo8Mx7Q9Mxko2dPu/F1cMn8n3g3/+caD9wWpW5DY= Received: from DM5PR06CA0034.namprd06.prod.outlook.com (2603:10b6:3:5d::20) by SA0PR02MB7322.namprd02.prod.outlook.com (2603:10b6:806:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 13:27:49 +0000 Received: from DM3NAM02FT040.eop-nam02.prod.protection.outlook.com (2603:10b6:3:5d:cafe::65) by DM5PR06CA0034.outlook.office365.com (2603:10b6:3:5d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Tue, 31 May 2022 13:27:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT040.mail.protection.outlook.com (10.13.5.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 13:27:48 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 31 May 2022 14:27:46 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 31 May 2022 14:27:46 +0100 Envelope-to: peng.zhang@corigine.com, niklas.soderlund@corigine.com, oss-drivers@corigine.com, stable@dpdk.org, yong.xu@corigine.com, chaoyong.he@corigine.com, dev@dpdk.org Received: from [10.71.119.162] (port=51793) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nw1uU-0005qq-M1; Tue, 31 May 2022 14:27:46 +0100 Message-ID: <626c0852-1e6a-d6df-66c6-84edf4a056a1@xilinx.com> Date: Tue, 31 May 2022 14:27:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] net/nfp: fix bug of disable VLAN strip Content-Language: en-US To: Peng Zhang CC: , , , Yong Xu , Chaoyong He , References: <20220419083857.409261-1-peng.zhang@corigine.com> <20220526143444.990674-1-peng.zhang@corigine.com> From: Ferruh Yigit In-Reply-To: <20220526143444.990674-1-peng.zhang@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c06852b3-a0b6-4c08-0b11-08da43095ae8 X-MS-TrafficTypeDiagnostic: SA0PR02MB7322:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 17/f0T0ljlH1TENNwsAy7KnG8Eoe0ufPENg1lz1yJMxDH+StFr8qaN9VRYJ5ctn3IClprDQvf3j8btpRNKJvbqfsC8T3zPDR+uZdpmVY+4c9p9mTqdRKw3JX0mq+bCsvr1Qwu77kdOYmoP6SDcgqLnj7KZTCDD7nydeVJj9TKcX/IkzaBFSqCaM+7ocN7q6b/xa5Wgq/zUGnCVLxNGcnGBVVgzi+5V5rJLez4NQZzNZ6dH1U3uaM1GRD31j5byvalGjiz7g9gXRm8N3CSeghVRir8pDIukSDDLOG2kAdvYrZA6Gg4sXXNGs6M5xAJgiIrARYJMQptzJx4cWce8nas9IkmiI6/Cwj2mHBUjvRjfGGvPdRzgNR9V7cCnu55wIU3pVKLaSHAgIogrzOPNbzbcbYdp6a4PFvKkn1hBfVwfk0L/ycjHFeFLBGvEugxQdTpu1je7LMRJF6pLhBTCIKkAPNbR/q8LPWxE+5fN3WUrBr5GQtvWKnC/bfEVtnlSw7z4lDLCyDAoDWreIPw7q+8wVZ+8maHT8MTYSWpEqMfWL/tHk54J5Osgd84S9pVeZ/8kR7oRHaKikZH+xVlQg4yeVIGYsC+oQiJHLZD7RvO/XlekdRWXvbtTGf24YGQLE4s61Qc1dK2d5ONlVui6QWpZIDnweVi8z90opLcVohXr7p5wHdZJ9ibDnuox0DQrtBiKdk+znNCG3PZvlT1BvfXaHsrJzsVBGt+5grgZxi2ig= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(53546011)(4744005)(44832011)(5660300002)(508600001)(8936002)(9786002)(31696002)(40460700003)(26005)(2906002)(36860700001)(7636003)(356005)(82310400005)(2616005)(336012)(47076005)(426003)(186003)(83380400001)(31686004)(8676002)(6916009)(54906003)(36756003)(316002)(4326008)(70586007)(70206006)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 13:27:48.2457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c06852b3-a0b6-4c08-0b11-08da43095ae8 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT040.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7322 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/26/2022 3:34 PM, Peng Zhang wrote: > "vlan set strip off 0" can't work, due to the incorrect usage > of the mask, it just represent that the status is changed or not, > not represent offloaded or not, so that the driver send the > error control message to the nic. > > Now, by first inspect the mask of things that changed, and then > change the requested state if VLAN stripping according the > requested offload status. So this change can fix this bug. > > Fixes: d4a27a3b092a ("nfp: add basic features") > Cc:stable@dpdk.org > > Signed-off-by: Peng Zhang > Signed-off-by: Yong Xu > Signed-off-by: Chaoyong He > Signed-off-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks.