From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, David Hunt <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code
Date: Thu, 15 Apr 2021 23:29:51 +0200 [thread overview]
Message-ID: <6276058.9Os0sLVhIO@thomas> (raw)
In-Reply-To: <572691ce-b0c1-d13c-1315-ea7600e1ad24@intel.com>
07/04/2021 18:10, David Hunt:
> Hi Anatoly,
>
> On 7/4/2021 4:56 PM, Anatoly Burakov wrote:
> > Previous fix has addressed the incorrect handling of `base_frequency`
> > file, but has added a use-after-free error due to the fact that all
> > further code paths will lead to an `fclose()` call at the end, so the
> > additional `fclose()` call right after processing the file was
> > unnecessary.
> >
> > Coverity issue: 369901
> >
> > Fixes: 8a5febaac4f7 ("power: fix P-state base frequency handling")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Yes, removing the fclose will do it. Either that or add an "f_base =
> NULL" after the fclose, but the fclose removal is fine.
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
next prev parent reply other threads:[~2021-04-15 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 15:56 Anatoly Burakov
2021-04-07 16:10 ` David Hunt
2021-04-15 21:29 ` Thomas Monjalon [this message]
2021-04-07 16:18 ` Liang Ma
2021-04-07 16:31 ` Burakov, Anatoly
2021-04-07 16:53 ` Burakov, Anatoly
2021-04-07 17:08 ` Liang Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6276058.9Os0sLVhIO@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).