Re: [dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Declan,

2014-12-16 11:15, Declan Doherty:
> - Split transmit hashing function into separate functions to reduce branching
>   and to make code clearer.
> - Add IPv4 IHL parameters to rte_ip.h
> - Fixed VLAN tag support in hashing functions and add support for TCP
>   in layer 4 header hashing.
> - Fixed incorrect flag set in test application packet generator.

You forgot to describe the problem you are solving.

You seem fixing something but I'm afraid this patch is too big to be safely
integrated in 1.8.0.
Was it your goal?

> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
>  app/test/packet_burst_generator.c          |   2 +-
>  lib/librte_net/rte_ip.h                    |   2 +
>  lib/librte_pmd_bond/rte_eth_bond_api.c     |   8 ++
>  lib/librte_pmd_bond/rte_eth_bond_pmd.c     | 161 ++++++++++++++++-------------
>  lib/librte_pmd_bond/rte_eth_bond_private.h |  15 +++
>  5 files changed, 115 insertions(+), 73 deletions(-)
> 
[...]
> --- a/lib/librte_net/rte_ip.h
> +++ b/lib/librte_net/rte_ip.h
> @@ -109,6 +109,8 @@ struct ipv4_hdr {
>  					   (((b) & 0xff) << 16) | \
>  					   (((c) & 0xff) << 8)  | \
>  					   ((d) & 0xff))
> +#define IPV4_HDR_IHL_MASK	(0x0f)
> +#define IPV4_FIELD_WIDTH	(4)

These new definitions require some doxygen comments.

Thanks
-- 
Thomas