From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 1F1542A66 for ; Fri, 15 Jul 2016 10:31:51 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id o80so18709677wme.1 for ; Fri, 15 Jul 2016 01:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qif+GejuGkE0VOCcZ7VzGTtAEB4dp59AUfgNBzE2N7E=; b=QoHAS2IbRLlFmtKitdAwGpM+btuhN/2rxgbkdnCP6Phpm3BJt2vv26RL3SEi6/FI5+ DZV7OrYWDTvJK3GY04bvJo7tBgV91jpLhEJfnMKTiwmSKxqcbHkKAaGF1ekm4ixxo8pe msILTzY7of6H18DifbQZQHnTM4i18tRoaPU11+2aujsKVShtL3dp2Fj9bYrE4DAjNaPa 1oXsYWzl69F4v4E4rE/t26aeFUbOzQtEIi1SBMxl+9jPxQd3BLtrbcBaSwr0c0mSYzt5 o/iFw8UC70Owpsd/lHt7zAXA8Jqj/Q6CvzSWkBDq2sa+bs3no4wE5L45yn0ZKvBePjQT WV2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Qif+GejuGkE0VOCcZ7VzGTtAEB4dp59AUfgNBzE2N7E=; b=e9fViGOohdbgwnqNYNKmSWujqGUPtZ9dDth6rauG/uFC1fN4f10W3k5jyteA/DPlfM vqQBdahuaBoILRjEJuX9ICImKiWJkAXNqfFsDQ2WHT9wKRZkXhRA7RtAA8k+Eq5ErbE0 X0cOfoSHez3vDrGRmDWT9esJ3r2NKZMQGZRh1gZE+weKnxiQwoFGVi6yR0W3grABg3Cx qiZVSXvOLaD3aRv96tuULLSgNNrVcQLJdONXg5I7FaIbDPmrpb3U7JjWzNDX57CKmgBW x9pA0aQerkeGG2JJ9/p5PZ3tu17gTggMbfjQRIAuA8lceJtEmo0e+g3VOIIxLxkHarGr GGnw== X-Gm-Message-State: ALyK8tJLYXBetxKeRjFhH+9iD0PzaPEAjFFrmndXW6ZRAm4KPRP5xKwH05iQEkVwCNX7Ecer X-Received: by 10.28.234.16 with SMTP id i16mr31555288wmh.76.1468571510781; Fri, 15 Jul 2016 01:31:50 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u125sm802437wmg.22.2016.07.15.01.31.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 01:31:50 -0700 (PDT) From: Thomas Monjalon To: "Damjan Marion (damarion)" Cc: dev@dpdk.org, Jan Viktorin , Bruce Richardson , Konstantin Ananyev , David Marchand Date: Fri, 15 Jul 2016 10:31:49 +0200 Message-ID: <6282391.Mg1yxlkp5v@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20160714132729.27024-1-damarion@cisco.com> <16886146.HTal4qelT5@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] spinlock: Move constructor function out of header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 08:31:51 -0000 2016-07-14 22:20, Damjan Marion: >=20 > > On 15 Jul 2016, at 00:06, Thomas Monjalon wrote: > >=20 > > 2016-07-14 18:10, Damjan Marion: > >> Dear Jan, > >>=20 > >> Thank you for your comments. A bit too much overhead to submit sim= ple patch > >> so let=E2=80=99s forget about it. I will just add it as it is to o= ur private > >> collection of patches. > >=20 > > These are changes trivial to fix when applying. > > I strongly prefer that you upstream patches instead of keeping patc= hes > > in the VPP repository. I will help you in this task. > > Thanks for the effort. >=20 > Yeah, I agree with you, unfortunately it is all about time, > for me it is still cheaper to rebase them. >=20 > I respect your rules, but I just don=E2=80=99t have enough free cycle= s > to spend learning all of them, for my occasional patch submission. We know there is a learning curve for the submission process. That's why we do not expect it to be fully satisfied, especially from occasional contributors. I am used to do some not significant changes before applying to help newcomers patches being accepted. That's what I will do in your case. As I said previously I will help you to drop your local patches. Please continue sending other patches with a detailed explanation and we will take care of them.