From: "Gaoxiang Liu" <gaoxiangliu0@163.com>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
chas3@att.com, dev@dpdk.org, liugaoxiang@huawei.com
Subject: Re:Re: [PATCH v4] net/bonding: another fix to LACP mempool size
Date: Fri, 25 Mar 2022 20:02:25 +0800 (CST) [thread overview]
Message-ID: <628cb2dc.14b.17fc0f4d531.Coremail.gaoxiangliu0@163.com> (raw)
In-Reply-To: <c0768ad8-0dcc-6437-d233-685b12c3276b@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Hi, Stephen, Min Hu,
I will fix the issues.
Thanks.
Gaoxiang.
At 2022-03-09 10:53:15, "Min Hu (Connor)" <humin29@huawei.com> wrote:
>Hi, Stephen,
>
>在 2022/3/9 9:25, Stephen Hemminger 写道:
>> On Tue, 8 Mar 2022 22:24:02 +0800
>> Gaoxiang Liu <gaoxiangliu0@163.com> wrote:
>>
>>> diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
>>> index 1e7a3c1527..fa15ed710f 100644
>>> --- a/lib/mempool/rte_mempool.h
>>> +++ b/lib/mempool/rte_mempool.h
>>> @@ -56,6 +56,8 @@
>>> extern "C" {
>>> #endif
>>>
>>> +#define RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER 1.5
>>
>> Why is a magic number from bonding ending up in the user API for mempool?
>Yes, I suggest putting the macro(name should be changed) in bonding. No
>need to define a new RTE_* macro in mempool.
>By the way, the RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER is the same as
>CACHE_FLUSHTHRESH_MULTIPLIER already defined in rte_mempool.c.
>
>
>> .
>>
[-- Attachment #2: Type: text/html, Size: 1373 bytes --]
next prev parent reply other threads:[~2022-03-25 12:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 9:56 [PATCH] " Gaoxiang Liu
2022-03-05 2:26 ` [PATCH v2] " Gaoxiang Liu
2022-03-05 7:09 ` [PATCH v3] " Gaoxiang Liu
2022-03-08 1:17 ` Min Hu (Connor)
2022-03-08 14:24 ` [PATCH v4] " Gaoxiang Liu
2022-03-09 0:32 ` Min Hu (Connor)
2022-03-09 1:25 ` Stephen Hemminger
2022-03-09 2:53 ` Min Hu (Connor)
2022-03-25 12:02 ` Gaoxiang Liu [this message]
2022-03-09 1:26 ` Stephen Hemminger
2022-03-25 12:10 ` [PATCH v5] " Gaoxiang Liu
2022-03-25 13:01 ` Gaoxiang Liu
2022-03-25 13:13 ` Morten Brørup
2022-03-26 12:57 ` Wang, Haiyue
2022-03-25 13:34 ` [PATCH v6] " Gaoxiang Liu
2022-03-25 14:04 ` Morten Brørup
2022-03-28 15:16 ` [PATCH v7] " Gaoxiang Liu
2022-04-29 14:20 ` Ferruh Yigit
2022-05-01 7:02 ` Matan Azrad
2024-04-12 19:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=628cb2dc.14b.17fc0f4d531.Coremail.gaoxiangliu0@163.com \
--to=gaoxiangliu0@163.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=liugaoxiang@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).