Hi, Stephen, Min Hu, I will fix the issues. Thanks. Gaoxiang. At 2022-03-09 10:53:15, "Min Hu (Connor)" wrote: >Hi, Stephen, > >ÔÚ 2022/3/9 9:25, Stephen Hemminger дµÀ: >> On Tue, 8 Mar 2022 22:24:02 +0800 >> Gaoxiang Liu wrote: >> >>> diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h >>> index 1e7a3c1527..fa15ed710f 100644 >>> --- a/lib/mempool/rte_mempool.h >>> +++ b/lib/mempool/rte_mempool.h >>> @@ -56,6 +56,8 @@ >>> extern "C" { >>> #endif >>> >>> +#define RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER 1.5 >> >> Why is a magic number from bonding ending up in the user API for mempool? >Yes, I suggest putting the macro(name should be changed) in bonding. No >need to define a new RTE_* macro in mempool. >By the way, the RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER is the same as >CACHE_FLUSHTHRESH_MULTIPLIER already defined in rte_mempool.c. > > >> . >>