From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1CF331CDEB for ; Fri, 8 Jun 2018 22:01:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6AECB21751; Fri, 8 Jun 2018 16:01:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 08 Jun 2018 16:01:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=uE5R9UMav/WBluQ6UMrcKsMTrc 7C+6JESW4uou68vls=; b=DFKEKyQbbLUCntBnXdOnm7saxIM3H9oMZABApO0z2Z 0zEvV4KzRRWQKpgztRAbR+UI0TZ1++1Q51N8cAo2xSCWTPhGrBdBc6w0FomNG3Z/ u2YFaZ310zai9jkMgL9ygJ7wjDTwJpnwZKddpe0TwAQFCWogDmZj6mdsfq5cJFr7 U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=uE5R9U Mav/WBluQ6UMrcKsMTrc7C+6JESW4uou68vls=; b=AH75tVnZt/ghcOshUIgiol 6RJuGxv9URZp2TW6D3mGE+xV/DikFHMJ58QA47maliqN9KAmbA5e3qsU6Ur258Hx mRJ+ipIC6CaUEFBq+l/UDtECmUXXqOo2xkpdZhFX2cGIeaykAJM3F7RyDQlTmPN9 lX3jOjwDcauCwSITdsIzFeaEIQP5D5ZtwzfpRAo5KIkXKwcc388WLUPISSOTRM1b yrQCBoPWq9nSUx5T3GBrydAAwiYvo9eyXmSGQjv6m33tYx2kxef2pIUqKxR37ebx kYw+omxJlv1fqQVUPg0rpwGjbt5Kc2hlmLKnpxpdz2ULSCJTl4dnaxmnFMqF+wvA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5EB2D1025C; Fri, 8 Jun 2018 16:01:52 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Shahaf Shuler , Wei Dai , Qi Zhang , Andrew Rybchenko Date: Fri, 08 Jun 2018 22:01:51 +0200 Message-ID: <6291522.OcHR8ZgW26@xps> In-Reply-To: References: <20180531124431.13746-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 20:01:54 -0000 08/06/2018 21:51, Ferruh Yigit: > On 5/31/2018 1:44 PM, Ferruh Yigit wrote: > > The error path was disabled in previous release to let apps to be more > > flexible. > > > > But this release they are enabled, applications have to obey offload API > > rules otherwise they will get errors from following APIs: > > rte_eth_dev_configure > > rte_eth_rx_queue_setup > > rte_eth_tx_queue_setup > > > > Signed-off-by: Ferruh Yigit > > --- > > Cc: Shahaf Shuler > > Cc: Wei Dai > > Cc: Qi Zhang > > Cc: Andrew Rybchenko > > Any objection to this patch? > I really would like to get this early to catch any possible issue. Yes you're right. Let's merge it.