From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0070.outbound.protection.outlook.com [104.47.40.70]) by dpdk.org (Postfix) with ESMTP id 84B02558C for ; Tue, 4 Oct 2016 08:51:07 +0200 (CEST) Received: from BLUPR0301CA0005.namprd03.prod.outlook.com (10.162.113.143) by SN1PR0301MB2016.namprd03.prod.outlook.com (10.163.226.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16; Tue, 4 Oct 2016 06:51:05 +0000 Received: from BN1BFFO11FD017.protection.gbl (2a01:111:f400:7c10::1:113) by BLUPR0301CA0005.outlook.office365.com (2a01:111:e400:5259::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16 via Frontend Transport; Tue, 4 Oct 2016 06:51:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD017.mail.protection.outlook.com (10.58.144.80) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Tue, 4 Oct 2016 06:51:02 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u946owXI014784; Mon, 3 Oct 2016 23:50:59 -0700 To: Thomas Monjalon References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com> <3582057.BR181DtlIn@xps13> CC: , , David Marchand , From: Shreyansh Jain Message-ID: <629b0e70-5bd1-d376-4fb9-e7c7a102d79f@nxp.com> Date: Tue, 4 Oct 2016 12:21:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3582057.BR181DtlIn@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131200374644788027; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(377424004)(377454003)(24454002)(626004)(36756003)(85426001)(104016004)(5660300001)(2906002)(230700001)(110136003)(6916009)(64126003)(65826007)(4326007)(8676002)(47776003)(65956001)(23746002)(2950100002)(6666003)(65806001)(81156014)(92566002)(81166006)(7846002)(31686004)(31696002)(77096005)(189998001)(8666005)(68736007)(97736004)(105606002)(106466001)(50986999)(86362001)(83506001)(33646002)(356003)(586003)(50466002)(76176999)(54356999)(305945005)(4001350100001)(87936001)(8936002)(7059030)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB2016; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD017; 1:Q8aHpNOnRPC35r7w0XiW5GI44Mgmu6jwPrwec1UtYGNl/f9GbLKKpZ7adligGrvp19q6FQTBmRpKQAwv6EH1g0bK6kMR7PadCqvyvys8LaJY2OsTXm2DchfstHsO82Vev8DJFJWc47vWsp5ae4vkxsbns5NnGYiaJOtn9oa4aOPFov4cleDE0YqZ4ImaXXxHdMVWjjVrH475AeGF/PGfLyB+FQyPqY7Q6t+C0LEIkacyDu4Dv1HukgE4nmETUmTNbFTxh1ostEjTDA2C8jfQmNALgb2gnQfK6rMSY+54t2ENRvYBP2xztX3Ukh4zggkIcmTYGiWuzRct18yR6NkW9zmmOWgia4qqM+MWM7jtJl+wrK6rp7bk9KC/Rj3uDxdAWHEsd1Ek+09/MZMXzWFLBqbW8nr8LcZ5kRjsnCGm30DORJKKA5eL5xd5fcDnWMO0uUg1pNV8UD26LFdlkg9E+BT1e1eBPdXftysKmLewMkCiRubFVC+IK60VJrxoYzmCzabPrDj2Wt8rlvqAkmjMf0pD5/Ca5Nsw3sGyl9ejvCicTlZbDhqaVJAoaBVrUEyxWWwe/qoj6gLiEbuPTvKAgA== X-MS-Office365-Filtering-Correlation-Id: db8d67a8-49ba-4bf7-69dc-08d3ec22cf8e X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2016; 2:qO2oDuFAvwfm7GJv2636qlDcKfjdfEQOa4egCq+QajHfOpLKQHrGwh2JHHueWWWAXYjmDJ6ofEvk/pwPQoWraVD4MDHEZ61JV097ZIK0TWp/iIOEnoDCdfnuiJt7FZtKs38qOSw4cpi+vrXzMoB5V4Q8n36RnBmWwYT9v/B0oGbYlPNlRjZHdmI3SDgHCQ3z0mH7XKrI/RQ8s213CCoXtw==; 3:QfIoVcyetGinu0Gc4gMU1GOD+mbqYioE0JjOeZTSPl1tfb4sLiasgXQ8WZPApfOZW+pZJftPJrbdHHZhWyNUASi5x2Ps8WIqXmvgvIeZxnaViYakvhym7xp7sl/9B/6F84hKV1ONGqX/Gjg2vEdleiVyyzOGaZI/yEmCIv04cZZdvdsaXuqIS+8uh3Cg9eTM1wRj0TJXqIlMynq9Ckgl09GGJH5o5H+1rQr5zi6ApteF/s804nbHMPMuh4b9LBMe; 25:QzR0CSfZ194w3vQvthpBJHZsN9L+JjiMUSIGA2IO/BiuIi7BFDTuUGQtsxHsqQpwdZWRGKZXQzWwBxejb21o/39CuWCNA9Bc+ZEIjUl1kqHmuxgq5PE4Fo1glcUwjJouvZtMQ7Gg7IB4SHReHPjJPxglwe9Avn3YXbBNpJKci9oE1XM0nQnKrEb9YijOQkGfi02/3RCU9fL6vT8njcmfBmCq5uvgvei008EZHBnrmikLYsfn31HP5CWlVmhWdiXpbfiyogRP8p5x206JdpJkFG2s4P7WhOBVZ+DWxeAoGlxud8D+5noA0dh0QbZjjpO35oZXWefNTbYeGd91wutMcbG3xdnk4XLGwbGcXpvHKaIG5phrG0s9r3+rKV6NMPiis8iTQkQyI/fvuIU12yAncvU/ldPUj5YiT3h9Rk9jfwvXb9umjsiFeCbOMKvvJm7i X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2016; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2016; 31:rq56HTjem1Vt+Xi7VH1CE0wxl2WgLiy1LsyQwNT+5jthUvCdVr2S+OGzb/Y+IobyYBek4TS+9/A05dUlyq9yVc4e/23HzP/j+VNxJyW/99BV94ICAtdKwgeoQ+NSVfajiwC07FME+YOP6I1HiJFlgoBUjUE3L+gO10C8F8Omr9L9rIWLzLKqmOS9YOhgT69n2IGa4q2ei0cW6JlUzyMOmNPpF3dyntqswytOXhqScyuUmKCKoO5DMDieDIzH+Hbw; 4:xOIyJVH1TIL1973+SH46Aq4pPvUJOHV39ph6CVMHAX3QDvfgwclhbe+2c2Uw/7OimX8JeMCrcwnOPKoM6x/OGmB1FBotuo2g72QNDUqGVnnglpbieyOEUTY2i5vbCLxifOlbgUldD+3ulDG3To/f0M7SCOAR4dpg8a02rrP7k+UhUoYZpxeCDRQxhkvany5rt5wCIhoN1YM10RClDsj/ZoXGIA5g8Vvq3/OmGxNxYOxSv4d8XVlVqcYBgqETpPRt1DqZ+iUhY+kwdWAh3oyoEtgcAJ22xcZtMmInpGkLv7oNALGNBKbfrnZRN8jaO008M+8khFxj1kHrxShY2yK6yc1sH3vUpS5hAktTMrLSkhUu9Pw56wzSRTh5Rh1kKvCodUU2+f/63pdZ8+ilWkSFwGgL5Tn91ylSq/D5ve8SgH79ntDvvqaGXhNPsAiVqpfs7AEDFeZcPGhzHCjirgzBrkeeNoRH+m0Dh66mXpRNA3Iv9T++xIPYEXVM9DxdfiW8UC9OR08DZLG8NGhDdHn31Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13018025)(13023025)(8121501046)(13017025)(13024025)(13015025)(5005006)(10201501046)(3002001)(6055026); SRVR:SN1PR0301MB2016; BCL:0; PCL:0; RULEID:(400006); SRVR:SN1PR0301MB2016; X-Forefront-PRVS: 00851CA28B X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN1PR0301MB2016; 23:nrFB+OvCBQtO/GNGQXZaIj6l47ey4FgsU2k?= =?Windows-1252?Q?RtfFMX+bwB5X+z1OFBM2ulmZo3cd6CHmVcdhzQQlHt3V48kvVXQL8NYt?= =?Windows-1252?Q?f6pgZaBWh8RyfwhGPq3G6DJovZvRsVDZRV74WwyL2PIlSQwSqYhoL++u?= =?Windows-1252?Q?nL/knvqafAVjz1S5/mr+WVhWSpdICxmAei3Yw0lmgFnlgMM/qhSbYV+K?= =?Windows-1252?Q?wJWrDXOflhbEdmYjVI/dJ+OSleiNQkCz866YjScagNvpXGiG/5QUm/PY?= =?Windows-1252?Q?8Z9sU7jvgOvLlUuSMEQo/73VkrUlcQUos/uSO/AZUigRbrAIE6EXgtYu?= =?Windows-1252?Q?a66l4FbHt2s1EcGymv/Nw6mpUWJhvDU11Mm1qqdKTyd0Ex56h0ZP0owN?= =?Windows-1252?Q?eqh14i8QcTMaEK0aOlOJOagrniT4f0PebVP3iXmcvD12Ku+pBkEiqQ7q?= =?Windows-1252?Q?5Y2Q2JCVBIAcHeUe0Pc0+nxgv7nLVuo3AO5BBcVucMBeKZVa5d9baafU?= =?Windows-1252?Q?ojKV84ngodJaDAduyuw0VkLS12kLv2SeKIDQ3IcdZFKwXel/bjqPBnbT?= =?Windows-1252?Q?t1XD1qPx0pQXqbwRsviawYY2rT5Yo8IJon+tNQMzigtpAh9bV1/Y+sJZ?= =?Windows-1252?Q?39KfUhF/5Vx6HJMZVfbpRthcDsxm10XHACMT+YJRIjnve6DUlne+42AO?= =?Windows-1252?Q?c3VaU/6vvH3moUCdKh4xqt03oWX66f3xFkjUKGHwkz1EsYLYRkduV0Pm?= =?Windows-1252?Q?0OQ6UYXWplfKtrUHOOAMryipnGtQwuQ+83synF78+EqZo7c44gYC1zut?= =?Windows-1252?Q?wO/C9/UZfeFXHE/kRqmtSgQX0VC+/bsFU9LE3r6SsUNaaPO21f5GiZfB?= =?Windows-1252?Q?h0M61K1R9Y/NNVfcwjlVh62n1i61EEubtt7HbJK79D3o/ckQnIEvmpxV?= =?Windows-1252?Q?KFIQGCMU56C7TS3y/uqi09uxTmRFTF27kEP+/eGPkB8rePxrzO2T5CAl?= =?Windows-1252?Q?Z2SajaO6UcDQs8Vkq8Ng8jW8zzQalOsX/JJ0LD4XiF1AplHJGg4fN8eY?= =?Windows-1252?Q?Yw7cLbwZ7cRVB9JAB4kgd0E5A6EPR2+gC0/I7r+fj4UvtHyKYx8xuVkv?= =?Windows-1252?Q?0GwaPqcGebv3S6gdMY7/v6QotHdUf4azOM7k+PkLQ0L+pKSoCaN6rqvM?= =?Windows-1252?Q?cQC09almPvIrE4+DZAEIFbn+SA9ZvEEwRqt7G8AtT24XwphA2QJ2Q3NR?= =?Windows-1252?Q?57tB28NsmraezsJA2YqVcLTHYkRCKu4QEZ05hcAz6cbOFUWr/Cm2wV5K?= =?Windows-1252?Q?eoMpMpS9/Mcbr9A7ihUHlWpQqKvvtUITIuOgIKf9z05Lg5tMpPrRsHIF?= =?Windows-1252?Q?cf6Gf3JWb+OVySLTfSb3+hirBQtGP8RQgsGv2kS/2Zupgd9Na9wZF3HN?= =?Windows-1252?Q?3cjiNaSiR0WOEiSaavEF1dgQYz62qoIlSz2QsSl7KTQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2016; 6:WUf3rL12+1gl+1SWCQisIWFNF4b2qWsjjhF39sQGXA0+2EEzqvjmj4/Rpv37IBDFmYFfZj9k1C9rnPvA5cfNp736uX1wsQxt+4pZU6gXTUAS7tXO6f+mqveoD+pqFgwwtUEiX3rYHowcLdu1jHpOa3ShTzOXIXJfRMLwx08wYMhUNXAwIrh+6NlK4RT6bYT5OgVucpEFzX8ge1RMcQ8F9Gj9KQZHCo0g+CcqqHebjEXHuexUREjoSudENzbzwdk8j8OanTXI09Gd0tP24FBUT9tCVqS8rydA9QkucI8m77LLLCa3z4OPMZA8kbn4NacZ; 5:n8OQ2wkMSiPligyLxEnNjgyN7BNX0FbWjLfEQndeQ1b+HNPeO3z+M+KatTHaiRioMp1RvrqeYN8qifGufCbOCVYMhDCzstBbu7GG4CFAuVYNfU/Esc8Lgi5ayfjmNlq06blfDESiwkQ+jFxWoNkfX9+B1IWCv+gog3su5E6HUJaGhS8AXUisWrt+dCjPjSr4; 24:JN/OlWg+nF7515z/8oeLEcaMyLN87ixv5qWbE2Oo2+eDS2uhVxAz79j0CiICnF0wyMGf2V8TfzTw6lAZG2xTJwqCGOvPRmO4f3B+pVKEoUw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2016; 7:EVjJSrH7ydoB4Gjn2TMgSoVNIRn2bnGynl3s79teTJZ0CaA6MP/3os5urefyBugTbNSVFZauk/P3EpSEC7YhejfhVj9OQN6wKNEsVyf8VP27oMAR+lG0IP2NjRc7AcmvaWOnOTg9IgKJPCthSjFx/m1UiLFKhz2VB+hH1ABZlxgiAppvI6B/hRCkKlxWBRPp76qUlfC3pKztw6Lp2/U8CxfPweyXp+p5F6PFJXRN4TXPv/WrS7m1UwmIEfdt8U8ykKflaNAgYZ7RH03cb4fiOfsy4JII2g9t9o3w4djZ2uiU68IKnlzmAueoMh2BnaOjO9ZQBZK2d4/ohFKbJxnVmw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2016 06:51:02.5444 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB2016 Subject: Re: [dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 06:51:08 -0000 Hi Thomas, On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote: > Applied, thanks everybody for the great (re)work! Thanks! > > 2016-09-20 18:11, Shreyansh Jain: >> Future Work/Pending: >> =================== >> - Presently eth_driver, rte_eth_dev are not aligned to the rte_driver/ >> rte_device model. eth_driver still is a PCI specific entity. This >> has been highlighted by comments from Ferruh in [9]. >> - Some variables, like drv_name (as highlighted by Ferruh), are getting >> duplicated across rte_xxx_driver/device and rte_driver/device. Both the above are already part of my todo list. > > What about those pending work? > > I would add more remaining issues: > - probe/remove naming could be applied to vdev for consistency Is that for uniformity reasons? I still feel 'probe/remove' are not appropriate for a virtual device. init/deinit are more appropriate. As for PCI, probe/remove are standard parlance and hence suit it better than init/deinit. Nevertheless, uniform naming convention can have its benefits - ease of code understanding being one. Change is simple once we come to a conclusion. > - rte_eal_device_insert must be called in vdev Ok. > - REGISTER macros should be prefixed with RTE_ That would include: DRIVER_REGISTER_VDEV DRIVER_REGISTER_PCI_TABLE DRIVER_REGISTER_PCI I will publish a patch soon. This would be fairly straightforward change. > - Some functions in EAL does not need eal_ in their prefix: > rte_eal_pci_ -> rte_pci_ > rte_eal_dev_ -> rte_dev_ > rte_eal_vdev_ -> rte_vdev_ > rte_eal_driver -> rte_drv_ > rte_eal_vdrv -> rte_vdrv_ > > It can be merged with changes for: - drv_name - EAL_ before _REGISTER_ macros - eth_driver => rte_driver naming -- - Shreyansh