From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0050.outbound.protection.outlook.com [104.47.38.50]) by dpdk.org (Postfix) with ESMTP id 7C0096CA4 for ; Fri, 16 Sep 2016 13:55:30 +0200 (CEST) Received: from DM5PR03CA0023.namprd03.prod.outlook.com (10.175.104.33) by BLUPR0301MB2004.namprd03.prod.outlook.com (10.164.22.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.619.10; Fri, 16 Sep 2016 11:55:28 +0000 Received: from BN1BFFO11FD021.protection.gbl (2a01:111:f400:7c10::1:149) by DM5PR03CA0023.outlook.office365.com (2603:10b6:3:118::33) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.629.8 via Frontend Transport; Fri, 16 Sep 2016 11:55:28 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD021.mail.protection.outlook.com (10.58.144.84) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.619.6 via Frontend Transport; Fri, 16 Sep 2016 11:55:27 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u8GBtNW3025318; Fri, 16 Sep 2016 04:55:24 -0700 To: Jan Viktorin References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com> <1473410639-10367-1-git-send-email-shreyansh.jain@nxp.com> <1473410639-10367-5-git-send-email-shreyansh.jain@nxp.com> <20160916133615.0213997b@pcviktorin.fit.vutbr.cz> CC: , , Thomas Monjalon , David Marchand From: Shreyansh Jain Message-ID: <629c183d-38bd-bba3-ae5a-066992db50e7@nxp.com> Date: Fri, 16 Sep 2016 17:25:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160916133615.0213997b@pcviktorin.fit.vutbr.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131185005280382098; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(24454002)(377454003)(199003)(189002)(189998001)(64126003)(8936002)(81166006)(33646002)(83506001)(356003)(92566002)(626004)(81156014)(586003)(575784001)(86362001)(2906002)(7846002)(87936001)(305945005)(8666005)(8676002)(19580395003)(2950100001)(47776003)(23746002)(31696002)(5660300001)(65826007)(106466001)(85426001)(68736007)(4326007)(19580405001)(105606002)(230700001)(110136003)(97736004)(65806001)(11100500001)(65956001)(15975445007)(93886004)(31686004)(50986999)(76176999)(36756003)(15395725005)(54356999)(77096005)(104016004)(50466002)(4001350100001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB2004; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD021; 1:Qpx+NFSJ73T5ppVrNoqXxj+z12CKz+9het9pK1tmDtv9DNRxfgwDLwjL5F4xE2wFhcUM4tvHv52sVaLJcOk/7Q/7Ev92UooSzoxGrvEl3SkWc+k5dx6KZPhmJPsegWhgkJijbLz9bp1itC7C9OZ9sQkMJHSEsb9QFcd+EdZ3KnL1Aqm5V/w+hLZjxOvhcy9zWTwA4EkWTfRYFAWpItJYYslHVJWoayp+7hI56/Unt2ZZaDlBO5HDiIn6GjVD5B2N2fGmcLlk8OqS4JaxtAU5TYqzsHKCcmXJazx7k2JoCcBr9cfp3eRMW98mzqJNZEQ+Bpj5w9WFuXGq+WmkRO79eb4rFb7zBhMV2DBMaFmGAIhK99Y/sDtNZVCMNZoGJ1YTEp042UkXv5Uh0yBHZ3oM6ez0mEE+oHP+CPT0pNIqCRaeyEWTvzOOMGswtUilmYV0TvL7XK8D1bs9A7W9fZgVPzu2PxxNcVzLzj/BVkga8o2nn+z1iqom7wHyCW28hxssySzjP+2waYzXk89VxEWpepSnv7JKZDIrM4mdQhuvUq/jEc9nrMRdSuGC4GUSwtf72siKtWXI4gv/f8gq8nt7ZqyChTHRb4YUodCIaRDETlQ= X-MS-Office365-Filtering-Correlation-Id: bd2f604b-cd04-460c-eb31-08d3de285a0c X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2004; 2:y6PlfiIaDaCj27/oPoGorIOdGBIE4srbKZIrWSMrwxo6jjuO1WA+jsHtpws1OxVWSFeXUjcPfmIx7UMTDV4zzC/qkG5bxmo3LfRHdxP1ffi4XeY0XZL+QdNkKj46vIy20vFB+VSjkZ/lBaAExNLvM6huOL08pyUtQg147puzvFUiA1D6spNPtPb4UmrMsnyD; 3:nua98GWKe3VcJHQUQE1dbDLyaCnCOcbXqlCVDjOqObn5Xd9pZbbniFdq/yIBvNZky+5oi1tD+9e8WDwd/l6C6IDJn9F0fb0u8JMgHlWFdaA5k61H1D8hg6hyv0kVuFTeEldjronju6CQrOF0ZnDnY02iMtTK6/SDtpGCf8RzqvEa6QUWpY2YqDrZRw3U+ytN0fUQyoBNU8KPLbkIeZxB+rEZe0GgpHtJrzqy/Sc6Tik= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB2004; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2004; 25:x1w35Nx0XmULDz6imP1qF8wYQF+9J1fsAshl8X3O/H0yP/DvlpzPlWy7w1EcwdLUDWCf0XJQ0WRn7t24jWc5KJLVMVDOAuaYFCQL7mV7slpD/c7bp3niRUoEcoWF5hn6BkPKbGbNXygN4XB0Z8QgFWkMSIBuRjm5vBuCaD/zr2BBtft0NWKRZ0AWf3QgLBEPsWBKlfiQi29e9Gyh+8w4xPovaK9Dz+4vpUY4YWT/c5GhQiG4cBZgPrNU/dWld6oqlmrmQoxDFcA0xOW+f5la15T0EtDYAlbHZJ1NLzpYdlUkwLuEjp/Tjh53Cb9ts/0dCctpKhWhyxyPtsgy8+/3mXG4TBSU9Q4z+Bnom00XQNuj6ogeh3jNzR77rmhS2dW4WtadiUrtGaQfkeZL/2f5f+d+ULE04NyC7nuBpEbff3dxBhBvl7NMHLGh05WKR6U2iIVgAETkLvdYes5+X1JuBmc6KQiQrZ6OzmcVCjlMbIVx+LSLtimqvU/tiP3rHHv9PTmN0xv4WH6aHrBwsxscJ5HkFopkfTRMz9miSL5qUtJRHd4eY9N6JDnM0ZY+eAy3RL8t79g8I6KujAuVlwX596YivcaqIgUsbDPRcGyUK+AwAFaNaT2OLDmZ6cqD4vetQtddimUpoLJ7tg9eAVwu04kQ1RTPVWkqv2y48K11zlwwdIjZxjh1UHHaNtZvPYBHO4rF5UBIdEIFnsf2ehkFotg1+fWrijpzPjt4VFeNQfLQjYlAb5RY8f1KabHAEKeXKn944KGIO6ND1/V5OkLISRCu7NRRvCv89seeObtifnYg0Per0nIQjyBcQ4ejB5+k X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2004; 31:D6GGyO4/0OKr4BEkHFg1YEayBkYfQ+HHG9TI3e2EmWfFigmwjU1WEfstbkK+HkgusjxxpKu5/XLUsgM/g3FSJgQuqQMJtM507KOz+UWMkt904ZDrczzC6Jb6OQjf9zYP7MInlzkCrqn2JbQRtFdo6pVrABHFCjUf5T2Cm0YdpXxC0/K+TZARnKyJCD9Q2boEhkLB/ty1HfIWRhCMT0ElT/pfanm3lkjeQZFCbWE3chw=; 4:kQwNRK5g1zy9cEscHG94+/1xUEr6iRDfXDsT7IMaCO8D7i/xlsPakVRKq+Eq90D8TQ/1Qxd7IwOHbLoJ/CbHWvSf3hA1Uqea6H/WFgsQTN/dkgjqIN7ptm29TbfzGrro1kytI2Oj+Hm90Q13OQ3d1AbJ0XYfFF19YUrEUpPj7WGm/kylgnkGYn5oMiHQsoj/ZJx2jHylZckvB7FwL/GEaFUtvYAeQv3xNp0Eourq0LqvJ2Or2BTdOQpBFuhZrYfVYslxNgX4VcI9BiPnMeu59vXO+Z8Xa3aut0nYGjgyVR4YEx0Li8BMd9EMBg/MDjfeG/1i7+AH/gCX7lvuOYxv2j9uPAkl13t5bgmlcZ4DPDZfzoqqd/B3W1X+FRv7KrZyK8kCnhyTYpxfPKm8px3QcuId7UDq2gStCoLtdemiSH3Rmkg5IzUyMykm2evoIajUY1BqD0kF09YGxWuX3dKD26An++JKYuseFZjHLd37VnIhDcSQ27OSJHWPFfUkn4bIJUL7zOnEYyQizXOOF0uxysGNNpfvPRsiEcEqzOKo33Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:BLUPR0301MB2004; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB2004; X-Forefront-PRVS: 0067A8BA2A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR0301MB2004; 23:0CujHEMdjoOBDWm3qAnRpyl3xC+wT8gUkic?= =?Windows-1252?Q?A6iHxLhMgOwoJ5iI8zn/e89UH6Z7pfT32o61IJWIYqZiINc+nzMpGrGw?= =?Windows-1252?Q?4b3N4kaqL3whd54PGMJkzor8IIoU5jwmwCqvsdlRw9TqmGNx8ikbO3Lg?= =?Windows-1252?Q?r6dcoVRUmkLgHTpstGixS1GYMuGenq8qdBrgUK5JP1aDIS8bF4udUbQ3?= =?Windows-1252?Q?WWLTKyq9ZQLoW2TA0TAK6QOGSkIUgduG6b97FBi9/+cmh4Qg1QrUDjg4?= =?Windows-1252?Q?TsmfqfTr/g1bddpDM3GvOVC0HaAJVwXV8slr9mERa8D71ZtB6liiisRI?= =?Windows-1252?Q?4SwXZB6hSoHzOKdhAT0IOXO3/FoOi4kuAkmBbCuSS/3qrejGdf+a2Xv+?= =?Windows-1252?Q?1+iACfzlBK6W48P3NoJdnlRLDI8b1XFb+3P5PmqSnCE5U9B8/bCqkUJ8?= =?Windows-1252?Q?LueFoOzQfbgvEpsO3DTGXUZs/5IZs6OqXBaRgJLsvdVGeCBjvDv6PHPE?= =?Windows-1252?Q?/VyJf4x720AzVqj4rNuZawF1qYo8xXvejUcN/LRFxmaWoFNC00d7ugNM?= =?Windows-1252?Q?a5e0I/UxT8ReiCdV5xPglhRAWa+yuJyQnfbT++pMCJmncnx8Gec26svd?= =?Windows-1252?Q?F+hEMuol6e/pX4z5eEuCcSnrhb6/u5wJD3V1o747d/xXiOpBluAizxsk?= =?Windows-1252?Q?FzO0RHSlIHO+zt/mcL2PhVEI4ALZXgVG6yM3FVFZL4cr+9TVBAJISe6a?= =?Windows-1252?Q?L/V9Jx7SB9tOevTdmhh4mfdWN2c8GsMjQVcldMLGfeZl6qFctWcabUy+?= =?Windows-1252?Q?9q3j/3TabC+V9FnFrGMUCboCRlVgTPIaTpMN5TVs20B0wy+/+FYn0ygU?= =?Windows-1252?Q?vsZrTU7qdjb7cbxAIMC4kpKg/UnVsYctfn4FroN8BxFBJEhYuowxZkDC?= =?Windows-1252?Q?q9fXDzKV+4vr1sHrVUzCSxWMdjlOwRCDWB7V0fmKat2pt1NBnS3j/Sib?= =?Windows-1252?Q?m0pM0ddWQeTNj17HUIvxVO5zA8hK+mdzSUYsVy1iQubtwefVvgb+eoM3?= =?Windows-1252?Q?MAg4p6kSJE6QIqVkT2NJbdn34UkiO547WVZUyuerWOQgO4a69kE4U3/A?= =?Windows-1252?Q?Zx3ueoCkqkp0nWdPELVuGacnnlFoo7FaGKUt7Zbf3jBggh/qEAba59Oy?= =?Windows-1252?Q?dN837wJnoHRJ7GzClrQtVLAv6/BcLJ4kiETjnCXzM96Al/mCxCUsnvE6?= =?Windows-1252?Q?5bORJ7MpP0Cb3ixLyY4ZomhKmnm4JFdnWNeTzx9qXKUMeBIJLw50TzLx?= =?Windows-1252?Q?XUTl2usLVhR8qfu1hKQ1dlVb9bs9Nskx+AQpmLYWqyDVP7QO+oc0+Mjd?= =?Windows-1252?Q?bNJ44eKWgcFnB6PwaOQA1ueIZULE7fhbWvCcsqizIiksBvbNV5gjFxcJ?= =?Windows-1252?Q?ulkUlNbLbU3+jXuUu3c99+z90akK0lc/X+6Rsks7DMXqB5+VMxQN/9sA?= =?Windows-1252?Q?w3lsDz0pEtpa/65lFCfMH5CrWLXYiFgY662Xuil7apFdX1q5EgjXhigS?= =?Windows-1252?Q?OS55Lk8hIgsbgYDg0UyEtZgXZAxprw9iwRep/?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2004; 6:BdObgMsc4FAD1UrT2v8zHtoXKNAd13RZgv2ZvBt/VEoLeLU6rGuYVgrDZHJzbaJ26G18iKCtkAfQpDuau6dQPL1IIHdSHucSUdpNTQ1FdR1VDEM1GKyIAHfegXVedMRD8VIEhDnODAXe6CymOQG0cvSNnk1borxO7UllM0dQs+YHLK4jlZblZWs2vFs7yxCQsf/H4mUGv+CD3ZqLOGB6TMWP8TLgeR+h8g+gDxY1n9AS+y0UMLR3Y6HBKl765gvYqIB0z5g3VVfr4Qa+Lr9BoUd5zG+Ej2vcCH1MOYxm4lw=; 5:0Na8gP4lxCM/soMA/sbzQcrloPOT8agP0CdqufrAiJyQZ/JcWULS/gXnntDyTkMWPiJd0IN1JBuonVCoLt/49uB1Jjy6FD0f1jtAE2yVQoylgxk6Xn7R63GttqrCvevURzz6/i9po/J0P0xW1XH661SE3DkAfkCl5RK8JgZ/lJg=; 24:bhJe/bvd0NWSiceMN9fcBcP7n9NdfpcPtjTUCb52GKiMVGX0431AjlzPJXz3Q9X1NLUsa0siyo/TUp12pLyCOj0kCy2Aqfg1ycKkndBvxeA=; 7:9c4tV5AKPNvYNJnaFrzJRwVfOKrF6NfY/31vsRairnGLCCM+O7eX/DTsDpdb8qx+wQEAj56oZqkzPoHEO8uu6mOX309hq9SnRxTLoBRa61VQvVYyM0mPIlmEvbDP4/o3d6xvjEh+d9wbJANlz3nVfyOR7EGEaE57yz6tKaaSAOLB3n6Nt7DzeXbFdD97nBzgRtCLfOSwlmjhKwSdVuPsNXgkXFES3ZZwgQuuyTtrCfuguvLfC0fBnFUr4riTp5lw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2016 11:55:27.7886 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB2004 Subject: Re: [dpdk-dev] [PATCH v3 04/15] eal: introduce --no-soc option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 11:55:30 -0000 Hello Jan, On Friday 16 September 2016 05:06 PM, Jan Viktorin wrote: > Hello Shreyansh, > > there was an objection to reverse this option from negative > to positive semantics: > > http://dpdk.org/ml/archives/dev/2016-May/038953.html Ok. I wasn't aware of this. Sounds reasonable as SoC is experimental for some time. > > As SoC infrastructure would to be experimental for some time, > I think it is a good idea to disable it as default. Agree - I will update this in v4. Thanks for bringing it to notice. > > Regards > Jan > > On Fri, 9 Sep 2016 14:13:48 +0530 > Shreyansh Jain wrote: > >> This option has the same meaning for the SoC infra as the --no-pci >> for the PCI infra. >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> Signed-off-by: Hemant Agrawal >> --- >> lib/librte_eal/common/eal_common_options.c | 5 +++++ >> lib/librte_eal/common/eal_internal_cfg.h | 1 + >> lib/librte_eal/common/eal_options.h | 2 ++ >> 3 files changed, 8 insertions(+) >> >> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c >> index 1a1bab3..d97cf0a 100644 >> --- a/lib/librte_eal/common/eal_common_options.c >> +++ b/lib/librte_eal/common/eal_common_options.c >> @@ -85,6 +85,7 @@ eal_long_options[] = { >> {OPT_NO_HPET, 0, NULL, OPT_NO_HPET_NUM }, >> {OPT_NO_HUGE, 0, NULL, OPT_NO_HUGE_NUM }, >> {OPT_NO_PCI, 0, NULL, OPT_NO_PCI_NUM }, >> + {OPT_NO_SOC, 0, NULL, OPT_NO_SOC_NUM }, >> {OPT_NO_SHCONF, 0, NULL, OPT_NO_SHCONF_NUM }, >> {OPT_PCI_BLACKLIST, 1, NULL, OPT_PCI_BLACKLIST_NUM }, >> {OPT_PCI_WHITELIST, 1, NULL, OPT_PCI_WHITELIST_NUM }, >> @@ -855,6 +856,10 @@ eal_parse_common_option(int opt, const char *optarg, >> conf->no_pci = 1; >> break; >> >> + case OPT_NO_SOC_NUM: >> + conf->no_soc = 1; >> + break; >> + >> case OPT_NO_HPET_NUM: >> conf->no_hpet = 1; >> break; >> diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h >> index 5f1367e..3a98e94 100644 >> --- a/lib/librte_eal/common/eal_internal_cfg.h >> +++ b/lib/librte_eal/common/eal_internal_cfg.h >> @@ -67,6 +67,7 @@ struct internal_config { >> unsigned hugepage_unlink; /**< true to unlink backing files */ >> volatile unsigned xen_dom0_support; /**< support app running on Xen Dom0*/ >> volatile unsigned no_pci; /**< true to disable PCI */ >> + volatile unsigned no_soc; /**< true to disable SoC */ >> volatile unsigned no_hpet; /**< true to disable HPET */ >> volatile unsigned vmware_tsc_map; /**< true to use VMware TSC mapping >> * instead of native TSC */ >> diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h >> index a881c62..ba1e704 100644 >> --- a/lib/librte_eal/common/eal_options.h >> +++ b/lib/librte_eal/common/eal_options.h >> @@ -69,6 +69,8 @@ enum { >> OPT_NO_HUGE_NUM, >> #define OPT_NO_PCI "no-pci" >> OPT_NO_PCI_NUM, >> +#define OPT_NO_SOC "no-soc" >> + OPT_NO_SOC_NUM, >> #define OPT_NO_SHCONF "no-shconf" >> OPT_NO_SHCONF_NUM, >> #define OPT_SOCKET_MEM "socket-mem" > > > - Shreyansh