From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7731A00BE; Tue, 28 Apr 2020 11:20:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87E671D5B4; Tue, 28 Apr 2020 11:20:33 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id DABFC1D5A0 for ; Tue, 28 Apr 2020 11:20:30 +0200 (CEST) IronPort-SDR: JQB+0CPADm33WWxHJFCJ5U1BnyUAyKVkIF6rLhxMyhhg/nx/5icAEpacfguurobNKvCUJb0Nlk /uiWFPpd05LA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 02:20:29 -0700 IronPort-SDR: 7M/OeLdP9ICtnH98vSG3z1NjbLkPUwpYqrBjlgivk3aqm7GmRtIMluALgXkQNRt4WI0dH0WQFZ EP82DRuulTzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="459169775" Received: from hrazax-mobl.ger.corp.intel.com (HELO [10.252.13.25]) ([10.252.13.25]) by fmsmga006.fm.intel.com with ESMTP; 28 Apr 2020 02:20:28 -0700 To: Stephen Hemminger Cc: dev@dpdk.org References: <20200104013341.19809-1-stephen@networkplumber.org> <20200104013341.19809-10-stephen@networkplumber.org> <3a9e69b8-93ea-9631-67bd-4e5408ccdfac@intel.com> <20200427100017.2470b009@hermes.lan> From: "Burakov, Anatoly" Message-ID: <62ae5b30-38cc-dc7f-e6e7-14e6d9e50c18@intel.com> Date: Tue, 28 Apr 2020 10:20:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200427100017.2470b009@hermes.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 09/14] eal: close mem config on cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 27-Apr-20 6:00 PM, Stephen Hemminger wrote: > On Mon, 27 Apr 2020 13:12:32 +0100 > "Burakov, Anatoly" wrote: > >> On 04-Jan-20 1:33 AM, Stephen Hemminger wrote: >>> Resolves file descriptor left open after rte_eal_cleanup. >>> >>> Signed-off-by: Stephen Hemminger >>> --- >>> lib/librte_eal/linux/eal/eal.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c >>> index 9ad81378f23c..e5c2a24322e9 100644 >>> --- a/lib/librte_eal/linux/eal/eal.c >>> +++ b/lib/librte_eal/linux/eal/eal.c >>> @@ -1346,6 +1346,12 @@ rte_eal_cleanup(void) >>> rte_mp_channel_cleanup(); >>> eal_cleanup_config(&internal_config); >>> rte_eal_log_cleanup(); >>> + >>> + if (mem_cfg_fd != -1) { >>> + close(mem_cfg_fd); >>> + mem_cfg_fd = -1; >>> + } >>> + >>> return 0; >>> } >>> >>> >> >> For the patch, >> >> Acked-by: Anatoly Burakov >> >> However i think it's incomplete, as there are also memory-backing >> fbarrays that are still mapped. Also, secondary processes have their own >> shadow copies of the master page table located in the mem config, so >> those should be destroyed on cleanup too. >> > > This patch set was targeting things in stages. It is not complete, some of the > cleanups would be hard to do. Just getting the obvious things first. > Fair enough. You still got my ack :) -- Thanks, Anatoly