From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0083.outbound.protection.outlook.com [104.47.1.83]) by dpdk.org (Postfix) with ESMTP id 2672C4F98 for ; Thu, 1 Mar 2018 07:10:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bDZlkNEv8qn0shm1ZLFjC/aho0ctCj9ZjYIGYjTgu54=; b=m3aYh+wcS8ly2CDbu8EvbfL5sc+082bCihEX0LjC3f7FqhsJQiRWgKl7aW+2h8thXva8fRCp3GsIGwuG0Vpp2SnCX/0eYX+aohySbIXJkKwhu2Zdl1JHqI8n2sbE6f9NCyl8+GTRbPB9JqyrG7F/RRjPPBBj2xL89UYp+1QAkAA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from [10.232.133.65] (14.142.187.166) by AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Thu, 1 Mar 2018 06:10:11 +0000 To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, shreyansh.jain@nxp.com, Akhil Goyal References: <1519752352-15442-1-git-send-email-hemant.agrawal@nxp.com> <1519752352-15442-8-git-send-email-hemant.agrawal@nxp.com> <20180228144409.GA10572@bricha3-MOBL3.ger.corp.intel.com> From: Hemant Agrawal Message-ID: <62b44634-c2e5-eb91-03b1-68b356835a3e@nxp.com> Date: Thu, 1 Mar 2018 11:40:00 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180228144409.GA10572@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BMXPR01CA0034.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::20) To AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 93f0d748-a7f5-47f1-20cf-08d57f3b1805 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0754; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 3:PKIIHpLzhyWxdiij4sF2PCIQ5WnZSDdA+bG4QEIWfDLY5/6YmLhhvEXtw2KwLjBve/S7aUv+hckjF0p6stsZix/1/Pmq4uy8OmIaKegugVunOp7XTVZju8GTntSLwnTuMWDSlulcj5BXCKx1V8AKfoE+gVb4B3HLKer1HBQnyZ6YEgOgHlSS1Bzx5iIL0CVy3UDKgVJsemqbt0rMNr8EtoWIveI0o/yHT/MPB4GiWTgA/0PQQ+EyIuyy28KBr6FE; 25:4gq2um7MSLsBuCyNNjvlX3AzmFeKdSZypJLffUv8gdJdy/dMexsPsnRqtWjN3Zkct+uTJgwIPg1RDgvLBbV46Q1aFtCEBAWJ/T8BBVMVlcscL/8DDUS1njl/l42AKbaFYwWKsrTPtJ9pNurWT/ELgysHmf1STRZE2kPcaHOOomuRCS4qyZPOMcN04FlJQQWGhm5vyltLrGhS3rQWZ5WHU0mnbDifCzSefekYlMCiA3Ji+HfnfZji3P0DY6R6VMo1Q+NE9LPnDwqDmIxP7N6H8H+LpzR5U8KpHZlyoEQ04UIMRh8V79HlVnWjxvT7JMoZ/gW5mTRwgcq/TP74fsX88Q==; 31:KVsh2C2qZqRqCbGQHFMgOpaB53CGiWBc/r9mWQUdIZoP9mBqQQA75ccCM7oQAzxTQvXKkdp+LBA/YzcVz4MNv6cdKkb3KQlnIk8+qtTJEdR7qcDfRsZuaRcdMDoSB9mP1BlFaKNiaxRskre6tkythxmv7IZ3kxc3FIq/o+enyiikQM1t6h1rqWwQPVjfkub9yiOBMrVgMMYvwiW7vbzgKWUKS9p2yw6SiPxHhX7ARu4= X-MS-TrafficTypeDiagnostic: AM2PR04MB0754: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 20:GmgW/r8KOObAjAAnpx2HpOT8biuttIJq2Kxo+2cTqoQdda4WBnrPd7s2KmgtA3ctgF3BS31kjGpHx6dlO0mAYzL2xMrYaKKfS0nXVjyTQc//Fpv+MwrSklFnW3ZlCHaPgXwIYZkNes5wbc1goW2scUpc9ab49noIf/A522JzwgrdIWMn9fzvmsfQDehVVWofJHaVK0XPHsvYYscvD4eMPRqErPmRpI3wEBo5J5mUPRcIl7TJy84qNAMSRf5tAgFF3JtN8E25rKnykfXSOoi66Cp3T5JOJgsArVQII3J6GI0NOgR9h7FjD3x24tZwtVuoWM3MWG/qHZ7+MqtAE+r+djNEqPNVHHa3w6dIcy+Z79sOxNaKT2J9/GmTRDVAs5A6oU9r3Uah6lIC6ck87NKoJ+Czkdvx+yPDtyQs0UcmTOjWVkFmP04nC5aSKwT7Uus3Ec89BtzQb2FQ2EkZ1Nqv1oYZzC2jLOrcBEsUYrFr5szuHhDmxcDD5qAccK+iMG9b; 4:BsmYpWObvvDpJTRRVysoU0PN0QAyaL1QpMEVrHgulz71VvDWKv0gtPx61OE7wHs3djxc8/O6t1Y2O9BFnl4kV2CPhdBTT4shVC6nhXvMN+O7SXdX4ZM3aO8BBITSqVLkKxN9YnvM4axXse4V+N7DCIew6W0F+o3EH5xBL7MqvDOq4t+kRxk+HrJFIObl8t/lHFaY1BzSvDlzkGU66ulU0c4Y8+QNF4iR6EOzbS4s+ajQDvDiSxcSuEuceWjAoFhOjMX9Q37RcSDcd4q52KsPoefnEpDDQ/uf3EhevYYD5H09iA+RfiBe2ldiRaxRdVY9omNJ4LaBq9wxdCVzE3oHRaB6Wt/kLDO+Gq1EhVKPP6VBXUCHPWBE6ydWsrX+gVwF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(3231220)(944501161)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:AM2PR04MB0754; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0754; X-Forefront-PRVS: 05986C03E0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39380400002)(39860400002)(366004)(396003)(346002)(376002)(189003)(199004)(106356001)(65826007)(8676002)(6246003)(31686004)(478600001)(4326008)(97736004)(8936002)(105586002)(81156014)(58126008)(53936002)(6486002)(36756003)(16576012)(316002)(81166006)(7736002)(305945005)(31696002)(50466002)(386003)(6116002)(229853002)(5660300001)(52146003)(2486003)(230700001)(6916009)(52116002)(2950100002)(6666003)(23676004)(5009440100003)(64126003)(66066001)(67846002)(25786009)(53546011)(65956001)(2906002)(65806001)(47776003)(3846002)(68736007)(16526019)(77096007)(59450400001)(26005)(86362001)(76176011)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0754; H:[10.232.133.65]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTJQUjA0TUIwNzU0OzIzOkFlQmVEbEV0Z2dFcURiUUgxdnNKa0hyUEd0?= =?utf-8?B?SnN2ZmZUeVA2VFNxeU1nVW4zaEZmUGRCcC9BQjhkNkFtYnpKaGY2WnpKYXR0?= =?utf-8?B?WDQwaWkrSTJxWURlbVBaWGpkbWE3L0UvY0RVdHpPUjZjVCt4eE12TkhpZGxP?= =?utf-8?B?YnJKRUZsaVZ4NTFrUlZqVUhXOUJVUi9sUzZHVHBRTm9lNXkxTjNTSll0MUIr?= =?utf-8?B?c2p1aEhWZ2prNUVRaVB3cjdNY2dyU09VL3RXemlDa2NJbnQ2RXFDb09xZ0Nk?= =?utf-8?B?UEs0dGJQeElBSE52bjdRTUlRWTd5TlFBUjZTNGRnYkg2cHREOUUxVmgxcVdy?= =?utf-8?B?RTFJR0pQeTNCaFlyZFZaUEhFL3M3b1UzbmRiazZwMVNvVG9jUEdpeVBVeDh0?= =?utf-8?B?SFJGM1RFUHV2Z3pOeStOb1NudFhtRm5wM3dLSjlTdUttYzR5eTdCdkRpSG5Z?= =?utf-8?B?TjhkcjIzRjZxeEk2K1VQeWVON3NyZUlFYnZMdEJPVzdScUY4OEF5RU5UR29s?= =?utf-8?B?WCtzZHh6K1R6ZUUrWURwNjI2anJ3SnFtdXhQaUQ0V2hLeGhMVE1tb1JZcTNT?= =?utf-8?B?SWVWcFdEb3FERmZXOUdtR095RGJiK3EvWC8zL1ZLVW5XSmNzUktCV2J4aU1U?= =?utf-8?B?VWxvUnBUYVkwUlNBdzk1UzF1RnJaVHFQcTgzd2JEWE05aUNpYVJOazg2dndo?= =?utf-8?B?QWFpWkNkelgwZitQYWJtbVRWZXI5eGJMR0F0dUwyRlduQURnYVBtTFdGVGRI?= =?utf-8?B?aW9uNWFhTjhJajdHVVJ1WGp0eFVEYmNTbDYyU2lYQTlZZUkxS0lFUjVWYndz?= =?utf-8?B?OGFlZlZhd2ZiMDEzb3N4cHI0MURVeXlqVjBGazNONWNiWWRUN1ZqeGFvZ29z?= =?utf-8?B?MUdWSzdwZGdOY0thMVFTY0FBQWZ1Q0RKWXpITDBRdlJuZUo0TDNZRU1oYUJD?= =?utf-8?B?Mmh6aklhdkx3VTBRTmNoRlNtb0xFckNNcW5xQi9UT0JCMmV0M3B3U3MzenBa?= =?utf-8?B?U1hQUms2alhyQ0N5MlNVZUMzRXNTamt2eHFoanVlVUNrQzFEak9naHJFMlhk?= =?utf-8?B?aHlJVi9NVjJoNGhhZjBPTXVSUE5kRkYwSDVxQWVzc0cwNUk1RmZwemV1MFJN?= =?utf-8?B?czZ1MDdkbjZUaEJNUmdpMlFPa1pjaXRmU0hEdzRvejdQZjRBaHRyS29YZElz?= =?utf-8?B?elpBczBObDlNQTlOZ21wNnhLMDcwRVQ0cEEvdm1JWFBKSHhVYzRyeHV1Ym1z?= =?utf-8?B?cngwc2pNZGlhRGlDTGtqWUZNbE9FdHZHbHlWdkdkZUlZTm03Sk1iRGUrOEQy?= =?utf-8?B?MU8zUDZnMTloVnpVZ0V6dmNab1dpb3Npb2x2ZTI3SkZGcjNyS3NUTlhTZ1BP?= =?utf-8?B?ajFuYk5xRGZ2eDBKNG1XY2tFbjE0anpwS2V5a0NONmpzSkpkSE5mSmY3NXZh?= =?utf-8?B?elF5MnRlZERobFEzeWllYkVxRFJOZitHZkd3M0pRWGNYZHUzK1RGdmtTRHM4?= =?utf-8?B?SjVPTE9ubEh4WnhyaDRRRzY0RmdlaEpZYjFtYXk0YmVyZ0Z6eUVhQWEwTjJ4?= =?utf-8?B?MjZWY2ExdFB6R0hITi94RThxNHpUYVo3MXFEWnJZRTlxOGtYckZSSDR0TDJ0?= =?utf-8?B?QVVRanhJZ0paOEUwbk1SQU1mblRiaUJOcWhKSGV0MTU2c0plVmNoSWlDaCtu?= =?utf-8?B?amQyZTgzdmZqMlRxSmZ2dVdXd1pkOE9HWHc4VUJqa1lPRCt0ci9NQmFnVXIr?= =?utf-8?B?K3ZuSmNKWEVvMkI0Rlp5Vi9ZTU1GSEpzM3gzOXdka2NCYTFPZmZBc0FNOWRO?= =?utf-8?B?UDFhK1U3aFgxZzNsRDFsbGV5UVhUdGlDZTBUNG9EQkJKMHVlN0lsdXBhOHJ5?= =?utf-8?B?eXR0aklBaVpFTkNMSGQxZkZrRUp2VzMrU0hqamtRWDJmQ3gxR21LUitDaGY4?= =?utf-8?B?NVg1UGRCbHJ3PT0=?= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 6:aXq4j++8QOzPeyMTddIAJ+l71nB8nlarOGsvtRQixx8FSyDZropDQlJrR57eGjRd/mb+4whlgF0vmvPWYq3o9qgZCBzQB33dVC3tmlYQdHxhypa/8SRNUOP00t+vS1/XipuD9u9ZzpjfiV9R4r06j0Wr3+F6doHZZMCYPRGnNyzS+IVhBol+XCwfNO19kkBLL6H01nVfuhG4fKAa5qXrYAotHCVX7CT9mUlgeif8Fzpko7/ZT3ssrJkj5mn2qUnZlH6PoGWus5bZj7pMKVbQ5z/+xrrnnWskqQ5ByAxMrkZ7rZ90sn2+pW+uCih0n0aC+rbXHXTkuxWLDACEmkR/fkJtlej2Zhy+RpevO+wYMRc=; 5:Hhe7Y6yXqHfDyAjQQPvay4ruHIKSyxc5R+IVS4MlYbH3Z6M6aS0DlTgiS+NPxmZKXBAfjnSMUABh7TSlE2v8c+xNgLelU1dz234ypiyWRAXimC5LCYIxvgsia2T7EPuVpRG/HH0GeI29q13cRKz2IEbP69ItMvqb+d3GGqtbu5M=; 24:xLRvhmVUZ/fXfKXYYzcxPIqGn0hB7MOBbSf7Cz3SQ+CU7PKoVH3MNAOrhYWFK5W5pnlNQIm6XmKTbiab9Jj59UngscLrffnWz/n0VjABJbQ=; 7:mrJ+TkxNX8xu7cdi81TFmtxgnXM+y8tdPw3zgs6l7Li53CxiL8QIePEjYldFeef6sDGpPg3o+jabNd2T2R63qyCtwSvi2cbWsSIddElUqYcLgqkvzFH14rqbe90Dd5aeztABPoGiMyJklRHwfFqTbBPKqRQxM0P6qAZNCnqy9xWESKz7IUfZcU2Prh4IREaxpklJC3S8gwXd1Y2bys8TUyofFbjumyaju2Qr+dM26OaHhvH1Xk14hIT2sJhjjSqp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2018 06:10:11.4486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93f0d748-a7f5-47f1-20cf-08d57f3b1805 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0754 Subject: Re: [dpdk-dev] [PATCH 7/7] build: add meson support for dpaaX platforms X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 06:10:15 -0000 On 2/28/2018 8:14 PM, Bruce Richardson wrote: > On Tue, Feb 27, 2018 at 10:55:52PM +0530, Hemant Agrawal wrote: >> Signed-off-by: Akhil Goyal >> Signed-off-by: Hemant Agrawal >> --- > > Thanks for this. Some comments inline below. > > /Bruce .. >> diff --git a/drivers/bus/fslmc/meson.build b/drivers/bus/fslmc/meson.build >> new file mode 100644 >> index 0000000..87475ee >> --- /dev/null >> +++ b/drivers/bus/fslmc/meson.build >> @@ -0,0 +1,28 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright 2018 NXP >> + >> +if host_machine.system() != 'linux' >> + build = false >> +endif >> + >> +deps += ['eal', 'ethdev', 'eventdev'] > > Another minor nit - eal isn't strictly necessary here as both ethdev and > eventdev already depend on it, and dependencies are recursive. > Explicitly calling out all dependencies is not wrong, but in previous > prototyping I found that meson takes a lot longer to run when it has to > sort through all the dependency chains. That's why in other libs and > drivers I tried to keep the dependency lists to a minimum. > As well as this, EAL is a standard dependency, so it's already in the > deps array at this point. > yes, it worked. >> +sources = files('qbman/qbman_portal.c', >> + 'qbman/qbman_debug.c', >> + 'mc/dpmng.c', >> + 'mc/dpbp.c', >> + 'mc/dpio.c', >> + 'mc/mc_sys.c', >> + 'mc/dpcon.c', >> + 'mc/dpci.c', >> + 'portal/dpaa2_hw_dpio.c', >> + 'portal/dpaa2_hw_dpbp.c', >> + 'portal/dpaa2_hw_dpci.c', >> + 'fslmc_vfio.c', >> + 'fslmc_bus.c') >> + >> +allow_experimental_apis = true >> + >> +includes += include_directories('../../../lib/librte_eal/linuxapp/eal') > > Is this not covered by the dependency on eal? Is it accessing things > directly in the EAL internals? We are accessing eal_vfio.h. so it is needed. ../drivers/bus/fslmc/fslmc_vfio.h:12:10: fatal error: eal_vfio.h: No such file or directory #include > >> +includes += include_directories('mc', 'qbman/include', 'portal') >> +dpdk_conf.set('CONFIG_RTE_ARCH_ARM_TUNE', 'cortex-a72') > > This setting seems strange here? How is it used, and why set only inside > this particular driver? > We can remove it >> +cflags += ['-D_GNU_SOURCE'] >> diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build >> index c6af500..2187f6b 100644 >> --- a/drivers/bus/meson.build >> +++ b/drivers/bus/meson.build >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: BSD-3-Clause >> # Copyright(c) 2017 Intel Corporation >> >> -drivers = ['pci', 'vdev'] >> -std_deps = ['eal'] >> +drivers = ['pci', 'vdev', 'fslmc', 'dpaa'] > > Please keep alphabetical order. > >> +std_deps = ['eal', 'kvargs'] > > No big issue with this line change, but did you consider just making > kvargs a dependency of the fslmc and dpaa buses directly, rather than > making pci and vdev also depend on them? > Yes. it will work