DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Li,Rongqing" <lirongqing@baidu.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH][v3] net/af_xdp: optimize RX path by removing the	unneeded allocation mbuf
Date: Wed, 25 Nov 2020 01:00:46 +0000
Message-ID: <62cbe842acc84349ac49cded19c580f7@baidu.com> (raw)
In-Reply-To: <db3bd087570c4ef293fac964c14a1997@intel.com>

> > +	if (rte_pktmbuf_alloc_bulk(umem->mb_pool, fq_bufs, nb_pkts)) {
> > +		AF_XDP_LOG(DEBUG,
> > +			"Failed to get enough buffers for fq.\n");
> > +		/* rollback cached_cons which is added by
> > +		 * xsk_ring_prod__needs_wakeup
> > +		 */
> 
> Thanks for adding the comment.
> There's a small mistake here.
> The function in which cached_cons is added is xsk_ring_cons__peek.
> Could you please submit a v4 with this change?
> Thanks!
> Ciara
> 


Sorry, I will send V4

Thanks

-Li

      reply	other threads:[~2020-11-25  1:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20  6:14 Li RongQing
2020-11-24 14:21 ` Loftus, Ciara
2020-11-25  1:00   ` Li,Rongqing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62cbe842acc84349ac49cded19c580f7@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git