From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C84A4A0C41;
	Fri, 16 Apr 2021 10:21:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5234C14192F;
	Fri, 16 Apr 2021 10:21:31 +0200 (CEST)
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
 by mails.dpdk.org (Postfix) with ESMTP id 1934614176E
 for <dev@dpdk.org>; Fri, 16 Apr 2021 10:21:30 +0200 (CEST)
Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59])
 by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FM8HD6t5TzPr31;
 Fri, 16 Apr 2021 16:18:32 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id
 14.3.498.0; Fri, 16 Apr 2021 16:21:24 +0800
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Power, Ciara"
 <ciara.power@intel.com>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>
References: <1618051453-21264-1-git-send-email-humin29@huawei.com>
 <1618487412-26678-1-git-send-email-humin29@huawei.com>
 <1618487412-26678-3-git-send-email-humin29@huawei.com>
 <BYAPR11MB33669C758F661D8FDA525327FF4D9@BYAPR11MB3366.namprd11.prod.outlook.com>
From: "Min Hu (Connor)" <humin29@huawei.com>
Message-ID: <62e706e0-a889-205e-436a-c5d9fd2f700d@huawei.com>
Date: Fri, 16 Apr 2021 16:21:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <BYAPR11MB33669C758F661D8FDA525327FF4D9@BYAPR11MB3366.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH v3 2/2] test: fix missing check for thread
 creation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



ÔÚ 2021/4/16 1:05, Pattan, Reshma дµÀ:
> 
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> +	if ((strcmp(env_value, "run_pdump_server_tests") == 0)) {
>> +		rc = pthread_create(&thread, NULL, &send_pkts, NULL);
>> +		if (rc != 0)
>> +			rte_panic("Cannot start send pkts thread\n");
>> +	}
> 
> 
> I think you still have not addressed the David comment on previous version of the patch.
> So , can you change this to  something like below
> 
> Option1)
> rc = pthread_create(&thread, NULL, &send_pkts, NULL);
> If ( rc ! = 0 )
> {
> 	rte_panic("Cannot start send pkts thread : %s\n", strerror(rc));
> }
> 
> Or
> 
> Option2)
> If ( pthread_create(&thread, NULL, &send_pkts, NULL) !=0 )
> 	rte_panic("Cannot start send pkts thread\n");
> 
> 
> Also,
> 
>>> test: fix missing check for thread creation
> Change this subject line to  "test/pdump: fix missing check for thread creation"
> 
Hi, Pattan, fixed in v4, except for "test/pdump", if v4 is OK, please
modify it for me, @Ferruh, thanks.
> Thanks,
> Reshma
> 
> .
>