From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1011A3168 for ; Wed, 16 Oct 2019 15:46:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 913B41BEF1; Wed, 16 Oct 2019 15:46:27 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E79641E87D for ; Wed, 16 Oct 2019 15:46:25 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 23E792A09A3; Wed, 16 Oct 2019 13:46:25 +0000 (UTC) Received: from [10.36.112.44] (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5452860C5E; Wed, 16 Oct 2019 13:46:18 +0000 (UTC) To: Ilya Maximets , Flavio Leitner , dev@dpdk.org Cc: Shahaf Shuler , David Marchand , Tiwei Bie , Obrembski MichalX , Stokes Ian References: <20191015161727.32570-1-fbl@sysclose.org> <20191015185951.6295-1-fbl@sysclose.org> <5900f514-f1d9-7f7d-0ea1-f394b9e5d01f@ovn.org> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <62fb6a50-d4ab-584d-8cb2-4820c141f137@redhat.com> Date: Wed, 16 Oct 2019 15:46:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <5900f514-f1d9-7f7d-0ea1-f394b9e5d01f@ovn.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 16 Oct 2019 13:46:25 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/19 3:32 PM, Ilya Maximets wrote: > On 16.10.2019 13:13, Maxime Coquelin wrote: >> >> >> On 10/15/19 8:59 PM, Flavio Leitner wrote: >>> The rte_vhost_dequeue_burst supports two ways of dequeuing data. >>> If the data fits into a buffer, then all data is copied and a >>> single linear buffer is returned. Otherwise it allocates >>> additional mbufs and chains them together to return a multiple >>> segments mbuf. >>> >>> While that covers most use cases, it forces applications that >>> need to work with larger data sizes to support multiple segments >>> mbufs. The non-linear characteristic brings complexity and >>> performance implications to the application. >>> >>> To resolve the issue, add support to attach external buffer >>> to a pktmbuf and let the host provide during registration if >>> attaching an external buffer to pktmbuf is supported and if >>> only linear buffer are supported. >>> >>> Signed-off-by: Flavio Leitner >>> --- >>>   doc/guides/prog_guide/vhost_lib.rst |  35 +++++++++ >>>   lib/librte_vhost/rte_vhost.h        |   4 + >>>   lib/librte_vhost/socket.c           |  22 ++++++ >>>   lib/librte_vhost/vhost.c            |  22 ++++++ >>>   lib/librte_vhost/vhost.h            |   4 + >>>   lib/librte_vhost/virtio_net.c       | 109 ++++++++++++++++++++++++---- >>>   6 files changed, 182 insertions(+), 14 deletions(-) >>> >>> - Changelog: >>>    v5: >>>      - fixed to destroy mutex if incompatible flags >>>    v4: >>>      - allow to use pktmbuf if there is exact space >>>      - removed log message if the buffer is too big >>>      - fixed the length to include align padding >>>      - free allocated buf if shinfo fails >>>    v3: >>>      - prevent the new features to be used with zero copy >>>      - fixed sizeof() usage >>>      - fixed log msg indentation >>>      - removed/replaced asserts >>>      - used the correct virt2iova function >>>      - fixed the patch's title >>>      - OvS PoC code: >>>        https://github.com/fleitner/ovs/tree/rte_malloc-v3 >>>    v2: >>>      - Used rte_malloc() instead of another mempool as suggested by >>> Shahaf. >>>      - Added the documentation section. >>>      - Using driver registration to negotiate the features. >>>      - OvS PoC code: >>>        >>> https://github.com/fleitner/ovs/commit/8fc197c40b1d4fda331686a7b919e9e2b670dda7 >>> >> >> Applied to dpdk-next-virtio/master. > > Thanks Maxime, > > But can we return back the mbuf allocation failure message? Good point, I missed it. > I mean: > > diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c > index 66f0c7206..f8af4e0b3 100644 > --- a/lib/librte_vhost/virtio_net.c > +++ b/lib/librte_vhost/virtio_net.c > @@ -1354,8 +1354,11 @@ virtio_dev_pktmbuf_alloc(struct virtio_net *dev, > struct rte_mempool *mp, >  { >      struct rte_mbuf *pkt = rte_pktmbuf_alloc(mp); >   > -    if (unlikely(pkt == NULL)) > +    if (unlikely(pkt == NULL)) { > +        RTE_LOG(ERR, VHOST_DATA, > +            "Failed to allocate memory for mbuf.\n"); >          return NULL; > +    } >   >      if (rte_pktmbuf_tailroom(pkt) >= data_len) >          return pkt; > --- > > It's a hard failure that highlights some significant issues with > memory pool size or a mbuf leak. I agree, we need this error message. > We still have the message for subsequent chained mbufs, but not > for the first one.  Without this error message we could never > notice that something is wrong with our memory pool.  Only the > network traffic will stop flowing. > The message was very useful previously while catching the root > cause of the mbuf leak in OVS. > > I could send a separate patch for this if needed. We need a separate patch. If you want to do it, please do! Otherwise I'll do it. Thanks! Maxime > Best regards, Ilya Maximets.