Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add supported hash function check

[Thomas Monjalon <thomas@monjalon.net>]

23/04/2018 18:06, Ferruh Yigit:
> On 4/20/2018 3:30 PM, Xueming Li wrote:
> > Add supported RSS hash function check in device configuration to
> > have better error verbosity for application developers.
> > 
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> >  
> > +	/* Check that device supports requested rss hash functions. */
> > +	if ((dev_info.flow_type_rss_offloads |
> > +	     dev_conf->rx_adv_conf.rss_conf.rss_hf) !=
> > +	    dev_info.flow_type_rss_offloads) {
> > +		RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: "
> > +				    "0x%"PRIx64", valid value: 0x%"PRIx64"\n",
> > +				    port_id,
> > +				    dev_conf->rx_adv_conf.rss_conf.rss_hf,
> > +				    dev_info.flow_type_rss_offloads);
> > +		return -EINVAL;
> > +	}
> 
> Hi Thomas,
> 
> This can break the PMDs that are not setting flow_type_rss_offloads properly.
> How can we highlight this so that PMD owners can double check?

Can we have a check-list in the RC1 announce email?