From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E27CF27D for ; Mon, 23 Apr 2018 20:14:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4303A21A88; Mon, 23 Apr 2018 14:14:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 23 Apr 2018 14:14:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=A1YvKcrb2tIH7gxtLlf3gyu5w0 D7JvqYGN9w8+coOb0=; b=EX/YJdWF2SblHiH7eYuKtudXPuQLMmoVBFskebW0d2 HhaI1TCMuH7szZo+eByXUAyZ7FpnvqSJrmNSd1Hv/mDISvsxofPojElxNwy8cC5N mGS+OkJ0cmND6qc1FaXU16+nhc3dg9zxCLduDgk7GtqsTySLoKCEy4dwRxF5tcyf A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=A1YvKc rb2tIH7gxtLlf3gyu5w0D7JvqYGN9w8+coOb0=; b=nvKHafuGRi8SPLwidlT4Tg gTvBfpSsSIDbtmhkG1wrXoQAIQt0KvW0cxsTi2gpkV1flJ6eEMipGbmUNPRUaF1H fA51gM1Gxb02En+XR9jf3CNPf3G3MPmys05w6Z7MJd+v1XrOYqKjpcAaX+i/OIEs rrY6nQQ3IpM6s/11Oi2GDyuApq0a8/GVWWBzoHU0YKSRLBfPSezgoqCKoeRs/+To BV5+d+gJMz4JGpZbl+QMxKcK4dEt3yF7RASEmu4hownUy7JRKMCmhdC/JIQya24L i9+55DKfShKe5xwI6gf7tQyHwFku/XinFVqy87yhu4jc8vfp2uLiWZfrnmKV3Yiw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 210D8E47F2; Mon, 23 Apr 2018 14:14:06 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Xueming Li , Shahaf Shuler , Nelio Laranjeiro , Wenzhuo Lu , Jingjing Wu , Adrien Mazarguil , dev@dpdk.org Date: Mon, 23 Apr 2018 20:14:04 +0200 Message-ID: <6300361.pQ73498XhG@xps> In-Reply-To: <6f9cfb31-850d-b52a-c1d6-abd9d1406b41@intel.com> References: <20180409121035.148813-1-xuemingl@mellanox.com> <20180420143023.117071-1-xuemingl@mellanox.com> <6f9cfb31-850d-b52a-c1d6-abd9d1406b41@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add supported hash function check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 18:14:08 -0000 23/04/2018 18:06, Ferruh Yigit: > On 4/20/2018 3:30 PM, Xueming Li wrote: > > Add supported RSS hash function check in device configuration to > > have better error verbosity for application developers. > > > > Signed-off-by: Xueming Li > > Acked-by: Adrien Mazarguil > > > > + /* Check that device supports requested rss hash functions. */ > > + if ((dev_info.flow_type_rss_offloads | > > + dev_conf->rx_adv_conf.rss_conf.rss_hf) != > > + dev_info.flow_type_rss_offloads) { > > + RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: " > > + "0x%"PRIx64", valid value: 0x%"PRIx64"\n", > > + port_id, > > + dev_conf->rx_adv_conf.rss_conf.rss_hf, > > + dev_info.flow_type_rss_offloads); > > + return -EINVAL; > > + } > > Hi Thomas, > > This can break the PMDs that are not setting flow_type_rss_offloads properly. > How can we highlight this so that PMD owners can double check? Can we have a check-list in the RC1 announce email?