Re: [dpdk-dev] [PATCH 0/4] Broadcom 10G NIC Poll Mode Driver

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-02-12 16:45, Stephen Hemminger:
> On Thu, 12 Feb 2015 14:56:06 +0000
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > 2015-02-12 06:33, Stephen Hemminger:
> > > On Thu, 12 Feb 2015 15:00:13 +0100
> > > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> > > 
> > > > Hi Stephen,
> > > > 
> > > > 2015-02-07 07:15, Stephen Hemminger:
> > > > > Source was from FreeBSD.
> > > > > 
> > > > > changes were to make it work and lots of de-uglification.
> > > > 
> > > > Maintenance would be eased by showing this work with separate commits.
> > > > You should at least have a patch for importing FreeBSD source without
> > > > modifications.
> > > > 
> > > > Other comment: there could be other drivers for Broadcom devices.
> > > > Why not keeping the name bnx2x?
> > > > 
> > > > Thanks
> > > 
> > > That history is lost.
> > 
> > I don't understand your answer,
> > and you forgot one question.
> > Please reply below each question.
> > 
> > I said: "You should at least have a patch for importing FreeBSD source
> > without modfications". Is the initial FreeBSD source lost?

Without answer, I guess Brocade lost its initial import.

> > Do you agree to rename to bnx2x?
> 
> This was based of driver called bxe in FreeBsd but the
> changes are so massive that there is no point in creating such a
> patch except to keep some lawyer happy.
> 
>  37 files changed, 33668 insertions(+), 159047 deletions(-)
> 
> It might be okay to rename the visible config option and directory
> to bxe but not going to change internal things.

Yes it's a minimal change.
By the way, you named it "bcm" but it has been acquired by QLogic:
	http://www.broadcom.com/press/release.php?id=s832628
So we should refer at it as "NetXtreme II".
I have no strong opinion about the name of the pmd (bnx2x, bxe, whatever),
except it should not be bcm.

When making a v2, please don't forget to add a section in the MAINTAINERS file.

Thank you