From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 511ADB3DF for ; Fri, 13 Feb 2015 09:32:23 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id hi2so10138987wib.4 for ; Fri, 13 Feb 2015 00:32:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=aqy3pR1dHsHsW1j6Eyx5+SMlCXgdqHrdUmrVCwhTl4E=; b=eM7gj7aI/Ik02d5fu32cbpJTW/yLaW19rro8DwVuS53M0bAYYeQRIbO7gJOOOLmh+F oD4OATDz6aNDS+I7zh5uKgfVAMwnvjKj2eSDC9H7TMA/dvXSKcIfPcUXSDt684evvjcP Gw/hcStIsk5HntoXT3nbov0cJTMTTM+p9Wy++USbR+zVNnQ3zS3HwSq0NcipI/+BXaXG d+OwnipuB6FeScXUvOCUX5o3CYb5a6OxkeQ4MvVb/PrW0jVInehA9OKUbVYKCAklrJ0c X2b4zLfAoXrJJDN1D9oYYWYVZJs2UcgXL7H4R7y77wlo6+mP77mEutfFlpHTOxqTINnx NdkA== X-Gm-Message-State: ALoCoQlI+GFgJKHuQ6ufZ7wFRIAcq+R5W1EihpsO1zDcfQZe2ntvCs4cZbX1zXWgL8dGuTG1dwF4 X-Received: by 10.195.13.197 with SMTP id fa5mr16240515wjd.41.1423816343099; Fri, 13 Feb 2015 00:32:23 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q5sm1990836wix.0.2015.02.13.00.32.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Feb 2015 00:32:22 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Fri, 13 Feb 2015 09:31:53 +0100 Message-ID: <6300725.hi2JHYioPc@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150212164550.0a2b8e2a@uryu.home.lan> References: <1423247795-22399-1-git-send-email-stephen@networkplumber.org> <0a8c8ae93e354bf0a74dd8ade9d1cc70@BRMWP-EXMB11.corp.brocade.com> <20150212164550.0a2b8e2a@uryu.home.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 0/4] Broadcom 10G NIC Poll Mode Driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 08:32:23 -0000 2015-02-12 16:45, Stephen Hemminger: > On Thu, 12 Feb 2015 14:56:06 +0000 > Thomas Monjalon wrote: > > > 2015-02-12 06:33, Stephen Hemminger: > > > On Thu, 12 Feb 2015 15:00:13 +0100 > > > Thomas Monjalon wrote: > > > > > > > Hi Stephen, > > > > > > > > 2015-02-07 07:15, Stephen Hemminger: > > > > > Source was from FreeBSD. > > > > > > > > > > changes were to make it work and lots of de-uglification. > > > > > > > > Maintenance would be eased by showing this work with separate commits. > > > > You should at least have a patch for importing FreeBSD source without > > > > modifications. > > > > > > > > Other comment: there could be other drivers for Broadcom devices. > > > > Why not keeping the name bnx2x? > > > > > > > > Thanks > > > > > > That history is lost. > > > > I don't understand your answer, > > and you forgot one question. > > Please reply below each question. > > > > I said: "You should at least have a patch for importing FreeBSD source > > without modfications". Is the initial FreeBSD source lost? Without answer, I guess Brocade lost its initial import. > > Do you agree to rename to bnx2x? > > This was based of driver called bxe in FreeBsd but the > changes are so massive that there is no point in creating such a > patch except to keep some lawyer happy. > > 37 files changed, 33668 insertions(+), 159047 deletions(-) > > It might be okay to rename the visible config option and directory > to bxe but not going to change internal things. Yes it's a minimal change. By the way, you named it "bcm" but it has been acquired by QLogic: http://www.broadcom.com/press/release.php?id=s832628 So we should refer at it as "NetXtreme II". I have no strong opinion about the name of the pmd (bnx2x, bxe, whatever), except it should not be bcm. When making a v2, please don't forget to add a section in the MAINTAINERS file. Thank you