* [dpdk-dev] [PATCH] net/i40e: fix out-of-bounds writes during vector Rx
@ 2016-07-21 11:03 Ilya Maximets
2016-07-21 19:09 ` bynes adam
2016-07-21 23:35 ` Thomas Monjalon
0 siblings, 2 replies; 3+ messages in thread
From: Ilya Maximets @ 2016-07-21 11:03 UTC (permalink / raw)
To: dev, Helin Zhang, Jingjing Wu
Cc: Zhe Tao, Heetae Ahn, Thomas Monjalon, Ilya Maximets, Sergey Dyasly
From: Sergey Dyasly <s.dyasly@samsung.com>
Rx loop inside _recv_raw_pkts_vec() ignores nb_pkts argument and always
tries to receive RTE_I40E_VPMD_RX_BURST (32) packets. This is a violation
of rte_eth_rx_burst() API and can lead to memory corruption (out-of-bounds
writes to struct rte_mbuf **rx_pkts) if nb_pkts is less than 32.
Fix this by actually using nb_pkts inside the loop.
Fixes: 9ed94e5bb04e ("i40e: add vector Rx")
Signed-off-by: Sergey Dyasly <s.dyasly@samsung.com>
Acked-by: Ilya Maximets <i.maximets@samsung.com>
---
drivers/net/i40e/i40e_rxtx_vec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx_vec.c b/drivers/net/i40e/i40e_rxtx_vec.c
index 05cb415..51fb282 100644
--- a/drivers/net/i40e/i40e_rxtx_vec.c
+++ b/drivers/net/i40e/i40e_rxtx_vec.c
@@ -269,7 +269,7 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
* D. fill info. from desc to mbuf
*/
- for (pos = 0, nb_pkts_recd = 0; pos < RTE_I40E_VPMD_RX_BURST;
+ for (pos = 0, nb_pkts_recd = 0; pos < nb_pkts;
pos += RTE_I40E_DESCS_PER_LOOP,
rxdp += RTE_I40E_DESCS_PER_LOOP) {
__m128i descs[RTE_I40E_DESCS_PER_LOOP];
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix out-of-bounds writes during vector Rx
2016-07-21 11:03 [dpdk-dev] [PATCH] net/i40e: fix out-of-bounds writes during vector Rx Ilya Maximets
@ 2016-07-21 19:09 ` bynes adam
2016-07-21 23:35 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: bynes adam @ 2016-07-21 19:09 UTC (permalink / raw)
To: Ilya Maximets
Cc: dev, Helin Zhang, Jingjing Wu, Zhe Tao, Heetae Ahn,
Thomas Monjalon, Sergey Dyasly
On Thu, Jul 21, 2016 at 02:03:38PM +0300, Ilya Maximets wrote:
> From: Sergey Dyasly <s.dyasly@samsung.com>
>
> Rx loop inside _recv_raw_pkts_vec() ignores nb_pkts argument and always
> tries to receive RTE_I40E_VPMD_RX_BURST (32) packets. This is a violation
> of rte_eth_rx_burst() API and can lead to memory corruption (out-of-bounds
> writes to struct rte_mbuf **rx_pkts) if nb_pkts is less than 32.
>
> Fix this by actually using nb_pkts inside the loop.
>
> Fixes: 9ed94e5bb04e ("i40e: add vector Rx")
>
> Signed-off-by: Sergey Dyasly <s.dyasly@samsung.com>
> Acked-by: Ilya Maximets <i.maximets@samsung.com>
> ---
> drivers/net/i40e/i40e_rxtx_vec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec.c b/drivers/net/i40e/i40e_rxtx_vec.c
> index 05cb415..51fb282 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec.c
> @@ -269,7 +269,7 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
> * D. fill info. from desc to mbuf
> */
>
> - for (pos = 0, nb_pkts_recd = 0; pos < RTE_I40E_VPMD_RX_BURST;
> + for (pos = 0, nb_pkts_recd = 0; pos < nb_pkts;
> pos += RTE_I40E_DESCS_PER_LOOP,
> rxdp += RTE_I40E_DESCS_PER_LOOP) {
> __m128i descs[RTE_I40E_DESCS_PER_LOOP];
> --
> 2.7.4
Acked-by: Adam Bynes <adambynes@outlook.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix out-of-bounds writes during vector Rx
2016-07-21 11:03 [dpdk-dev] [PATCH] net/i40e: fix out-of-bounds writes during vector Rx Ilya Maximets
2016-07-21 19:09 ` bynes adam
@ 2016-07-21 23:35 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-07-21 23:35 UTC (permalink / raw)
To: Ilya Maximets, Sergey Dyasly
Cc: dev, Helin Zhang, Jingjing Wu, Zhe Tao, Heetae Ahn
2016-07-21 14:03, Ilya Maximets:
> From: Sergey Dyasly <s.dyasly@samsung.com>
>
> Rx loop inside _recv_raw_pkts_vec() ignores nb_pkts argument and always
> tries to receive RTE_I40E_VPMD_RX_BURST (32) packets. This is a violation
> of rte_eth_rx_burst() API and can lead to memory corruption (out-of-bounds
> writes to struct rte_mbuf **rx_pkts) if nb_pkts is less than 32.
>
> Fix this by actually using nb_pkts inside the loop.
>
> Fixes: 9ed94e5bb04e ("i40e: add vector Rx")
>
> Signed-off-by: Sergey Dyasly <s.dyasly@samsung.com>
> Acked-by: Ilya Maximets <i.maximets@samsung.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-21 23:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 11:03 [dpdk-dev] [PATCH] net/i40e: fix out-of-bounds writes during vector Rx Ilya Maximets
2016-07-21 19:09 ` bynes adam
2016-07-21 23:35 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).