Re: [dpdk-dev] [PATCH v8] mem: command line option to delete hugepage backing files

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-10-28 23:23, Sergio Gonzalez Monroy:
> On 28/10/2015 22:04, Shesha Sreenivasamurthy wrote:
> > When an application using huge-pages crash or exists, the hugetlbfs
> > backing files are not cleaned up. This is a patch to clean those files.
> > There are multi-process DPDK applications that may be benefited by those
> > backing files. Therefore, I have made that configurable so that the
> > application that does not need those backing files can remove them, thus
> > not changing the current default behavior. The application itself can
> > clean it up, however the rationale behind DPDK cleaning it up is, DPDK
> > created it and therefore, it is better it unlinks it.
> >
> > Signed-off-by: Shesha Sreenivasamurthy <shesha@cisco.com>
> > Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

> Patch looks good!
> 
> Just a couple of things for the next time ;)
> You might be aware of them, but it doesn't hurt to remind them:
> - When sending new version, use --in-reply-to to the last version of the 
> patch sent, it's easier to have all patches on the same thread (if your 
> email client supports it)
> - Also when sending new versions it's useful to add what has changed 
> from the previous to the new version.
>    (add such info after the three dashes as shown above)

+1

Other things:
Some lists like EAL options are alphabetically sorted.
When adding a new line, please try to keep the order.

Applied with orders fixed, thanks.