From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 880908E93 for ; Wed, 4 Nov 2015 02:04:42 +0100 (CET) Received: by wmff134 with SMTP id f134so98249429wmf.1 for ; Tue, 03 Nov 2015 17:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=SdyGvASw85CEj+incluH5pQfifjVyZ9Qz7l0193FdAI=; b=ttPD44vfZFkSMDdL7nVbw4/4APs5lzIFEaGTzsMICwiXypqJdDxqDO4Ql5iWrq6nrv sLuQQf3Pk2kt3YdEphiRD0TOjhfHI1kRB1qM++CT+fDdvmBsn+1TQojHjd2OVBBXIqs3 VdqRzuJpqQDIQA9sBtzikMtibqn1YzF7VQmu8BA3OIeOp1tUEM9UEUnZx9nYhSRbo9mf pGSgRFHfCkafOCbPzd2YGuhv1gIXojMOtFiN46glIDIdZBiBkIL4NwzywUwqKhYeQerZ CbVWZxBPXEi1D4y9hPj9tpQU4K7dXQntSE+cN41AUs6fKOxwVb0G0QUypntNukOOUTlJ aT+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=SdyGvASw85CEj+incluH5pQfifjVyZ9Qz7l0193FdAI=; b=HUQdsFfffHZ37bJHcMah8nZrAj15kd2vWgNxSiqLd7cf/tEV33hnu9bhcQC7itbKJD T758oG4W3Du/BxIGrLTJT7Ik3MVvtX6/iPfAjcfYdQbHKLCrRvIWwEAFL5OZ3CyNkyHa VK/8GQqmnsON7z/rLDxa4qTklUapp7eKu7w9Jv//j29xZBvgoAVnXTYfbUUzNTYdulXb dKoqfG9sUavR3sHnerJa42TAqyVwheClIhp7bqoZTotP7KdhI9G69mUjHj86rIht2RZY 05RQTo1SfZBxCdIVv8Da0ZnRqfqiHE7y+2FKD12E3apMX3+qyX6iLXtzrN3ZT/YqiqHI B/6A== X-Gm-Message-State: ALoCoQlG/6IY8HweQTZmAckw5vLLPvPA7WRVjAOyNzKvbF68XZkLCl1EoifyO2N1LZa0S6IW6TX/ X-Received: by 10.28.170.18 with SMTP id t18mr113719wme.73.1446599082373; Tue, 03 Nov 2015 17:04:42 -0800 (PST) Received: from xps13.localnet ([93.158.41.25]) by smtp.gmail.com with ESMTPSA id l1sm25859514wmb.1.2015.11.03.17.04.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Nov 2015 17:04:41 -0800 (PST) From: Thomas Monjalon To: Shesha Sreenivasamurthy Date: Wed, 04 Nov 2015 02:03:26 +0100 Message-ID: <6306594.cul4fQvtrc@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5631590F.9040606@intel.com> References: <1446069865-18733-1-git-send-email-shesha@cisco.com> <5631590F.9040606@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8] mem: command line option to delete hugepage backing files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 01:04:42 -0000 2015-10-28 23:23, Sergio Gonzalez Monroy: > On 28/10/2015 22:04, Shesha Sreenivasamurthy wrote: > > When an application using huge-pages crash or exists, the hugetlbfs > > backing files are not cleaned up. This is a patch to clean those files. > > There are multi-process DPDK applications that may be benefited by those > > backing files. Therefore, I have made that configurable so that the > > application that does not need those backing files can remove them, thus > > not changing the current default behavior. The application itself can > > clean it up, however the rationale behind DPDK cleaning it up is, DPDK > > created it and therefore, it is better it unlinks it. > > > > Signed-off-by: Shesha Sreenivasamurthy > > Acked-by: Sergio Gonzalez Monroy > Patch looks good! > > Just a couple of things for the next time ;) > You might be aware of them, but it doesn't hurt to remind them: > - When sending new version, use --in-reply-to to the last version of the > patch sent, it's easier to have all patches on the same thread (if your > email client supports it) > - Also when sending new versions it's useful to add what has changed > from the previous to the new version. > (add such info after the three dashes as shown above) +1 Other things: Some lists like EAL options are alphabetically sorted. When adding a new line, please try to keep the order. Applied with orders fixed, thanks.