[dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

[dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

[Juraj Linkeš]

-moutline-atomics allows LSE instructions to be used if available when
compiling for ARMv8.0 instruction set. It's enabled by default on newer
compilers, such as gcc-10.1. Enable the option so that earlier compiler
versions that support it but don't enable it by default build with it.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 config/arm/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 8728051d5..b195ec850 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -88,7 +88,7 @@ flags_octeontx2_extra = [
 	['RTE_USE_C11_MEM_MODEL', true]]
 
 machine_args_generic = [
-	['default', ['-march=armv8-a+crc']],
+	['default', ['-march=armv8-a+crc', '-moutline-atomics']],
 	['native', ['-march=native']],
 	['0xd03', ['-mcpu=cortex-a53']],
 	['0xd04', ['-mcpu=cortex-a35']],
-- 
2.20.1

Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

[Thomas Monjalon]

01/10/2020 08:19, Juraj Linkeš:
> -moutline-atomics allows LSE instructions to be used if available when
> compiling for ARMv8.0 instruction set. It's enabled by default on newer
> compilers, such as gcc-10.1. Enable the option so that earlier compiler
> versions that support it but don't enable it by default build with it.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  machine_args_generic = [
> -	['default', ['-march=armv8-a+crc']],
> +	['default', ['-march=armv8-a+crc', '-moutline-atomics']],
>  	['native', ['-march=native']],
>  	['0xd03', ['-mcpu=cortex-a53']],
>  	['0xd04', ['-mcpu=cortex-a35']],

Why is it added only to the target "default"?

Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

[Ruifeng Wang]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, October 7, 2020 4:14 AM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: bruce.richardson@intel.com; dev@dpdk.org; jerinj@marvell.com;
> Ruifeng Wang <Ruifeng.Wang@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>
> Subject: Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm
> build
> 
> 01/10/2020 08:19, Juraj Linkeš:
> > -moutline-atomics allows LSE instructions to be used if available when
> > compiling for ARMv8.0 instruction set. It's enabled by default on
> > newer compilers, such as gcc-10.1. Enable the option so that earlier
> > compiler versions that support it but don't enable it by default build with it.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > ---
> >  machine_args_generic = [
> > -	['default', ['-march=armv8-a+crc']],
> > +	['default', ['-march=armv8-a+crc', '-moutline-atomics']],
> >  	['native', ['-march=native']],
> >  	['0xd03', ['-mcpu=cortex-a53']],
> >  	['0xd04', ['-mcpu=cortex-a35']],
> 
> Why is it added only to the target "default"?
> 
Because 'default' target generates Armv8.0 instruction set which doesn't include LSE extension. 
The flag enables LSE instructions when code runs on platforms that implements LSE extension.

For other targets, machine specific 'mcpu' or 'march' flags are used. LSE extension availability can be inferred from the given flags.
So there is not need to add '-moutline-atomics' to them. 

Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

[Thomas Monjalon]

09/10/2020 07:29, Ruifeng Wang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 01/10/2020 08:19, Juraj Linkeš:
> > > -moutline-atomics allows LSE instructions to be used if available when
> > > compiling for ARMv8.0 instruction set. It's enabled by default on
> > > newer compilers, such as gcc-10.1. Enable the option so that earlier
> > > compiler versions that support it but don't enable it by default build with it.
> > >
> > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > ---
> > >  machine_args_generic = [
> > > -	['default', ['-march=armv8-a+crc']],
> > > +	['default', ['-march=armv8-a+crc', '-moutline-atomics']],
> > >  	['native', ['-march=native']],
> > >  	['0xd03', ['-mcpu=cortex-a53']],
> > >  	['0xd04', ['-mcpu=cortex-a35']],
> > 
> > Why is it added only to the target "default"?
> > 
> Because 'default' target generates Armv8.0 instruction set which doesn't include LSE extension. 
> The flag enables LSE instructions when code runs on platforms that implements LSE extension.
> 
> For other targets, machine specific 'mcpu' or 'march' flags are used. LSE extension availability can be inferred from the given flags.
> So there is not need to add '-moutline-atomics' to them. 

OK
It's not obvious that the -mcpu flags implicitly include it.
What do you think adding such explanation in a v2?

Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

[Ruifeng Wang]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, October 9, 2020 2:53 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> Cc: bruce.richardson@intel.com; dev@dpdk.org; jerinj@marvell.com;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm
> build
> 
> 09/10/2020 07:29, Ruifeng Wang:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 01/10/2020 08:19, Juraj Linkeš:
> > > > -moutline-atomics allows LSE instructions to be used if available
> > > > when compiling for ARMv8.0 instruction set. It's enabled by
> > > > default on newer compilers, such as gcc-10.1. Enable the option so
> > > > that earlier compiler versions that support it but don't enable it by
> default build with it.
> > > >
> > > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > ---
> > > >  machine_args_generic = [
> > > > -	['default', ['-march=armv8-a+crc']],
> > > > +	['default', ['-march=armv8-a+crc', '-moutline-atomics']],
> > > >  	['native', ['-march=native']],
> > > >  	['0xd03', ['-mcpu=cortex-a53']],
> > > >  	['0xd04', ['-mcpu=cortex-a35']],
> > >
> > > Why is it added only to the target "default"?
> > >
> > Because 'default' target generates Armv8.0 instruction set which doesn't
> include LSE extension.
> > The flag enables LSE instructions when code runs on platforms that
> implements LSE extension.
> >
> > For other targets, machine specific 'mcpu' or 'march' flags are used. LSE
> extension availability can be inferred from the given flags.
> > So there is not need to add '-moutline-atomics' to them.
> 
> OK
> It's not obvious that the -mcpu flags implicitly include it.
> What do you think adding such explanation in a v2?
> 
Agree. Better to add explanation that this flag benefits distribution build which uses Armv8.0-a as baseline.
More information refer to: https://community.arm.com/developer/tools-software/tools/b/tools-software-ides-blog/posts/making-the-most-of-the-arm-architecture-in-gcc-10

[dpdk-dev] [PATCH v2] build: add -moutline-atomics to default Arm build

[Juraj Linkeš]

-moutline-atomics allows LSE instructions to be used if available when
compiling for ARMv8.0 instruction set. It's enabled by default on newer
compilers, such as gcc-10.1. Enable the option in case an earlier
compiler version is used for the default build that lacks either -mcpu
or -mtune which would otherwise enable it.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 config/arm/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 8728051d5..b195ec850 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -88,7 +88,7 @@ flags_octeontx2_extra = [
 	['RTE_USE_C11_MEM_MODEL', true]]
 
 machine_args_generic = [
-	['default', ['-march=armv8-a+crc']],
+	['default', ['-march=armv8-a+crc', '-moutline-atomics']],
 	['native', ['-march=native']],
 	['0xd03', ['-mcpu=cortex-a53']],
 	['0xd04', ['-mcpu=cortex-a35']],
-- 
2.20.1

Re: [dpdk-dev] [PATCH v2] build: add -moutline-atomics to default Arm build

[Thomas Monjalon]

09/10/2020 11:50, Juraj Linkeš:
> -moutline-atomics allows LSE instructions to be used if available when
> compiling for ARMv8.0 instruction set. It's enabled by default on newer
> compilers, such as gcc-10.1. Enable the option in case an earlier
> compiler version is used for the default build that lacks either -mcpu
> or -mtune which would otherwise enable it.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Applied, thanks

Note: Ruifeng should have been Cc'ed