From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAE86A0527; Mon, 9 Nov 2020 18:01:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A48736947; Mon, 9 Nov 2020 18:01:47 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 958366889 for ; Mon, 9 Nov 2020 18:01:45 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3F2D05C025B; Mon, 9 Nov 2020 12:01:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 09 Nov 2020 12:01:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= GO5GVgJD9Rw2sJOnGnIqZEPipnV0wl02iJjuC59wuQE=; b=HdMsA2JQppHo+1rf 8i7TB5SlyCEQoeJgZGXmp5Yn8qsR8Fdw2cuindvbjK8/R2cpTJsIVj0B/vOBBEvp De+6Sqx/23c0hwUjqTmUtfZb52vWDVaIkI2YjpegTAJS2LggY8cPkCLph0mepIkr uuNrC7k0LR/WzUHocOQlmeHgQsrRUtha/WsEV1lbYlPv/o+VOSP2yH7WbhDA09eU nETsw8iv4Cmm4XrHH6/0M+DqrGgvOUQ5Pn6ff9CDcbXUWTj2XaqLJ/yRFAfZ9Qh7 kldm7omI+HB2GtlSgp8jP04xfscmo6A0+UhfETOfR86tTcp1BT+3JyfQXQoI6FyX DA1tig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=GO5GVgJD9Rw2sJOnGnIqZEPipnV0wl02iJjuC59wu QE=; b=jCWRtccVXpl7V57n1RpzAn1FxjoSVPiyMKuMffPKM6Oac0x86WrvDjvgM /AA2W9hsGz6nOuX8XymzLP/+EW98qtiOtewYLwaAK4AqcRk/c0dZUuUA3LVPLAh3 clxUrLAvfbMuJ0eQEVdI6KUbt4XjDyicXcWRr9ZM7d4jLBdKve3yPYTsTuUSXFZI uaSAfPUUge4MCWOIukXR9awwzit908sq3AtvYp8NAZ8Pc4wrI3sLWMigaykP627c zsDCkfqzteHDScUPftZgTrJMe5iAICT1EQlymllkhlQG/QC175YmUwfxzlfxMPVl BfchulDyw/6P4Y6rhAjmFKGhIBRAw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduhedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A4F333063080; Mon, 9 Nov 2020 12:01:42 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Bruce Richardson , dev@dpdk.org, david.marchand@redhat.com Date: Mon, 09 Nov 2020 18:01:41 +0100 Message-ID: <6314906.8mj7T2phLV@thomas> In-Reply-To: References: <20201109130035.3948462-1-ferruh.yigit@intel.com> <20201109161925.GL831@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2020 17:48, Ferruh Yigit: > On 11/9/2020 4:19 PM, Bruce Richardson wrote: > > On Mon, Nov 09, 2020 at 05:14:24PM +0100, Thomas Monjalon wrote: > >> 09/11/2020 16:44, Bruce Richardson: > >>> On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote: > >>>> 09/11/2020 15:55, Ferruh Yigit: > >>>>> If the 'PKG_CONFIG_PATH' is set in the environment before script run, > >>>>> 32 bit still uses that value for 64-bits libraries. > >>>>> > >>>>> From the build log: > >>>>> > >>>>> " > >>>>> Using DPDK_TARGET i386-pc-linux-gnu > >>>>> meson -Dexamples=l3fwd --buildtype=debugoptimized --werror > >>>>> -Dc_args=-m32 -Dc_link_args=-m32 > >>>>> /tmp/dpdk_maintain/self/dpdk/devtools/.. ./build-32b > >>>>> ... > >>>>> Using 'PKG_CONFIG_PATH' from environment with value: > >>>>> '/usr/local/lib64/pkgconfig/ > >>>>> " > >>>>> > >>>>> This causes build error when linking with the found libraries. > >>>>> > >>>>> Reproduced with 'librte_bpf' which only has 64 bit installed but still > >>>>> enables building 'af_xdp' and link fails. > >>>>> > >>>>> To fix this, using default 'PKG_CONFIG_PATH' variable unless > >>>>> 'CUSTOM_PKG_CONFIG_PATH' set, and set the 'CUSTOM_PKG_CONFIG_PATH' for > >>>>> 32 bit build. > >>>>> > >>>>> Fixes: 9b83106d8784 ("devtools: test 32-bit build") > >>>>> > >>>>> Signed-off-by: Ferruh Yigit > >>>>> --- > >>>>> Cc: Bruce Richardson > >>>>> Cc: Thomas Monjalon > >>>>> > >>>>> v2: > >>>>> * Enable overwriting default 'PKG_CONFIG_PATH' value > >>>> > >>>> It was not my conclusion. > >>>> I think we can just reset all env vars. > >>>> > >>> > >>> Perhaps, but I think that may cause more problems for people who want > >>> custom CFLAGS and LDFLAGS for building with extra 3rd-party packages. > >>> While this can be done using the config script that is sourced in, I > >>> suspect most of us do not use such a script. > >>> > >>> Therefore I'd suggest rather than clearing the env vars globally, we just > >>> override them temporarily for the 32-bit, using CFLAGS32, LDFLAGS32, > >>> PKG_CONFIG_PATH32 instead. That allows someone to have a 32-bit and 64-bit > >>> version of e.g. libbpf installed, with a PKG_CONFIG_PATH pointing to each. > >> > >> So you want to duplicate all vars just to avoid writing them cleanly in a file? > >> And what happens for other targets? > >> > >> I'm tending to nack this approach. > >> There is no problem in using a clean config file. > >> > > Well, when you put it that way :-) > > However, I was only thinking of the 3 variables above, though really it's > > only the PKG_CONFIG_PATH that is going to be the most likely culprit, so > > supporting just one extra var "PKG_CONFIG_PATH_32" seems reasonable. > > > > I'm also ok with your solution of just clearing the environment and relying > > on a config file too, though. > > > > I was worried for any side affects to reset the var, this is smaller change to > change only 'CUSTOM_PKG_CONFIG_PATH' for 'build-32b' > > I can send a new version to reset 'CUSTOM_PKG_CONFIG_PATH', > what is the intention/plan with the config file? You should use a config file to set PKG_CONFIG_PATH, PATH, DPDK_MESON_OPTIONS, etc accordingly to build with all your non-installed dependencies. CUSTOM_PKG_CONFIG_PATH is a way to avoid using the config file in a single case. Don't be afraid breaking the assumption of theoritical users of this script. If we want to avoid PATH reset, we can add such line at the beginning of the script: default_path=${PATH:-/bin:/usr/bin}