From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0FDC32A58 for ; Tue, 13 Jun 2017 18:50:06 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2017 09:50:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,338,1493708400"; d="scan'208";a="97555800" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 13 Jun 2017 09:50:04 -0700 To: Markos Chandras , Nirmoy Das , dev@dpdk.org References: <20170602163116.4631-1-ndas@suse.de> <197454f5-8435-ed5f-63f5-8b6138e613f3@suse.de> <21d80064-8edb-8537-1b59-cb482a56b547@intel.com> <39f781d5-935d-8ada-2922-9803216b3f59@suse.de> From: Ferruh Yigit Message-ID: <63166491-52c0-57f5-2a3b-f28d62d702ac@intel.com> Date: Tue, 13 Jun 2017 17:50:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <39f781d5-935d-8ada-2922-9803216b3f59@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mk: disable new gcc truncation flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2017 16:50:07 -0000 On 6/13/2017 2:49 PM, Markos Chandras wrote: > On 06/13/2017 04:45 PM, Ferruh Yigit wrote: >> On 6/13/2017 10:18 AM, Nirmoy Das wrote: >>> >>> >>> On 06/12/2017 04:35 PM, Markos Chandras wrote: >>>> On 06/02/2017 07:38 PM, Markos Chandras wrote: >>>>> On 06/02/2017 05:31 PM, Nirmoy Das wrote: >>>>>> disable truncation check to ignore below warning >>>>>> dpdk/x86_64-native-linuxapp-gcc-default/build/lib/librte_eal/linuxapp/kni/igb_main.c:2476:30: error: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=] >>>>>> >>>>>> Signed-off-by: Nirmoy Das >>>>>> --- >>>>> I haven't check the code but is this a bogus warning or a real one? If >>>>> it's bogus then could you explain why in the commit message so we do not >>>>> bring it back in the future? If it's a real problem, then perhaps worth >>>>> fixing it instead of masking it? >>>>> >>>> Actually this should have already been fixed in the series posted in >>>> http://dpdk.org/ml/archives/dev/2017-May/065261.html >>> I see the issue in master with CONFIG_RTE_KNI_KMOD_ETHTOOL=y >> >> I confirm the build error, and patch fixes it. >> >> Although that piece of code most probably will not be used at all, and >> previous solution was to disable warnings, since this warning is only >> single place in KNI code, it is easy to fix and I am for fixing it [1], >> what do you think? >> >> >> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h >> b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h >> index d077b49e9..8667f29ca 100644 >> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h >> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h >> @@ -607,7 +607,7 @@ struct igb_adapter { >> int int_mode; >> u32 rss_queues; >> u32 vmdq_pools; >> - char fw_version[32]; >> + char fw_version[43]; >> u32 wvbr; >> struct igb_mac_addr *mac_table; >> #ifdef CONFIG_IGB_VMDQ_NETDEV >> > > Looks reasonable to me Sent http://dpdk.org/dev/patchwork/patch/25297/