From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 475492C8 for ; Sat, 1 Jul 2017 12:56:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DCD9520780; Sat, 1 Jul 2017 06:56:45 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 01 Jul 2017 06:56:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=t889mVSrn9NG5H4 LOzk4wt1Or+3EVbGHsmhKcCLhl/c=; b=nstZmWCjnODXuLYEaP0MZopa+eYNVpI mbXt5Fq3PmQFt3tYIXaesb5CWwM7AzEBCir2X43121dU4+sEqZ/IPBR+NDcBrw9E r8mrdS3zBmypPPE3vvN8fhMHG5dgUT/AOw1ehvGujCDyuOnw7+lpetHPbTZ/G9GH u1CyLkbK4ul0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=t889mVSrn9NG5H4LOzk4wt1Or+3EVbGHsmhKcCLhl/c=; b=Koi3Hm3F 9bQ2MCC6tMouHYQrteM+HOdXlQ3ufe1q5ty/0whCC7cZe+9MEw1ddmcM2ojCgwRy rqNW5pc6yUDENkG8qlAID7viq4EwEuFvPKkr22A/KqCcOIPjOAz6J+65pi8Pms2s CAshLqTXl3SR6Dxh+c19QLwFQfnJT1nEYJrQam6LxxxJT5w9xETdZxcyyOiKoQQe GFTvT/a92xHxTZjhhTnSa+QEpdr5FTxLwHBcMddh3raZ0NcD5bBwQ8X0jmhYSYQl UP/x7We8p2+K10yATdG63HMMuf7jRcsVOUAetP47dqyG1YL1n0eFJmzY08VIgs93 8UV0cRkjXR8ZDA== X-ME-Sender: X-Sasl-enc: 06TMWNNMQKByxGgNczQpRU/vrx2i1MUO8l7fLJveiXfV 1498906605 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D5137E8BF; Sat, 1 Jul 2017 06:56:45 -0400 (EDT) From: Thomas Monjalon To: Gowrishankar Cc: dev@dpdk.org, Ferruh Yigit Date: Sat, 01 Jul 2017 12:56:44 +0200 Message-ID: <6326540.SPDRFXfjDR@xps> In-Reply-To: <4ca53d20-a36a-f769-fefe-1619bd1a36af@intel.com> References: <1494502172-16950-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <1494503486-20876-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <4ca53d20-a36a-f769-fefe-1619bd1a36af@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jul 2017 10:56:47 -0000 07/06/2017 19:20, Ferruh Yigit: > On 5/11/2017 12:51 PM, Gowrishankar wrote: > > From: Gowrishankar Muthukrishnan > > > > In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf > > always into alloc_q, which is excessively leading too many rte_pktmbuf_ > > free() when alloc_q is contending at high packet rate (for eg 10Gig data). > > In a situation when alloc_q fifo can only accommodate very few (or zero) > > mbuf, create only what needed and add in fifo. > > > > With this patch, we could stop random network stall in KNI at higher packet > > rate (eg 1G or 10G data between vEth0 and PMD) sufficiently exhausting > > alloc_q on above condition. I tested i40e PMD for this purpose in ppc64le. > > > > Changes: > > v2 - alloc_q free count calculation corrected. > > line wrap fixed for commit message. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > Acked-by: Ferruh Yigit Applied with this title: "kni: allocate no more mbuf than empty slots in queue" Thanks