From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 5A6411B0F8 for ; Thu, 2 May 2019 23:45:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B709A25CDE; Thu, 2 May 2019 17:45:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 17:45:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BeDXEUh7fwuWkPCLXa2jJwE6W9rzDZhYIrBRKgZ7iTA=; b=gP3HFZ+54pCy DtEBk6N54Ao+1PvBfax3ZM5UtK5fsynV06T6EJShWZyVSJUEH6+EtVfZxguHqYKZ 9J94nAZ+D7BAmpGPGGthZqMYl9CUtzF+jmecgT53534zDOCblOPvwwm0h5CjdzdF jwDxL2B4iRmgdOtz70FvV3phL9CujUg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BeDXEUh7fwuWkPCLXa2jJwE6W9rzDZhYIrBRKgZ7i TA=; b=fK8nmJISrU0mKYnAQuWm2kGyXcM5XMYmYBVQBaIGnvticjbBt2mlfiwcu EPJROlHv4h+p3+zOfOi0HeKrTnkF7V3hpUydruiYVorCier/DH3ZCiNxoedzO/H9 4SzsxG9SAMYdfpVBz+OTD5CeZY4U+z39N3Wz70kKPgwBrmZQzsVC4YzkIckroV2y mnj7x4VafZcqphkzcJKyJKIpbdSQWSfYlPN5eZMe47RaK/pv568hirnXP0EFRtGr qzXujN27TayqLj6pH0O5cvc7wyDNVzRIU/DDKYLeiFQCJiHD8v/et9GJ+WqVCiRs XWDhgxjtiNLkRXfsbfuVCGl+S6Bcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedtgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D2154E40C3; Thu, 2 May 2019 17:45:07 -0400 (EDT) From: Thomas Monjalon To: David Christensen Cc: dev@dpdk.org Date: Thu, 02 May 2019 23:45:06 +0200 Message-ID: <6327337.9PMvuZf6XJ@xps> In-Reply-To: <1556663603-39934-1-git-send-email-drc@linux.vnet.ibm.com> References: <1556663603-39934-1-git-send-email-drc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 21:45:09 -0000 Hi, 01/05/2019 00:33, David Christensen: > The memory barrier test fails on IBM Power 9 systems. Add additional > barriers to accommodate the weakly ordered model used on Power CPUs. > > Signed-off-by: David Christensen [...] > --- a/app/test/test_barrier.c > +++ b/app/test/test_barrier.c > @@ -36,7 +36,7 @@ > #include "test.h" > > #define ADD_MAX 8 > -#define ITER_MAX 0x100000000 > +#define ITER_MAX 0x1000000 This is a revert of a change done in patch 3. > @@ -92,12 +92,19 @@ struct lcore_plock_test { > other = self ^ 1; > > l->flag[self] = 1; > +#ifdef RTE_ARCH_PPC_64 > + rte_smp_wmb(); > +#endif You should not have such #ifdef in a test case supposed to run on all architectures with the same code. What can be fixed in EAL? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 946D8A0AC5 for ; Thu, 2 May 2019 23:45:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACC431B0F9; Thu, 2 May 2019 23:45:10 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 5A6411B0F8 for ; Thu, 2 May 2019 23:45:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B709A25CDE; Thu, 2 May 2019 17:45:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 17:45:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BeDXEUh7fwuWkPCLXa2jJwE6W9rzDZhYIrBRKgZ7iTA=; b=gP3HFZ+54pCy DtEBk6N54Ao+1PvBfax3ZM5UtK5fsynV06T6EJShWZyVSJUEH6+EtVfZxguHqYKZ 9J94nAZ+D7BAmpGPGGthZqMYl9CUtzF+jmecgT53534zDOCblOPvwwm0h5CjdzdF jwDxL2B4iRmgdOtz70FvV3phL9CujUg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BeDXEUh7fwuWkPCLXa2jJwE6W9rzDZhYIrBRKgZ7i TA=; b=fK8nmJISrU0mKYnAQuWm2kGyXcM5XMYmYBVQBaIGnvticjbBt2mlfiwcu EPJROlHv4h+p3+zOfOi0HeKrTnkF7V3hpUydruiYVorCier/DH3ZCiNxoedzO/H9 4SzsxG9SAMYdfpVBz+OTD5CeZY4U+z39N3Wz70kKPgwBrmZQzsVC4YzkIckroV2y mnj7x4VafZcqphkzcJKyJKIpbdSQWSfYlPN5eZMe47RaK/pv568hirnXP0EFRtGr qzXujN27TayqLj6pH0O5cvc7wyDNVzRIU/DDKYLeiFQCJiHD8v/et9GJ+WqVCiRs XWDhgxjtiNLkRXfsbfuVCGl+S6Bcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedtgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D2154E40C3; Thu, 2 May 2019 17:45:07 -0400 (EDT) From: Thomas Monjalon To: David Christensen Cc: dev@dpdk.org Date: Thu, 02 May 2019 23:45:06 +0200 Message-ID: <6327337.9PMvuZf6XJ@xps> In-Reply-To: <1556663603-39934-1-git-send-email-drc@linux.vnet.ibm.com> References: <1556663603-39934-1-git-send-email-drc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502214506.1Avi0pWFVxpA6U1N8YQerqt_4MeKgGyNJO0izYEs9R0@z> Hi, 01/05/2019 00:33, David Christensen: > The memory barrier test fails on IBM Power 9 systems. Add additional > barriers to accommodate the weakly ordered model used on Power CPUs. > > Signed-off-by: David Christensen [...] > --- a/app/test/test_barrier.c > +++ b/app/test/test_barrier.c > @@ -36,7 +36,7 @@ > #include "test.h" > > #define ADD_MAX 8 > -#define ITER_MAX 0x100000000 > +#define ITER_MAX 0x1000000 This is a revert of a change done in patch 3. > @@ -92,12 +92,19 @@ struct lcore_plock_test { > other = self ^ 1; > > l->flag[self] = 1; > +#ifdef RTE_ARCH_PPC_64 > + rte_smp_wmb(); > +#endif You should not have such #ifdef in a test case supposed to run on all architectures with the same code. What can be fixed in EAL?