From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7DF551B6B7 for ; Fri, 3 Nov 2017 23:39:20 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2017 15:39:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,339,1505804400"; d="scan'208";a="1239528566" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.48]) ([10.241.225.48]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2017 15:39:18 -0700 From: Ferruh Yigit To: Thomas Monjalon , "Mody, Rasesh" Cc: Stephen Hemminger , "Tan, Jianfeng" , Jingjing Wu , "Thotton, Shijith" , Gregory Etelson , "Patil, Harish" , dev@dpdk.org, George Prekas , Sergio Gonzalez Monroy , "Roberts, Lee A." References: <506f596c-f7e3-56b1-d13a-17b49bc3945a@intel.com> <12814007.65nxXEtm0z@xps> Message-ID: <632b3143-c508-e875-2ef4-b6f9f9ef752c@intel.com> Date: Fri, 3 Nov 2017 15:39:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 22:39:20 -0000 On 11/3/2017 3:20 PM, Ferruh Yigit wrote: > On 11/3/2017 12:24 PM, Thomas Monjalon wrote: >> 03/11/2017 20:18, Mody, Rasesh: >>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >>>> On 11/2/2017 11:45 AM, Mody, Rasesh wrote: >>>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >>>>>> On 11/2/2017 10:34 AM, Mody, Rasesh wrote: >>>>> We are ok as we have at least some way to disable the reset, please send a >>>> patch. >>>> >>>> Sent http://dpdk.org/dev/patchwork/patch/31143/, can you please test? >>> >>> The testing of BNX2X looks OK with this patch. However, the solution has following drawbacks: >>> - an application will need to be recompiled to have the igb_uio kernel module rebuilt to support bnx2x devices >>> - this will break pre-compiled solutions that are provided with an OS such as RHOSP or as part of a pre-compiled VNF >>> >>> We can live with this temporary solution for now. In the long term, we may have to revisit this. >>> We are also looking at why bnx2x FLR is taking this long. >> >> Yes, I think the long term solution should be to fix your PMD >> or your firmware. >> Please keep us posted when you find the root cause with your device. >> Thanks > > Lee Roberts suggested doing device specific action instead of build time option. > > I send following: > http://dpdk.org/dev/patchwork/patch/31168/ > > What do you think about this approach? > > Meanwhile I will send a more proper patch to discuss on. http://dpdk.org/dev/patchwork/patch/31169/