From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3C24A2C5 for ; Tue, 18 Apr 2017 13:15:56 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 18 Apr 2017 04:15:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,219,1488873600"; d="scan'208";a="1137131724" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.255.30.233]) ([10.255.30.233]) by fmsmga001.fm.intel.com with ESMTP; 18 Apr 2017 04:15:53 -0700 To: Olivier MATZ References: <20170329155323.4760-1-olivier.matz@6wind.com> <20170404164040.24132-1-olivier.matz@6wind.com> <20170404164040.24132-5-olivier.matz@6wind.com> <88ff6283-4b3f-f3a7-0d44-9be8fe5441c1@intel.com> <20170418105047.266cd8a0@glumotte.dev.6wind.com> Cc: dev@dpdk.org, david.marchand@6wind.com, bruce.richardson@intel.com, thomas.monjalon@6wind.com, keith.wiles@intel.com, stephen@networkplumber.org, "De Lara Guarch, Pablo" From: "Tan, Jianfeng" Message-ID: <632c7fa5-153d-8a97-0810-a4ac8795046e@intel.com> Date: Tue, 18 Apr 2017 19:15:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170418105047.266cd8a0@glumotte.dev.6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 11:15:57 -0000 On 4/18/2017 4:50 PM, Olivier MATZ wrote: > Hi Jianfeng, > > On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" wrote: >> Hi Olivier, >> >> If I understand it correctly, this patch is to shift log level setting >> earlier. But we did not remove the one in eal_parse_common_option(). So >> we can see this parameter will be analyzed twice. Does it make sense to >> remove analysis of log level in eal_parse_common_option()? >> > The patch does not change the way the log level is parsed: it was > already parsed twice, because we want to know the log level as soon > as possible. Oh, yes, it's not introduced in this patch. How do you think if we move log parser out from eal_parse_common_option to avoid parsing log twice? > > But the patch introduces a bug, as seen by Ferruh: the default log > level is not set properly when no --log-level parameter is passed. > Before this one, there is another one on usage of regexec(), which I put it here: http://dpdk.org/ml/archives/dev/2017-April/064031.html. Thanks, Jianfeng