Re: [PATCH next 0/7] vmxnet3: upgrade to version 7

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 4/26/2023 5:54 PM, Ferruh Yigit wrote:
> On 4/12/2023 5:26 PM, Ronak Doshi wrote:
>> vmxnet3 emulation has recently added several new features including
>> support for uniform passthrough(UPT). To make UPT work vmxnet3 has
>> to be enhanced as per the new specification. This patch series
>> extends the vmxnet3 driver to leverage these new features.
>>
>> Compatibility is maintained using existing vmxnet3 versioning mechanism as
>> follows:
>> - new features added to vmxnet3 emulation are associated with new vmxnet3
>>    version viz. vmxnet3 version 7.
>> - emulation advertises all the versions it supports to the driver.
>> - during initialization, vmxnet3 driver picks the highest version number
>> supported by both the emulation and the driver and configures emulation
>> to run at that version.
>>
>> In particular, following changes are introduced:
>>
>> Patch 1:
>>   This patch introduces utility macros for vmxnet3 version 7 comparison
>>   and updates Copyright information.
>>
>> Patch 2:
>>   This patch adds new capability registers to fine control enablement of
>>   individual features based on emulation and passthrough.
>>
>> Patch 3:
>>   This patch adds support for large passthrough BAR register.
>>
>> Patch 4:
>>   This patch introduces new command to set ring buffer sizes to pass this
>>   information to the hardware.
>>
>> Patch 5:
>>   For better performance, hardware has a requirement to limit number of TSO
>>   descriptors. This patch adds that support.
>>
>> Patch 6:
>>   Avoid updating rxprod register when in UPT for performance reasons.
>>
>> Patch 7:
>>   With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver,
>>   with this patch, the driver can configure emulation to run at vmxnet3
>>   version 7.
>>
>> Ronak Doshi (7):
>>   vmxnet3: prepare for version 7 changes
>>   vmxnet3: add support for capability registers
>>   vmxnet3: add support for large passthrough BAR register
>>   vmxnet3: add command to set ring buffer sizes
>>   vmxnet3: limit number of TXDs used for TSO packet
>>   vmxnet3: avoid updating rxprod register frequently
>>   vmxnet3: update to version 7
>>
> 
> Can you please start the patch title with component: "net/vmxnet3: ..."
> 
>>  drivers/net/vmxnet3/base/vmxnet3_defs.h |  74 +++++++++++++++++++---
>>  drivers/net/vmxnet3/vmxnet3_ethdev.c    | 106 +++++++++++++++++++++++++++++++-
>>  drivers/net/vmxnet3/vmxnet3_ethdev.h    |  16 +++++
>>  drivers/net/vmxnet3/vmxnet3_ring.h      |   2 +-
>>  drivers/net/vmxnet3/vmxnet3_rxtx.c      |  48 +++++++++++----
>>  lib/ethdev/rte_ethdev.h                 |   2 +
>>  6 files changed, 226 insertions(+), 22 deletions(-)
>>
> 
> Can you please update release notes to document the driver update?
> 
> Also what do you think to update driver documentation to document
> uniform passthrough(UPT) support, how to use it etc? Or other features
> coming with V7?
> 


btw, while checking the driver documentation, it seems it is not updated
for a while, the paper it refers is old.
Do you have any newer version of documentation to reference?