[dpdk-dev] [PATCH] ethdev: bump library version

[dpdk-dev] [PATCH] ethdev: bump library version

[Thomas Monjalon]

The old offload API is removed in 18.08,
so the library version must be increased,
in order to show the incompatibility with 18.05 one.

Fixes: ab3ce1e0c193 ("ethdev: remove old offload API")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/release_18_08.rst | 13 ++++++++++++-
 lib/librte_ethdev/Makefile             |  2 +-
 lib/librte_ethdev/meson.build          |  2 +-
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst
index 9849fec7d..a3546c892 100644
--- a/doc/guides/rel_notes/release_18_08.rst
+++ b/doc/guides/rel_notes/release_18_08.rst
@@ -131,6 +131,17 @@ API Changes
   - ``rte_mempool_xmem_size``
   - ``rte_mempool_xmem_usage``
 
+* ethdev: The old offload API is removed:
+
+  - Rx per-port ``rte_eth_conf.rxmode.[bit-fields]``
+  - Tx per-queue ``rte_eth_txconf.txq_flags``
+  - ``ETH_TXQ_FLAGS_NO*``
+
+  The transition bits are removed:
+
+  - ``rte_eth_conf.rxmode.ignore_offload_bitfield``
+  - ``ETH_TXQ_FLAGS_IGNORE``
+
 * cryptodev: In struct ``struct rte_cryptodev_info``, field ``rte_pci_device *pci_dev``
   has been replaced with field ``struct rte_device *device``.
   Value 0 is accepted in ``sym.max_nb_sessions``, meaning that a device
@@ -243,7 +254,7 @@ The libraries prepended with a plus sign were incremented in this version.
    + librte_cryptodev.so.5
      librte_distributor.so.1
      librte_eal.so.7
-     librte_ethdev.so.9
+   + librte_ethdev.so.10
      librte_eventdev.so.4
      librte_flow_classify.so.1
      librte_gro.so.1
diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile
index c2f2f7d82..0935a275e 100644
--- a/lib/librte_ethdev/Makefile
+++ b/lib/librte_ethdev/Makefile
@@ -16,7 +16,7 @@ LDLIBS += -lrte_mbuf
 
 EXPORT_MAP := rte_ethdev_version.map
 
-LIBABIVER := 9
+LIBABIVER := 10
 
 SRCS-y += rte_ethdev.c
 SRCS-y += rte_flow.c
diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
index aed5d2265..596cd0f39 100644
--- a/lib/librte_ethdev/meson.build
+++ b/lib/librte_ethdev/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 name = 'ethdev'
-version = 9
+version = 10
 allow_experimental_apis = true
 sources = files('ethdev_profile.c',
 	'rte_ethdev.c',
-- 
2.17.1

Re: [dpdk-dev] [PATCH] ethdev: bump library version

[Andrew Rybchenko]

On 06.08.2018 13:55, Thomas Monjalon wrote:
> The old offload API is removed in 18.08,
> so the library version must be increased,
> in order to show the incompatibility with 18.05 one.
>
> Fixes: ab3ce1e0c193 ("ethdev: remove old offload API")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

Re: [dpdk-dev] [PATCH] ethdev: bump library version

[Thomas Monjalon]

06/08/2018 19:52, Andrew Rybchenko:
> On 06.08.2018 13:55, Thomas Monjalon wrote:
> > The old offload API is removed in 18.08,
> > so the library version must be increased,
> > in order to show the incompatibility with 18.05 one.
> >
> > Fixes: ab3ce1e0c193 ("ethdev: remove old offload API")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied

Re: [dpdk-dev] [PATCH] ethdev: bump library version

[Andrew Rybchenko]

On 10/27/19 9:14 AM, David Marchand wrote:
> Let's stick to the current model of per library ABI version until the
> new model is in place.
>
> Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Thanks.

Re: [dpdk-dev] [PATCH] ethdev: bump library version

[David Marchand]

On Sun, Oct 27, 2019 at 10:02 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 27/10/2019 07:14, David Marchand:
> > Let's stick to the current model of per library ABI version until the
> > new model is in place.
> >
> > Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> In order to make it more obvious, it would be nice to explain that
> the ABI has changed and it is reflected in the release notes
> but not in the compiled version number.

Ok, done.

>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.



--
David Marchand

Re: [dpdk-dev] [PATCH] ethdev: bump library version

[Thomas Monjalon]

27/10/2019 07:14, David Marchand:
> Let's stick to the current model of per library ABI version until the
> new model is in place.
> 
> Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

In order to make it more obvious, it would be nice to explain that
the ABI has changed and it is reflected in the release notes
but not in the compiled version number.

Acked-by: Thomas Monjalon <thomas@monjalon.net>

[dpdk-dev] [PATCH] ethdev: bump library version

[David Marchand]

Let's stick to the current model of per library ABI version until the
new model is in place.

Fixes: 4f25d7d2252f ("ethdev: add return code to device info get function")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_ethdev/Makefile    | 2 +-
 lib/librte_ethdev/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile
index 60bcc22..0efcdfa 100644
--- a/lib/librte_ethdev/Makefile
+++ b/lib/librte_ethdev/Makefile
@@ -16,7 +16,7 @@ LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_meter
 
 EXPORT_MAP := rte_ethdev_version.map
 
-LIBABIVER := 12
+LIBABIVER := 13
 
 SRCS-y += ethdev_private.c
 SRCS-y += rte_ethdev.c
diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
index f75d428..c22cf81 100644
--- a/lib/librte_ethdev/meson.build
+++ b/lib/librte_ethdev/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 name = 'ethdev'
-version = 12
+version = 13
 allow_experimental_apis = true
 sources = files('ethdev_private.c',
 	'ethdev_profile.c',
-- 
1.8.3.1