From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A611EA0546; Tue, 6 Apr 2021 16:05:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEF67140FBA; Tue, 6 Apr 2021 16:05:22 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id B5ECE140FB5 for ; Tue, 6 Apr 2021 16:05:21 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A656580522; Tue, 6 Apr 2021 10:05:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 06 Apr 2021 10:05:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= JFDOkoMedmXAnO5eTBegKnrqMp8KPj4jRrPcICa0Yqo=; b=kpu9IMMmiieMJakf CBXa5TzRyZ2o2Fu+k+tM6lF7jonYHxHsi8EDAPvpnZbgDwzkzLI4+2i2tUQyoYWf mQcuzljDmNUd99O49f+AKpMjySOVJzph62x5mz1rO96CPqlmxYndF8ZPbJuTG5Qr VakOqFdVVzCZJ9HwkR6q01Wl2x8jPAN9zdrOIm8ETWASWUusiS6iiOOKvpBpyL/x 52yJfmKJp/fnCOwTQ3/ImNxxd8TSqz3XdALTzBD8go2F0oKunj1c7QwT202b++Nv iXClFuH4P6fGhdJu29tst4fswYEwBB/V2voLArWTv7wCwauCn1C5q8xjJDWYer+7 lCVb3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=JFDOkoMedmXAnO5eTBegKnrqMp8KPj4jRrPcICa0Y qo=; b=IxzdNwhkE7qTjT7pqnJKoT9GnImTDlxW0NzWnT9WAhukwd0ApBD8FPv93 aSe3F7QJLWoHSqSUOGjJeXjuVKqnuy/yIx+0GxmGDFYvK3co4AjO8RHZS4HLijOh pd52FwkvNQTRUBE759mOtuvxBlL8mqAnnd9lqdNesFi8sOwtf0mWhxbND9sl5vKU aZccPKXCJXr/g5FzRMdJ3PRDIt9dtfAbAdTz2uaTBnkCEvvShcG0fUPtgwV1TeX+ 6dWb5B2U0HOG51LdQYU4WpAudm8nddplKw5Ltv+8cfHlFd3ldD7KJpRc3ihepeGp NTaQsnFVCWynyOCKNSg50sWLmlPJw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejhedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D78601080057; Tue, 6 Apr 2021 10:05:18 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dpdk-dev , David Marchand , Wisam Jaddo , Bruce Richardson , Andrew Rybchenko , Reshma Pattan , Maryam Tahhan , Konstantin Ananyev , Nicolas Chautru , Declan Doherty , Ciara Power , Vladimir Medvedkin , Xiaoyun Li , Ori Kam , Bernard Iremonger Date: Tue, 06 Apr 2021 16:05:17 +0200 Message-ID: <6370247.Qzv5sXHzo9@thomas> In-Reply-To: References: <20210309233116.1934666-1-thomas@monjalon.net> <20210405193954.1115838-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 4/4] app: hook in EAL usage help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2021 15:32, Jerin Jacob: > On Tue, Apr 6, 2021 at 1:10 AM Thomas Monjalon wrote: > > > > Use rte_set_application_usage_hook() in the test applications, > > so the full help including EAL options can be printed in one go > > with the EAL option -h or --help. [...] > > + rte_set_application_usage_hook(print_usage); > > All DPDK APIs, We are having rte_<...> kind of API > name convention. > I think, it is better to change to rte_application_usage_hook_set() to > express the hierarchy. The naming of this function is not fantastic. Without thinking about a better name, we should ask if we want to go through a deprecation of this function name?